- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: frontend: Fix css on Firefox 24.5
by tjelinek＠redhat.com 24 Jul '14

24 Jul '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Fix css on Firefox 24.5 ...................................................................... frontend: Fix css on Firefox 24.5 Fixed the positioning of the checkbox label in the SerialNumberPolicyWidget. Change-Id: I51cba6e0e4fe165f99e7638652e6f1286f68318c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1115326 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.ui.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/30019 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51cba6e0e4fe165f99e7638652e6f1286f68318c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: update blank template origin type
by ofrenkel＠redhat.com 24 Jul '14

24 Jul '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: update blank template origin type ...................................................................... core: update blank template origin type currently the origin type for blank template is always RHEV there is a config in the db for the default origin type of vms so this patch uses this config to update blank template to the current configuration, should be OVIRT in most cases. Change-Id: Ib844899a61093c1c2b70a34adcddb0b9bca83b37 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057211 --- A packaging/dbscripts/upgrade/03_06_0050_update_blank_template_origin_type.sql 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30111 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib844899a61093c1c2b70a34adcddb0b9bca83b37 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: custom fencing settings are not save to DB
by piotr.kliczewski＠gmail.com 24 Jul '14

24 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: custom fencing settings are not save to DB ...................................................................... core: custom fencing settings are not save to DB 3.5 version introduced a new way to define custom fencing agents. However, there is a bug that caused custom PM agent settings not to be saved in DB. The UpdateVdsCommand canDoAction checks for validity of the agent and it comapres the selected agent against all of agents supported natively by the agent. The code was changed to take into account custom PM agents as well in the canDoAction validation Change-Id: If41fb226cbb3a80aa2a524e22756a91553dec1b1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1122473 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If41fb226cbb3a80aa2a524e22756a91553dec1b1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: unlock_entity.sh fails on authentication
by piotr.kliczewski＠gmail.com 24 Jul '14

24 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: unlock_entity.sh fails on authentication ...................................................................... core: unlock_entity.sh fails on authentication The DB was configured in pg_hba.conf with md5 This means that in order to run this utility properly you should set the PGPASSWORD or PGPASSFILE environment variable. Example: \$ PGPASSWORD=xxxxxx ./unlock_entity.sh -t disk -q I had added this information to the utility help Change-Id: I6055bec6b91d5eb101e6655ed4eea481a6a082f9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1118191 Signed-off-by: Eli Mesika <emesika(a)redhat.com> (cherry picked from commit ea90fe17b2e6e0c839a54ced0407d99059146fc4) --- M packaging/dbscripts/unlock_entity.sh 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6055bec6b91d5eb101e6655ed4eea481a6a082f9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : Fix sporadic failure of BackwardCompatibilityTaskCr...
by yzaslavs＠redhat.com 23 Jul '14

23 Jul '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine : Fix sporadic failure of BackwardCompatibilityTaskCreationTest ...................................................................... engine : Fix sporadic failure of BackwardCompatibilityTaskCreationTest testConcreateCreateTaskBackwardsComaptibility test in BackwardCompatibilityTaskCreationTest has sporadic failures due the changes in AsyncTaskFactory.construct method. Change-Id: I8d3b24582ed27384e0e46aad454a3c6fafb5130b Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ravi Nori: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d3b24582ed27384e0e46aad454a3c6fafb5130b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Changed event message for suspended shutdown
by ofrenkel＠redhat.com 23 Jul '14

23 Jul '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: Changed event message for suspended shutdown ...................................................................... core: Changed event message for suspended shutdown Changed event message text displayed at audit log during power off\shutdown of a suspended VM. Change-Id: If788ab1117244b6fd211c17e99ddb8d31a794d35 Bug-Url: https://bugzilla.redhat.com/1073437 Signed-off-by: Eldan Shachar <eshachar(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30495 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If788ab1117244b6fd211c17e99ddb8d31a794d35 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: dal: Refactor VmDaoDbFacadeImpl row mapping
by ofrenkel＠redhat.com 23 Jul '14

23 Jul '14

Omer Frenkel has submitted this change and it was merged. Change subject: dal: Refactor VmDaoDbFacadeImpl row mapping ...................................................................... dal: Refactor VmDaoDbFacadeImpl row mapping Make VmRowMapper delegate to Vm{Static,Dynamic,Statistics}RowMapper for suitable fields and remove duplication. It was necessary to rename some of the columns in the vms and vms_with_tags views to match those used in vm_static to make the delegation possible. Change-Id: Ifa158b5d7a37661cf4c1cc1f01ea4db062a8e11f Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmBaseDaoDbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStatisticsDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java M packaging/dbscripts/create_views.sql 9 files changed, 105 insertions(+), 231 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29670 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa158b5d7a37661cf4c1cc1f01ea4db062a8e11f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: set the engine session ID as the reports token
by oourfali＠redhat.com 23 Jul '14

23 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: set the engine session ID as the reports token ...................................................................... webadmin: set the engine session ID as the reports token Recent changes in the engine set the session ID differently. In the past it was identical to the JSESSIONID, but now it is a generated one. This patch sets the reports SSO token to the returned session ID upon login, which is the engine-generated session ID. Change-Id: Id57589fb6266ca513607f474070bd9769e31c2e5 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1122582 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shirly Radco: Verified Alexander Wels: Looks good to me, approved Yaniv Dary: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30593 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id57589fb6266ca513607f474070bd9769e31c2e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: custom fencing settings are not save to DB
by oourfali＠redhat.com 23 Jul '14

23 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: custom fencing settings are not save to DB ...................................................................... core: custom fencing settings are not save to DB 3.5 version introduced a new way to define custom fencing agents. However, there is a bug that caused custom PM agent settings not to be saved in DB. The UpdateVdsCommand canDoAction checks for validity of the agent and it comapres the selected agent against all of agents supported natively by the agent. The code was changed to take into account custom PM agents as well in the canDoAction validation Change-Id: If41fb226cbb3a80aa2a524e22756a91553dec1b1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1122473 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If41fb226cbb3a80aa2a524e22756a91553dec1b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: don't die when broker disconnects
by msivak＠redhat.com 23 Jul '14

23 Jul '14

Martin Sivák has submitted this change and it was merged. Change subject: don't die when broker disconnects ...................................................................... don't die when broker disconnects Change-Id: Ibd8627346c03894c1654af5d41c3caaf9f3a5ffa Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093646 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/agent.py M ovirt_hosted_engine_ha/agent/constants.py.in M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/lib/brokerlink.py 4 files changed, 29 insertions(+), 3 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jiří Moskovčák: Verified -- To view, visit http://gerrit.ovirt.org/30641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd8627346c03894c1654af5d41c3caaf9f3a5ffa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.2 Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0