- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: GetRngDeviceQuery should be a user query
by ofrenkel＠redhat.com 24 Jul '14

24 Jul '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: GetRngDeviceQuery should be a user query ...................................................................... core: GetRngDeviceQuery should be a user query Change-Id: I5589c7185a61c076123aee962c8ea2c097920617 Bug-Url: https://bugzilla.redhat.com/1122427 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetRngDeviceQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 2 files changed, 9 insertions(+), 4 deletions(-) Approvals: Frank Kobzik: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30618 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5589c7185a61c076123aee962c8ea2c097920617 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Create new VM | Not all selected nics are created ...
by piotr.kliczewski＠gmail.com 24 Jul '14

24 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Create new VM | Not all selected nics are created on the VM ...................................................................... webadmin: Create new VM | Not all selected nics are created on the VM Opening and closing ghost profile instance type editor without selecting a value causes the first acceptable value to be displayed at the header text box (just to be displayed, not really be selected-> the real value is still null). It is caused because ListModelTypeAheadListBox->adjustSelectedValue() calls in the described case- 'setValue(acceptableValues.iterator().next())' without firing valueChange event. The displayed value is changed, but the model.selectedValue is still null. Calling setValue with 'true' for 'fireValueChangeEvent' fixes the issue. But, as I understand, if the the selected value ('getValue()') was 'null' and wasn't changed manually to another value. There is no reason to override it here by the first item in the list. Change-Id: Iaa8ec33db813f334f07baadac38f27c5544f0791 Bug-Url: https://bugzilla.redhat.com/1115788 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> (cherry picked from commit 27b97db8ba54239eb7a01477fea4e499df1ba395) --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java 1 file changed, 13 insertions(+), 14 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa8ec33db813f334f07baadac38f27c5544f0791 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: frontend: Fix css on Firefox 24.5
by piotr.kliczewski＠gmail.com 24 Jul '14

24 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: frontend: Fix css on Firefox 24.5 ...................................................................... frontend: Fix css on Firefox 24.5 Fixed the positioning of the checkbox label in the SerialNumberPolicyWidget. Change-Id: I51cba6e0e4fe165f99e7638652e6f1286f68318c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1115326 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.ui.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/30672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51cba6e0e4fe165f99e7638652e6f1286f68318c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: improve the console tab UI
by tjelinek＠redhat.com 24 Jul '14

24 Jul '14

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: improve the console tab UI ...................................................................... webadmin: improve the console tab UI This patch fix the UI brokeness in the console TAB of the VM popup introduced by the new spice tuning options. Change-Id: Ifd7820ebcd6732eb3bba4e4a462d10653dbf10d5 Bug-Url: https://bugzilla.redhat.com/1115327 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/29577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd7820ebcd6732eb3bba4e4a462d10653dbf10d5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Fix issues with VmRngDevice.Source enum
by tjelinek＠redhat.com 24 Jul '14

24 Jul '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Fix issues with VmRngDevice.Source enum ...................................................................... frontend: Fix issues with VmRngDevice.Source enum this patch fixes problems with ^ enum parsing in ClusterModel. This enum is represented as lower-case string in the engine config. When matching this enum to its string representation, toLowerCase() must be called firstly. Change-Id: Ieeb5660fe5da4ea1ba913247150d4c63cecae1bb Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/977079 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/28924 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieeb5660fe5da4ea1ba913247150d4c63cecae1bb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Hide vlan information of imported network
by masayag＠redhat.com 24 Jul '14

24 Jul '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Hide vlan information of imported network ...................................................................... engine: Hide vlan information of imported network The vlan id of an imported network should not be exposed to the engine, so it won't be persisted when the network is saved. Change-Id: I972ff166c4cdefe5b84b28aead245a3fed2b10ba Bug-Url: https://bugzilla.redhat.com/1031382 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/30654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I972ff166c4cdefe5b84b28aead245a3fed2b10ba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Report event for external port removal failure
by masayag＠redhat.com 24 Jul '14

24 Jul '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Report event for external port removal failure ...................................................................... engine: Report event for external port removal failure If an external network provider is inaccessible, the engine command should not be failed. Instead, the port removal failure will be logged to the events log for a future reference for the admin to handle it on the neutron server. Change-Id: I57d42da98ff1c86f242f53204520fd4e219b3205 Bug-Url: https://bugzilla.redhat.com/1102542 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ExternalNetworkManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 22 insertions(+), 4 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57d42da98ff1c86f242f53204520fd4e219b3205 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Wrong vnic profiles on vm based on template from ano...
by alkaplan＠redhat.com 24 Jul '14

24 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Wrong vnic profiles on vm based on template from another cluster ...................................................................... engine: Wrong vnic profiles on vm based on template from another cluster If- 1. New vm is based on template from different cluster (or even dc in case of 'Blank' template). And 2. The template has nics which's profile's network is not attached to the vm's cluster. Then- The profiles on the vm's nics should be overridden by 'Empty' profiles. Change-Id: I678c8db0e56c9ba9e9e947028d14ae4ddae76e0a Bug-Url: https://bugzilla.redhat.com/1103058 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30639 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I678c8db0e56c9ba9e9e947028d14ae4ddae76e0a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Throw canDo on addVmCommand if template is not in cl...
by alkaplan＠redhat.com 24 Jul '14

24 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Throw canDo on addVmCommand if template is not in cluster ...................................................................... engine: Throw canDo on addVmCommand if template is not in cluster added a canDo- 'VdcBllMessages.ACTION_TYPE_FAILED_TEMPLATE_NOT_EXISTS_IN_CURRENT_DC' to- AddVmCommand- if the templates is not in the vm's dc. AddVmFromScratchCommand- if the templates is not in the vm's dc and not 'Blank'. Change-Id: I2566b18049bf7603700572dc5d419a640f294ada Bug-Url: https://bugzilla.redhat.com/1103058 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 22 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2566b18049bf7603700572dc5d419a640f294ada Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Wrong vnics when creating vm from blank template
by alkaplan＠redhat.com 24 Jul '14

24 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Wrong vnics when creating vm from blank template ...................................................................... webadmin: Wrong vnics when creating vm from blank template The 'Blank' template belongs to the 'Default' dc/cluster. If the 'Blank' template has vnics with profiles, when creating a vm in different cluster than 'Default' the vnic profiles (which don't exist in the vm's cluster) should be overridden by 'Empty' profile. This override happens in EditProfileBehavior->initSelectedProfile, but since it is called before the registration of ProfileInstanceTypeEditor to SelectedItemChangedEvent of VnicInstanceType the new selection of 'Empty' profile isn't reflected on VnicInstanceType.NetworkInterface. This patch fixes it by calling syncSelectedItemWithNetworkInterface(..) also before the registration and not just from the eventRaised(..). Change-Id: I60be6b21050c43bb004e56688f8e306b5b943d24 Bug-Url: https://bugzilla.redhat.com/1103058 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.java 1 file changed, 10 insertions(+), 7 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60be6b21050c43bb004e56688f8e306b5b943d24 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0