- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine : Command Executor should persist command before subm...
by oourfali＠redhat.com 24 Jul '14

24 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine : Command Executor should persist command before submitting to threadpool ...................................................................... engine : Command Executor should persist command before submitting to threadpool Command Coordinator should persist command before submitting command to thread pool for execution. On server restarted the commands that have not started execution are failed Change-Id: I4d510836dc822a95198dc1db4a4f74206466f0c9 Bug-Url: https://bugzilla.redhat.com/1113256 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java 1 file changed, 79 insertions(+), 18 deletions(-) Approvals: Ravi Nori: Verified Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d510836dc822a95198dc1db4a4f74206466f0c9 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core, userportal: Cannot add AD group to a new VM from the u...
by oourfali＠redhat.com 24 Jul '14

24 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core, userportal: Cannot add AD group to a new VM from the user portal ...................................................................... core, userportal: Cannot add AD group to a new VM from the user portal After creating a new VM from the user portal, it's not possible to add an AD group to the VM Change-Id: I9cce0e664b5bbe0110a03f41e1d6eb9c822cf8ef Bug-Url: https://bugzilla.redhat.com/1114041 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserPortalAdElementListModel.java 4 files changed, 92 insertions(+), 26 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29818 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cce0e664b5bbe0110a03f41e1d6eb9c822cf8ef Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.5]: configure.ac: Set rpm release to 0
by dougsland＠redhat.com 24 Jul '14

24 Jul '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: configure.ac: Set rpm release to 0 ...................................................................... configure.ac: Set rpm release to 0 We are going to ship the ovirt-3.5, time to set the rpm release to 0. Change-Id: If78946c168f22a1497f5e54e8e6d707f22c0e593 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If78946c168f22a1497f5e54e8e6d707f22c0e593 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Keep validation/event message if there is an iso u...
by oourfali＠redhat.com 24 Jul '14

24 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Keep validation/event message if there is an iso update to ovirt node host ...................................................................... webadmin: Keep validation/event message if there is an iso update to ovirt node host The code for checking if there is an iso update to ovirt-node host got removed when reworking ovirt host deploy sequence. shouldAlertUpgrade() is still available in HostGeneralModel.java Change-Id: I1b58f3c5f2ce1a7e9f5c151c07c6c32a2cbb8fe1 Bug-Url: https://bugzilla.redhat.com/1117393 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 2 files changed, 56 insertions(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b58f3c5f2ce1a7e9f5c151c07c6c32a2cbb8fe1 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi: Fix update VM optional parameters
by oourfali＠redhat.com 24 Jul '14

24 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: restapi: Fix update VM optional parameters ...................................................................... restapi: Fix update VM optional parameters The metadata for the operation to update a VM doesn't include the guaranteed memory option, thus it isn't available in the CLI. Change-Id: I5d32fb2db5bf4b9f2f3271820ce7b0caeac9e050 Bug-Url: https://bugzilla.redhat.com/1122945 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 6103405931427d643a1e018ed8aa5536235fd142) --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30683 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d32fb2db5bf4b9f2f3271820ce7b0caeac9e050 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[master]: build: ovirt-live-3.5.0-beta2
by sbonazzo＠redhat.com 24 Jul '14

24 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-3.5.0-beta2 ...................................................................... build: ovirt-live-3.5.0-beta2 Change-Id: Ibf525a46434382b316e8949f679041647efd950c Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile M centos/kickstart/ovirt-live-base.ks.in 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30665 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf525a46434382b316e8949f679041647efd950c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Wrong vnics when creating vm from blank template
by piotr.kliczewski＠gmail.com 24 Jul '14

24 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Wrong vnics when creating vm from blank template ...................................................................... webadmin: Wrong vnics when creating vm from blank template The 'Blank' template belongs to the 'Default' dc/cluster. If the 'Blank' template has vnics with profiles, when creating a vm in different cluster than 'Default' the vnic profiles (which don't exist in the vm's cluster) should be overridden by 'Empty' profile. This override happens in EditProfileBehavior->initSelectedProfile, but since it is called before the registration of ProfileInstanceTypeEditor to SelectedItemChangedEvent of VnicInstanceType the new selection of 'Empty' profile isn't reflected on VnicInstanceType.NetworkInterface. This patch fixes it by calling syncSelectedItemWithNetworkInterface(..) also before the registration and not just from the eventRaised(..). Change-Id: I60be6b21050c43bb004e56688f8e306b5b943d24 Bug-Url: https://bugzilla.redhat.com/1103058 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> (cherry picked from commit c57055367478087dbdb3602671f8331b747bd9df) --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.java 1 file changed, 10 insertions(+), 7 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60be6b21050c43bb004e56688f8e306b5b943d24 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: wrong log severity for interface up/down event logs
by piotr.kliczewski＠gmail.com 24 Jul '14

24 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: wrong log severity for interface up/down event logs ...................................................................... engine: wrong log severity for interface up/down event logs Interface down events' log severity should be warning. Interface up events' log severity should be normal. Change-Id: I9ff6b663a141f75241ff27f8df12922c42de04ff Bug-Url: https://bugzilla.redhat.com/1113160 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ff6b663a141f75241ff27f8df12922c42de04ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-live[ovirt-live-3.4]: build: post ovirt-live-3.4.3-1
by sbonazzo＠redhat.com 24 Jul '14

24 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-live-3.4.3-1 ...................................................................... build: post ovirt-live-3.4.3-1 Change-Id: I1320fcb66ad5abd562529e119059a321d185d371 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile M centos/kickstart/ovirt-live-base.ks.in 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1320fcb66ad5abd562529e119059a321d185d371 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.4]: build: ovirt-live-3.4.3-1
by sbonazzo＠redhat.com 24 Jul '14

24 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-3.4.3-1 ...................................................................... build: ovirt-live-3.4.3-1 Respin including vdsm-4.14.11-2 Change-Id: I005a2c607fcae09a7a2b6f2816b57278b04c8973 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile M centos/kickstart/ovirt-live-base.ks.in 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I005a2c607fcae09a7a2b6f2816b57278b04c8973 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0