- Engine-commits - oVirt List Archives

Change in ovirt-dwh[ovirt-engine-dwh-3.3]: packaging: added release notes.
by ydary＠redhat.com 22 Jul '14

22 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: added release notes. ...................................................................... packaging: added release notes. Change-Id: Id6617f444a0fd6377eae6c9448611d316d0f448b Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-engine-dwh.spec.in 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6617f444a0fd6377eae6c9448611d316d0f448b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.3 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.1]: Fix missing macro
by msivak＠redhat.com 22 Jul '14

22 Jul '14

Martin Sivák has submitted this change and it was merged. Change subject: Fix missing macro ...................................................................... Fix missing macro %systemd_requires fails on f19 when systemd is not installed. Change-Id: I5ab60bd58233b4776482f2a7aee609d6a823bffd Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Jiří Moskovčák: Looks good to me, but someone else must approve David Caro: Verified -- To view, visit http://gerrit.ovirt.org/30279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ab60bd58233b4776482f2a7aee609d6a823bffd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Save PM options even when PM disabled
by piotr.kliczewski＠gmail.com 22 Jul '14

22 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Save PM options even when PM disabled ...................................................................... webadmin: Save PM options even when PM disabled Fixes limitation where PM options were saved only when PM was enabled for host. Change-Id: Iccc3121e35c05123a110f98802bb548034aaa308 Bug-Url: https://bugzilla.redhat.com/1113478 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 21 insertions(+), 23 deletions(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30565 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iccc3121e35c05123a110f98802bb548034aaa308 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: jsonrpc: Edit host restores default protocol
by oourfali＠redhat.com 22 Jul '14

22 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: jsonrpc: Edit host restores default protocol ...................................................................... jsonrpc: Edit host restores default protocol After editing host default value of the protocol for the host is restored. Bug-Url: https://bugzilla.redhat.com/1121967 Change-Id: I64f483f10b85af4891fa40c63584dbb5befc6a8e Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64f483f10b85af4891fa40c63584dbb5befc6a8e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Save PM options even when PM disabled
by oourfali＠redhat.com 22 Jul '14

22 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Save PM options even when PM disabled ...................................................................... webadmin: Save PM options even when PM disabled Fixes limitation where PM options were saved only when PM was enabled for host. Change-Id: Iccc3121e35c05123a110f98802bb548034aaa308 Bug-Url: https://bugzilla.redhat.com/1113478 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 21 insertions(+), 23 deletions(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29593 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iccc3121e35c05123a110f98802bb548034aaa308 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: RemoveImageCommand - missing constructor
by piotr.kliczewski＠gmail.com 22 Jul '14

22 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: RemoveImageCommand - missing constructor ...................................................................... core: RemoveImageCommand - missing constructor RemoveImageCommand - added a ctr that accepts parameters class. In bug context, needed for invocation on RemoveDiskCommand by 'runInternalActionWithTasksContext'. Change-Id: Ib55837af6ab49ebfd5202c4dc272a73e467f3f14 Bug-Url: https://bugzilla.redhat.com/1121379 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30546 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib55837af6ab49ebfd5202c4dc272a73e467f3f14 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: update sound device on next run VM snapshot
by piotr.kliczewski＠gmail.com 22 Jul '14

22 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: update sound device on next run VM snapshot ...................................................................... core: update sound device on next run VM snapshot * Added an 'EditableDeviceOnVmStatusField' annotation for 'soundDeviceEnabled' (in VmManagementParametersBase). * Consequently, removed canDo validation in UpdateVmCommand. Change-Id: Icb794bcb6a054bbb0424c35f024c4a1a85ea5069 Bug-Url: https://bugzilla.redhat.com/1035289 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java 4 files changed, 2 insertions(+), 18 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Daniel Erez: Verified Omer Frenkel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30550 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb794bcb6a054bbb0424c35f024c4a1a85ea5069 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: update console device on next run VM snapshot
by piotr.kliczewski＠gmail.com 22 Jul '14

22 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: update console device on next run VM snapshot ...................................................................... core: update console device on next run VM snapshot * Added an 'EditableDeviceOnVmStatusField' annotation for 'consoleEnabled' (in VmManagementParametersBase). * Consequently, removed canDo validation in UpdateVmCommand. Change-Id: I22a508327a678039eee666ea5f31748ee8c8f7b1 Bug-Url: https://bugzilla.redhat.com/1035289 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java 4 files changed, 14 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Daniel Erez: Verified Omer Frenkel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22a508327a678039eee666ea5f31748ee8c8f7b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: update VirtIO-SCSI device on next run VM snapshot
by piotr.kliczewski＠gmail.com 22 Jul '14

22 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: update VirtIO-SCSI device on next run VM snapshot ...................................................................... core: update VirtIO-SCSI device on next run VM snapshot * Added an 'EditableDeviceOnVmStatusField' annotation for 'virtioScsiEnabled' (in VmManagementParametersBase). * Consequently, removed canDo validation in UpdateVmCommand. Change-Id: Ic1ee50f25e71d4540ebb6ab60250b9cfa5985ac4 Bug-Url: https://bugzilla.redhat.com/1035289 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/ExistingVmInstanceTypeManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java 5 files changed, 31 insertions(+), 29 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30044 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1ee50f25e71d4540ebb6ab60250b9cfa5985ac4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: make message ovf store specific
by laravot＠redhat.com 22 Jul '14

22 Jul '14

Liron Aravot has submitted this change and it was merged. Change subject: core: make message ovf store specific ...................................................................... core: make message ovf store specific Changed ACTION_TYPE_FAILED__DISK_NOT_IN_APPLICABLE_STATUS to be specific to OVF disks to make it clearer. Change-Id: Ie29c226f76839863008b25c69d4923c9685b17f7 Bug-Url: https://bugzilla.redhat.com/1114431 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 12 insertions(+), 10 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie29c226f76839863008b25c69d4923c9685b17f7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0