- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Reset properties when detaching network
by lvernia＠redhat.com 21 Jul '14

21 Jul '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Reset properties when detaching network ...................................................................... webadmin: Reset properties when detaching network Previously the underlying network interface entity's properties were not properly reset when a network was detached, regarding recently-added properties (QoS, custom properties). This is now fixed for custom properties. Change-Id: I37f3f1bc0cc3d5353c43d628fa3b24420728236c Bug-Url: https://bugzilla.redhat.com/1119019 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NetworkParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java 2 files changed, 23 insertions(+), 43 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/30496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37f3f1bc0cc3d5353c43d628fa3b24420728236c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: reports: fixed centos install with ovirt provided jboss
by ydary＠redhat.com 21 Jul '14

21 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: fixed centos install with ovirt provided jboss ...................................................................... reports: fixed centos install with ovirt provided jboss Change-Id: Ie049ed840c523a6e43524186ef39c1c32adfefcd Signed-off-by: Shirly Radco <sradco(a)redhat.com> Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine-reports.spec.in M packaging/setup/ovirt_engine_setup/reports/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/jboss.py 4 files changed, 90 insertions(+), 2 deletions(-) Approvals: Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30112 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie049ed840c523a6e43524186ef39c1c32adfefcd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: long query response time while many simultaneously que...
by oourfali＠redhat.com 21 Jul '14

21 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: long query response time while many simultaneously queries are running ...................................................................... core: long query response time while many simultaneously queries are running we found the postgres running this function 'getdiskbydiskid' so many times when the engine started which makes disaster on the sys with 100% CPU utilization Change-Id: I94e20d782bc4e2befaf4338f51551a2855509769 Bug-Url: https://bugzilla.redhat.com/1120088 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDynamicDAOTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M packaging/dbscripts/disk_image_dynamic_sp.sql 5 files changed, 67 insertions(+), 19 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Omer Frenkel: Looks good to me, but someone else must approve Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/29043 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94e20d782bc4e2befaf4338f51551a2855509769 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: UpdateVmDiskCommantTest whitespaces
by amureini＠redhat.com 21 Jul '14

21 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateVmDiskCommantTest whitespaces ...................................................................... core: UpdateVmDiskCommantTest whitespaces Removed redundant whitespaces. Change-Id: I8d724b9ea1c0d37b7117407fb1408087e51ed1c6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/30506 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d724b9ea1c0d37b7117407fb1408087e51ed1c6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Allow custom properties on NIC without network
by piotr.kliczewski＠gmail.com 21 Jul '14

21 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: Allow custom properties on NIC without network ...................................................................... engine: Allow custom properties on NIC without network Previously a validation failed the Setup Networks command when a NIC had no network but had custom properties configured, which blocked removal of networks with custom properties. Now canDoAction() doesn't block this, but the custom properties are ignored (similarly to boot protocol) in case no network is configured on the NIC. Similar changes have been made to the QoS settings, which would cause the same problems. Change-Id: Ibded6b7b7ffe9be960d522bd63cbf9db08b18d6e Bug-Url: https://bugzilla.redhat.com/1119019 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 42 insertions(+), 31 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibded6b7b7ffe9be960d522bd63cbf9db08b18d6e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fix exception related to display network warning
by piotr.kliczewski＠gmail.com 21 Jul '14

21 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Fix exception related to display network warning ...................................................................... webadmin: Fix exception related to display network warning ClassCastException, probably due to misunderstanding of the network operations. Change-Id: Iac63576d8e15bdae47ec0e08ae2b64395adc4765 Bug-Url: https://bugzilla.redhat.com/1078836 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/29996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac63576d8e15bdae47ec0e08ae2b64395adc4765 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: External network with vlan must be labeled
by piotr.kliczewski＠gmail.com 21 Jul '14

21 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: External network with vlan must be labeled ...................................................................... engine: External network with vlan must be labeled An external network which its vlan-id is set, must include a label when it is being added to the external provider. Since the engine might not be aware of changes made to the provider, the label values cannot be enforced. (cherry picked from commit f71b849cd89e819a636a78bae58081c8fa343020) Change-Id: I811a0d55798b7dd78d37880055c4ac00303b679f Bug-Url: https://bugzilla.redhat.com/1059249 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/dc/AddNetworkValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 34 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/30491 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I811a0d55798b7dd78d37880055c4ac00303b679f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Edit disk description when VM is up
by piotr.kliczewski＠gmail.com 21 Jul '14

21 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: Edit disk description when VM is up ...................................................................... engine: Edit disk description when VM is up Since the description is just a database field, there's no (good) reason to prevent editing disks' descriptions while the related VM(s) is(are) up. This patch includes: - Fixing the UpdateVmDiskCommand to allow such updates - Adding cases to UpdateVmDiskCommandTest to check this functionality - Fixing EditDiskModel to allow this update in the UI Change-Id: Id116aec43abb8863faf17a240530dac0a78f22e0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java 3 files changed, 30 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/30501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id116aec43abb8863faf17a240530dac0a78f22e0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Validate network provider properties
by piotr.kliczewski＠gmail.com 21 Jul '14

21 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: Validate network provider properties ...................................................................... engine: Validate network provider properties Validates that host which is installed with network provider supplies all of the required properties or the provider has them defined. Change-Id: Idcdcddb9694426c1e656c9fa1e04dc7f37e8115c Bug-Url: https://bugzilla.redhat.com/1061728 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/NetworkProviderValidator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/provider/NetworkProviderValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/provider/ProviderValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 10 files changed, 177 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29997 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idcdcddb9694426c1e656c9fa1e04dc7f37e8115c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Mention host's name in Setup Networks title
by piotr.kliczewski＠gmail.com 21 Jul '14

21 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Mention host's name in Setup Networks title ...................................................................... webadmin: Mention host's name in Setup Networks title Added the host name to the dialog's title, so that users will easily be aware of which host's networks they're configuring. Change-Id: Id3eaa163564846f2c24e1e86e49b7ec3879dcf85 Bug-Url: https://bugzilla.redhat.com/1114882 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 5 files changed, 10 insertions(+), 14 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/29995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3eaa163564846f2c24e1e86e49b7ec3879dcf85 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0