- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Changed event message text on hotplug of CPUs
by ofrenkel＠redhat.com 21 Jul '14

21 Jul '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: Changed event message text on hotplug of CPUs ...................................................................... core: Changed event message text on hotplug of CPUs Changed event message text displayed at audit log during hotplug of CPUs. Changed string and added the number of CPUs before change as well. Change-Id: Iafb7134533975fe3f1d246e9106939c340868ecd Bug-Url: https://bugzilla.redhat.com/1080364 Signed-off-by: Eldan Shachar <eshachar(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotSetNumberOfCpusCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: Eldan Shachar: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30235 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafb7134533975fe3f1d246e9106939c340868ecd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin : sort status and cluster column under volumes
by piotr.kliczewski＠gmail.com 21 Jul '14

21 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin : sort status and cluster column under volumes ...................................................................... webadmin : sort status and cluster column under volumes sort status and cluster column under volumes Change-Id: I73036f5a5d8e14df2bebdaeb2b3fa95938db2e8a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1119873 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/utils/GlusterVolumeUtils.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeBrickView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostBrickView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/BrickStatusColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeStatusCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeStatusColumn.java 8 files changed, 128 insertions(+), 68 deletions(-) Approvals: Alexander Wels: Looks good to me, approved anmolbabu: Verified -- To view, visit http://gerrit.ovirt.org/30270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73036f5a5d8e14df2bebdaeb2b3fa95938db2e8a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: ui: remove last delimiter in CustomProperties
by piotr.kliczewski＠gmail.com 21 Jul '14

21 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: ui: remove last delimiter in CustomProperties ...................................................................... ui: remove last delimiter in CustomProperties Change-Id: I3909f97cf2e02845c41a25bf5ca6f8327a6da3cd Bug-Url: https://bugzilla.redhat.com/1113503 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified -- To view, visit http://gerrit.ovirt.org/30009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3909f97cf2e02845c41a25bf5ca6f8327a6da3cd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: ui: edit VM override user qxl flag
by piotr.kliczewski＠gmail.com 21 Jul '14

21 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: ui: edit VM override user qxl flag ...................................................................... ui: edit VM override user qxl flag Bug-Url: https://bugzilla.redhat.com/1111565 Change-Id: I1cbb3128b8251311d3fa1c2b25ed5e90642e0e24 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/ExistingPoolInstanceTypeManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/ExistingVmInstanceTypeManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/NewPoolInstanceTypeManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/NewVmInstanceTypeManager.java 13 files changed, 126 insertions(+), 36 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified -- To view, visit http://gerrit.ovirt.org/30021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cbb3128b8251311d3fa1c2b25ed5e90642e0e24 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin : Introduce volume profile pdf Export option
by piotr.kliczewski＠gmail.com 21 Jul '14

21 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin : Introduce volume profile pdf Export option ...................................................................... webadmin : Introduce volume profile pdf Export option Introduce volume profile pdf Export option. Change-Id: I9791208b327dbe3e3b4dacfb568f08e042e8b8c9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1121055 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeProfileStatisticsModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeProfileStatisticsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeProfileStatisticsPopupView.ui.xml 4 files changed, 53 insertions(+), 7 deletions(-) Approvals: Alexander Wels: Looks good to me, approved anmolbabu: Verified -- To view, visit http://gerrit.ovirt.org/30265 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9791208b327dbe3e3b4dacfb568f08e042e8b8c9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Reset properties when detaching network
by piotr.kliczewski＠gmail.com 21 Jul '14

21 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Reset properties when detaching network ...................................................................... webadmin: Reset properties when detaching network Previously the underlying network interface entity's properties were not properly reset when a network was detached, regarding recently-added properties (QoS, custom properties). This is now fixed for custom properties. Change-Id: I37f3f1bc0cc3d5353c43d628fa3b24420728236c Bug-Url: https://bugzilla.redhat.com/1119019 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NetworkParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java 2 files changed, 23 insertions(+), 43 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/30500 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37f3f1bc0cc3d5353c43d628fa3b24420728236c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: jobs: ovirt-iso-uploader
by dcaroest＠redhat.com 21 Jul '14

21 Jul '14

David Caro has submitted this change and it was merged. Change subject: jobs: ovirt-iso-uploader ...................................................................... jobs: ovirt-iso-uploader Add jobs for ovirt-iso-uploader Change-Id: I16519ba7e0f50ecafe6d04eb96f6df95d15f5e35 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A jobs/confs/yaml/jobs/ovirt-iso-uploader/ovirt-iso-uploader_create-rpms.yaml A jobs/confs/yaml/scms/ovirt-iso-uploader.yaml 2 files changed, 48 insertions(+), 0 deletions(-) Approvals: David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30512 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16519ba7e0f50ecafe6d04eb96f6df95d15f5e35 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: jobs: ovirt-image-uploader
by dcaroest＠redhat.com 21 Jul '14

21 Jul '14

David Caro has submitted this change and it was merged. Change subject: jobs: ovirt-image-uploader ...................................................................... jobs: ovirt-image-uploader Add ovirt-image-uploader jobs Change-Id: Idd1c4f204d6b9bc4982f8d6109184f134412b711 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A jobs/confs/yaml/jobs/ovirt-image-uploader/ovirt-image-uploader_create-rpms.yaml A jobs/confs/yaml/scms/ovirt-image-uploader.yaml 2 files changed, 48 insertions(+), 0 deletions(-) Approvals: David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30514 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd1c4f204d6b9bc4982f8d6109184f134412b711 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Create new VM | Not all selected nics are created ...
by alkaplan＠redhat.com 21 Jul '14

21 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Create new VM | Not all selected nics are created on the VM ...................................................................... webadmin: Create new VM | Not all selected nics are created on the VM Opening and closing ghost profile instance type editor without selecting a value causes the first acceptable value to be displayed at the header text box (just to be displayed, not really be selected-> the real value is still null). It is caused because ListModelTypeAheadListBox->adjustSelectedValue() calls in the described case- 'setValue(acceptableValues.iterator().next())' without firing valueChange event. The displayed value is changed, but the model.selectedValue is still null. Calling setValue with 'true' for 'fireValueChangeEvent' fixes the issue. But, as I understand, if the the selected value ('getValue()') was 'null' and wasn't changed manually to another value. There is no reason to override it here by the first item in the list. Change-Id: Iaa8ec33db813f334f07baadac38f27c5544f0791 Bug-Url: https://bugzilla.redhat.com/1115788 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java 1 file changed, 13 insertions(+), 14 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Alona Kaplan: Verified Lior Vernia: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30490 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa8ec33db813f334f07baadac38f27c5544f0791 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Clear QoS when detaching network
by lvernia＠redhat.com 21 Jul '14

21 Jul '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Clear QoS when detaching network ...................................................................... webadmin: Clear QoS when detaching network Similarly to the previous fix for custom properties, QoS settings on a host's network interface are also cleared when a network is detached. Change-Id: Ife17c3fae94fe936aab87a4012b7133c943faf2d Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NetworkParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java 2 files changed, 8 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/30498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife17c3fae94fe936aab87a4012b7133c943faf2d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0