- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine : Generate CommandContext on engine restart
by oourfali＠redhat.com 20 Jul '14

20 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine : Generate CommandContext on engine restart ...................................................................... engine : Generate CommandContext on engine restart After engine restart the command context map in memory is empty and we need to regenerate the CommandContexts for those commands that do not have a constructor with out CommandContext Change-Id: I641802c6e0e05abaa2ecd84d0718f0d95ab59d9e Bug-Url: https://bugzilla.redhat.com/1115127 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandContextsCacheImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CommandEntity.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDaoDbFacadeImpl.java M packaging/dbscripts/command_entities_sp.sql A packaging/dbscripts/upgrade/03_06_0020_add_job_step_ids_to_command_entities.sql 8 files changed, 102 insertions(+), 9 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29565 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I641802c6e0e05abaa2ecd84d0718f0d95ab59d9e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: fix ReconstructMasterDomainCommand constructor
by piotr.kliczewski＠gmail.com 19 Jul '14

19 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: fix ReconstructMasterDomainCommand constructor ...................................................................... core: fix ReconstructMasterDomainCommand constructor In change: 8255f44 aaa: more fixes to command context propgation a new constructor has been added modifying the existing one to call the base class (super). Instead to maintain the previous behavior the old constructor should have called the new one (in order to initialize the class). Change-Id: If8e54cccc9ebe7829a88c1ca296c1dfbf8542256 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> (cherry picked from commit 4c9d7fb74a1ff826c815a5c1499a974f72fc5b2d) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8e54cccc9ebe7829a88c1ca296c1dfbf8542256 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: Fixing search to search by authz
by piotr.kliczewski＠gmail.com 19 Jul '14

19 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: Fixing search to search by authz ...................................................................... aaa: Fixing search to search by authz In this patch, search is fixed to search by authz. In addition - at frontend, the drop down list for domains shows a combination of (profile,authz) (i.e - (profile,domain) Bug-Url: https://bugzilla.redhat.com/1117488 Change-Id: Ic1867577a900e2c7a815d443b771e2576bd8aea2 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAAAProfileListQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/ProfileEntry.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserPortalAdElementListModel.java 9 files changed, 107 insertions(+), 42 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Yair Zaslavsky: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30247 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1867577a900e2c7a815d443b771e2576bd8aea2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: reactivate user
by piotr.kliczewski＠gmail.com 19 Jul '14

19 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: reactivate user ...................................................................... aaa: reactivate user Reactive users in the following flow: 1. Login 2. AddUser 3. Periodic sync reactivate will occur with syncing the directory groups Bug-Url: https://bugzilla.redhat.com/1120609 Change-Id: I556d8da48a858ce193865e84fb6c7cb4043a8e5b Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SyncUsers.java 4 files changed, 39 insertions(+), 9 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30208 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I556d8da48a858ce193865e84fb6c7cb4043a8e5b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: fix available locale variable
by ecohen＠redhat.com 19 Jul '14

19 Jul '14

Einav Cohen has submitted this change and it was merged. Change subject: userportal,webadmin: fix available locale variable ...................................................................... userportal,webadmin: fix available locale variable - The available locale variable was not being set properly in maven, causing the build to fail when selecting all locales. This patch fixes that issues as well as use the variable in webadmin/userportal gwt xml. - Removed hard coded version for maven plugin, now it is being managed by a parent pom. Change-Id: Icc90fdcd05dd460cce4b2084a8e5793b77b5b09b Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/UserPortal.gwt.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/WebAdmin.gwt.xml 5 files changed, 39 insertions(+), 17 deletions(-) Approvals: Alexander Wels: Verified Einav Cohen: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc90fdcd05dd460cce4b2084a8e5793b77b5b09b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix ReconstructMasterDomainCommand constructor
by amureini＠redhat.com 18 Jul '14

18 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: fix ReconstructMasterDomainCommand constructor ...................................................................... core: fix ReconstructMasterDomainCommand constructor In change: 8255f44 aaa: more fixes to command context propgation a new constructor has been added modifying the existing one to call the base class (super). Instead to maintain the previous behavior the old constructor should have called the new one (in order to initialize the class). Change-Id: If8e54cccc9ebe7829a88c1ca296c1dfbf8542256 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Federico Simoncelli: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8e54cccc9ebe7829a88c1ca296c1dfbf8542256 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: sync VM config after Live Merge
by amureini＠redhat.com 18 Jul '14

18 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: sync VM config after Live Merge ...................................................................... core: sync VM config after Live Merge After a backwards merge, the child of a deleted snapshot will now have a different image associated with it. This needs to be reflected in the VM configuration for the snapshot, else the disks will be marked illegal in the UI and won't function properly when the snapshot is previewed/reverted. Change-Id: Ic37dc1e54b99893bca68088eee80c26e1fbf9f91 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java 2 files changed, 44 insertions(+), 4 deletions(-) Approvals: Greg Padgett: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic37dc1e54b99893bca68088eee80c26e1fbf9f91 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: set active image after Live Merge of active layer
by amureini＠redhat.com 18 Jul '14

18 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: set active image after Live Merge of active layer ...................................................................... core: set active image after Live Merge of active layer Live Merging the active layer should mark the new active image. Change-Id: Ifc2777257b85c52011aa3bd7c9ad56c2ea680b63 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Greg Padgett: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc2777257b85c52011aa3bd7c9ad56c2ea680b63 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: allow successful retries of Live Merge
by amureini＠redhat.com 18 Jul '14

18 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: allow successful retries of Live Merge ...................................................................... core: allow successful retries of Live Merge Change RemoveSnapshotSingleDiskLiveCommand and related commands to allow for successful retries after deletion or merge fails. Upon merge failure, images are marked illegal but remain in the volume chain. Retries will start over and attempt to merge the images again. Upon deletion failure (but after a successful merge), the volume chain is updated to reflect the new chain; however, the orphaned images are re-associated with the snapshot to be deleted, marked illegal, and set to have no parents or children. Upon retry, the command will detect this state and skip to the DESTROY_IMAGE execution step. Change-Id: Ib794822c6b03cb05e00dc7e99113127aaed43ce9 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java 3 files changed, 161 insertions(+), 26 deletions(-) Approvals: Greg Padgett: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib794822c6b03cb05e00dc7e99113127aaed43ce9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix race when removing memory volumes during Live Merge
by amureini＠redhat.com 18 Jul '14

18 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: fix race when removing memory volumes during Live Merge ...................................................................... core: fix race when removing memory volumes during Live Merge Memory volume removal was not tracked as a child command, and its completion would trigger endAction of RemoveSnapshotCommand before the tasks run by ExecutionHandler were complete. Instead, use the newer RemoveMemoryVolumesCommand during Live Merge, which Executionhandler can coordinate. Change-Id: I12e317ada7159101cc5349e9a084b7f316493048 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMemoryVolumesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java 2 files changed, 17 insertions(+), 5 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Greg Padgett: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29804 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12e317ada7159101cc5349e9a084b7f316493048 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0