- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: wrong log severity for interface up/down event logs
by alkaplan＠redhat.com 21 Jul '14

21 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: wrong log severity for interface up/down event logs ...................................................................... engine: wrong log severity for interface up/down event logs Interface down events' log severity should be warning. Interface up events' log severity should be normal. Change-Id: I9ff6b663a141f75241ff27f8df12922c42de04ff Bug-Url: https://bugzilla.redhat.com/1113160 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30493 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ff6b663a141f75241ff27f8df12922c42de04ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: Fixing missing name field for admin user
by oourfali＠redhat.com 21 Jul '14

21 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: Fixing missing name field for admin user ...................................................................... aaa: Fixing missing name field for admin user Topic: AAA Change-Id: Ie4ae5e103ecc9f85fbeaef6c9bc3351e9d4beb21 Bug-Url: https://bugzilla.redhat.com/1101147 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthz.java A packaging/dbscripts/upgrade/03_05_0770_set_name_for_internal_user.sql 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4ae5e103ecc9f85fbeaef6c9bc3351e9d4beb21 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: Fixing missing name field for admin user
by yzaslavs＠redhat.com 21 Jul '14

21 Jul '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Fixing missing name field for admin user ...................................................................... aaa: Fixing missing name field for admin user Topic: AAA Change-Id: Ie4ae5e103ecc9f85fbeaef6c9bc3351e9d4beb21 Bug-url: https://bugzilla.redhat.com/1101147 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthz.java A packaging/dbscripts/upgrade/03_06_0030_set_name_for_internal_user.sql 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4ae5e103ecc9f85fbeaef6c9bc3351e9d4beb21 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix update VmDevices when VM is down
by derez＠redhat.com 20 Jul '14

20 Jul '14

Daniel Erez has submitted this change and it was merged. Change subject: core: fix update VmDevices when VM is down ...................................................................... core: fix update VmDevices when VM is down Updating VmDevices when the VM isn't running, mistakenly leads to next run snapshot creation. Therefore, modified 'VmHandler -> isUpdateValidForVmDevices': the function should check whether updating is valid according to the status of the VM; hence, VmStatus should be specified (so it could be validated properly on 'getVmDevicesFieldsToUpdateOnNextRun -> isUpdateValidForVmDevice'). Change-Id: Ia7a8f2a4c3f41b18a7c02ca162b01ee352e49bcf Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmUpdatesOnNextRunExistsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 4 files changed, 8 insertions(+), 7 deletions(-) Approvals: Daniel Erez: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30499 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7a8f2a4c3f41b18a7c02ca162b01ee352e49bcf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Edit disk description when VM is up
by amureini＠redhat.com 20 Jul '14

20 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Edit disk description when VM is up ...................................................................... engine: Edit disk description when VM is up Since the description is just a database field, there's no (good) reason to prevent editing disks' descriptions while the related VM(s) is(are) up. This patch includes: - Fixing the UpdateVmDiskCommand to allow such updates - Adding cases to UpdateVmDiskCommandTest to check this functionality - Fixing EditDiskModel to allow this update in the UI Change-Id: Id116aec43abb8863faf17a240530dac0a78f22e0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java 3 files changed, 30 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id116aec43abb8863faf17a240530dac0a78f22e0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Make *RngCommands internal
by ofrenkel＠redhat.com 20 Jul '14

20 Jul '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: Make *RngCommands internal ...................................................................... core: Make *RngCommands internal Change-Id: I09b801b77309a5fad5bf142f53004fef6d5cac68 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRngDeviceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveRngDeviceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateRngDeviceCommand.java 3 files changed, 3 insertions(+), 0 deletions(-) Approvals: Frank Kobzik: Verified Omer Frenkel: Looks good to me, approved Yair Zaslavsky: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09b801b77309a5fad5bf142f53004fef6d5cac68 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.4]: build: post ovirt-engine-dwh-3.4.3
by ydary＠redhat.com 20 Jul '14

20 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: post ovirt-engine-dwh-3.4.3 ...................................................................... build: post ovirt-engine-dwh-3.4.3 Change-Id: I70dd716c4714eb78d8dfdc28f8207b48867809e8 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70dd716c4714eb78d8dfdc28f8207b48867809e8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.4 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[ovirt-engine-reports-3.4]: build: post ovirt-engine-reports-3.4.3
by ydary＠redhat.com 20 Jul '14

20 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: post ovirt-engine-reports-3.4.3 ...................................................................... build: post ovirt-engine-reports-3.4.3 Change-Id: Ia9ad5daf394e980faf126618613c880ea1ea34ea Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9ad5daf394e980faf126618613c880ea1ea34ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.4 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[ovirt-engine-reports-3.4]: build: ovirt-engine-reports-3.4.3
by ydary＠redhat.com 20 Jul '14

20 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: ovirt-engine-reports-3.4.3 ...................................................................... build: ovirt-engine-reports-3.4.3 Change-Id: Id2fa97cfe1218be2d52f3856899b76404772b3fa Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2fa97cfe1218be2d52f3856899b76404772b3fa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.4 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.4]: build: ovirt-engine-dwh-3.4.3
by ydary＠redhat.com 20 Jul '14

20 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: ovirt-engine-dwh-3.4.3 ...................................................................... build: ovirt-engine-dwh-3.4.3 Change-Id: Iba6dcaeb01843367a022447b5175275b15da13a3 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30483 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba6dcaeb01843367a022447b5175275b15da13a3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.4 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0