- Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: build: post ovirt-hosted-engine-setup-1.2 branch
by sbonazzo＠redhat.com 14 Jul '14

14 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-setup-1.2 branch ...................................................................... build: post ovirt-hosted-engine-setup-1.2 branch Change-Id: I9dd34f07f3deeb3e048cac84a76839065a56c26d Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 11 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jiří Moskovčák: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9dd34f07f3deeb3e048cac84a76839065a56c26d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: build: post ovirt-hosted-engine-setup-1.2 branch
by sbonazzo＠redhat.com 14 Jul '14

14 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-setup-1.2 branch ...................................................................... build: post ovirt-hosted-engine-setup-1.2 branch Change-Id: Ie1af1ac79f42218670aa849ea41fff77ed7b4152 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 11 insertions(+), 11 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1af1ac79f42218670aa849ea41fff77ed7b4152 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: renamed test to accommodate command
by derez＠redhat.com 14 Jul '14

14 Jul '14

Daniel Erez has submitted this change and it was merged. Change subject: core: renamed test to accommodate command ...................................................................... core: renamed test to accommodate command Renamed test to SyncLunsInfoForBlockStorageDomainCommandTest (to reflect command's name). Change-Id: Ie94262104c972987817957e23a4b81bfb659e8ae Signed-off-by: Daniel Erez <derez(a)redhat.com> --- R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/SyncLunsInfoForBlockStorageDomainCommandTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29734 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie94262104c972987817957e23a4b81bfb659e8ae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: disks sub-tab - fix columns creation
by derez＠redhat.com 14 Jul '14

14 Jul '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: disks sub-tab - fix columns creation ...................................................................... webadmin: disks sub-tab - fix columns creation Following sorting support, disks columns instantiation should be ensured to happen once. Otherwise, the columns get duplicated on type navigation (radio-buttons of all/images/directlun). Hence, applied the same solution introduced in [1] on MainTabDiskView to disks sub-tab as well. [1] http://gerrit.ovirt.org/29375/ Change-Id: Idc774e26c9a3d954e9d7b8a4fee9206358269926 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java 1 file changed, 45 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/30003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc774e26c9a3d954e9d7b8a4fee9206358269926 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: sort domain names a-b ascending.
by oourfali＠redhat.com 14 Jul '14

14 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: sort domain names a-b ascending. ...................................................................... aaa: sort domain names a-b ascending. Change-Id: Ia3d0a64c872f8d2a018be08587303b5358c3a18c Topic: AAA Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1115549 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAAAProfileListQuery.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve mooli tayer: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3d0a64c872f8d2a018be08587303b5358c3a18c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: remove AdminDomain definition.
by oourfali＠redhat.com 14 Jul '14

14 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: remove AdminDomain definition. ...................................................................... aaa: remove AdminDomain definition. This option became redundant with introduction of auth profiles. It was never exposed (Engine Config). Change-Id: I375df1489ed59d98a7be0e3d629b662a0d764d10 Topic: AAA Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/resources/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/defaults.properties M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 3 files changed, 1 insertion(+), 5 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve mooli tayer: Verified Yair Zaslavsky: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I375df1489ed59d98a7be0e3d629b662a0d764d10 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: remove exceptional AdminDomain logic from domain sorting.
by oourfali＠redhat.com 14 Jul '14

14 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: remove exceptional AdminDomain logic from domain sorting. ...................................................................... aaa: remove exceptional AdminDomain logic from domain sorting. Change-Id: I48ff93e74960c082bdd2dce1b15193272946d503 Topic: AAA Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDomainListQuery.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginDomainComparator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetDomainListQueryTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/LoginDomainComparatorTest.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetDomainListParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUsersResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUsersResourceTest.java 9 files changed, 13 insertions(+), 191 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, but someone else must approve mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48ff93e74960c082bdd2dce1b15193272946d503 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Make GetVmsInit query accessible to users
by tnisan＠redhat.com 14 Jul '14

14 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Make GetVmsInit query accessible to users ...................................................................... core: Make GetVmsInit query accessible to users This is required for regular users to access VMs via the RESTAPI. Change-Id: If2278f0b8116ba873b8dc27f4d11d80f346cb216 Bug-Url: https://bugzilla.redhat.com/1102801 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 926adef69e45d5745fcb936239f67d2cfacd18ad) --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/30011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2278f0b8116ba873b8dc27f4d11d80f346cb216 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: tools: engine-config.properties: remove left over line.
by tnisan＠redhat.com 14 Jul '14

14 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: tools: engine-config.properties: remove left over line. ...................................................................... tools: engine-config.properties: remove left over line. commit 116fef64 added meaningful description to the WebSocketProxy different options. However it seems as though the old description (value) was listed as a new unknown key. This causes the following line to be outputed as a value: null: (Value Type: String) Change-Id: I4a991e5aeabdf2195624a2899e6f2bf62e49296a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1116392 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M packaging/etc/engine-config/engine-config.properties 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a991e5aeabdf2195624a2899e6f2bf62e49296a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: SetupNetwork>edit network(with pencil)>can't edit ...
by tnisan＠redhat.com 14 Jul '14

14 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: SetupNetwork>edit network(with pencil)>can't edit network ...................................................................... webadmin: SetupNetwork>edit network(with pencil)>can't edit network EnumRadioEditor used the global eventBus to fire ValueChangeEvent. Since UiCommonEditorVisitor subscribes all the editors of type HasValueChangeHandlers to this event- all the instances of EnumRadioEditor were subscribed to the same eventBus. Therefore, each instance pf EnumRadioEditor got the value change events of the other instances- which caused wrong behaviour and in some cases ClassCasException. To fix the issue a separate handlerManger is used for each instance of EnumRadioEditor. Note: addValueChangeHandler(..) cannot register to the valueChangeHanlder of the peer since the peer's 'value' is all the list of enum-items and not just the selected item as desired. Change-Id: I83c330b8340ba1cf6b2382877b23d07c25fc1afb Bug-Url: https://bugzilla.redhat.com/1108014 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EnumRadioEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java 4 files changed, 9 insertions(+), 9 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29990 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83c330b8340ba1cf6b2382877b23d07c25fc1afb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0