- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Added AutoCloseableLock
by mkolesni＠redhat.com 13 Jul '14

13 Jul '14

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Added AutoCloseableLock ...................................................................... engine: Added AutoCloseableLock This wrapper class will allow writing cleaner code, instead of: lock.lock(); try { // Thread safe code } finally { lock.unlock(); } We can write: try (AutoCloseableLock l = new AutoCloseableLock(lock)) { // Thread safe code } A follow-up patch will refactor code to use this new syntax and serve as an example. Change-Id: I3864d0e630c04f13e47e9f324414b308bd24290e Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/lock/AutoCloseableLock.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/lock/AutoCloseableLockTest.java 2 files changed, 88 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified Omer Frenkel: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3864d0e630c04f13e47e9f324414b308bd24290e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix coverity unguarded read error in IsoDomainListSync...
by tnisan＠redhat.com 13 Jul '14

13 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix coverity unguarded read error in IsoDomainListSyncronizer ...................................................................... core: Fix coverity unguarded read error in IsoDomainListSyncronizer Change-Id: I156624f62b950159d33339a4714b016cf3d58cee Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30000 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I156624f62b950159d33339a4714b016cf3d58cee Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: fix flatGroups recursive
by tnisan＠redhat.com 13 Jul '14

13 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: aaa: fix flatGroups recursive ...................................................................... aaa: fix flatGroups recursive incorrect get of groups of group record from principal record. also clean up the implementation to simplify. Topic: AAA Change-Id: Ief72097b8248ffb0c8d51d170a463453170b51c4 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/DirectoryUtils.java 1 file changed, 11 insertions(+), 13 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief72097b8248ffb0c8d51d170a463453170b51c4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: aaa: fix group list comma construction
by tnisan＠redhat.com 13 Jul '14

13 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: aaa: fix group list comma construction ...................................................................... webadmin: aaa: fix group list comma construction actually, the counter should have been incremented. but there is no reason to use extra variable. Topic: AAA Change-Id: Ic8b5bd60cfdcea2f5593364ed4c9a36ff4f3550d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Tal Nisan: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29972 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8b5bd60cfdcea2f5593364ed4c9a36ff4f3550d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: send virtio-serial device to VDSM
by ofrenkel＠redhat.com 13 Jul '14

13 Jul '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: send virtio-serial device to VDSM ...................................................................... core: send virtio-serial device to VDSM Add virtio-serial to the list of devices the engine sends to VDSM Change-Id: Ie99dafc1495f42ffcd76592dcd9130f12c6d61bd Bug-Url: https://bugzilla.redhat.com/1028387 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDeviceGeneralType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmOldInfoBuilder.java 8 files changed, 31 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/29839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie99dafc1495f42ffcd76592dcd9130f12c6d61bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: change return value of copyImageVDSCommand for better ...
by ofrenkel＠redhat.com 13 Jul '14

13 Jul '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: change return value of copyImageVDSCommand for better logging ...................................................................... core: change return value of copyImageVDSCommand for better logging currently the return value of copyImageVDSCommand is not initialized, and is defaulted with emtpy guid. this empty guid appears in the engine.log as the result of the command, which is useless and confusing. Changed the return value to have the vdsm task id, which is a better guid to log there. note that the returnVaule of this command is not in use at all, only the createInfo, so this affect only the log. Change-Id: I80d830dcdcdfa38a76b08e5399b2f916349b9b8e Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CopyImageVDSCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Omer Frenkel: Verified Maor Lipchuk: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80d830dcdcdfa38a76b08e5399b2f916349b9b8e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: UpdateStorageDomainCommand's DAOs
by amureini＠redhat.com 13 Jul '14

13 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateStorageDomainCommand's DAOs ...................................................................... core: UpdateStorageDomainCommand's DAOs Replaced calls to DbFacade.getInstance().getStorageDomainStaticDao() with getStorageDomainStaticDAO(), as per the backend's convention. This change is done in order to facilitate writing unit tests for this class. Change-Id: I716a662d13512331b4e68ca31a13b6fb559227cd Signed-off-by: Allon Mureinik <amureini(a)redhat.com> Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/29805 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I716a662d13512331b4e68ca31a13b6fb559227cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: UpdateStorageDomain's CDA early return
by amureini＠redhat.com 13 Jul '14

13 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateStorageDomain's CDA early return ...................................................................... core: UpdateStorageDomain's CDA early return Changed UpdateStorageDomainCommand.canDoAction() to use the early return pattern in order to solve several NullPointerExceptions and enhance readability. Tests were added to all the canDoAction() flows to make sure these changes did not break any functionality. Change-Id: Iea10984090a759ef07da1fe572c4fdc323ede0e5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommandTest.java 2 files changed, 97 insertions(+), 18 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/29809 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea10984090a759ef07da1fe572c4fdc323ede0e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: update SD's setActionMessageParameters
by amureini＠redhat.com 13 Jul '14

13 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: update SD's setActionMessageParameters ...................................................................... core: update SD's setActionMessageParameters Moved the inclusion of VAR__ACTION__UPDATE in UpdateStorageDomainCommand from canDoAction() to it's rightful place, setActionMessageParameters(). This patch also includes a basic test case that verifies the above change was done correctly. Change-Id: I98d9959cb79e3786e5fb51d50e1e1961e85bf629 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommandTest.java 2 files changed, 97 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/29808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98d9959cb79e3786e5fb51d50e1e1961e85bf629 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Check messages when CDA succeeds
by amureini＠redhat.com 13 Jul '14

13 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Check messages when CDA succeeds ...................................................................... core: Check messages when CDA succeeds Improved CanDoActionTestUtils.runAndAssertCanDoActionSuccess to check not only that canDoAction() returned true, but also that it did not add any messages to the return value. Change-Id: I72d4ee52679db995aba9155c71954c13be613fa4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CanDoActionTestUtils.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29807 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72d4ee52679db995aba9155c71954c13be613fa4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0