- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: fix Live Merge logging
by tnisan＠redhat.com 14 Jul '14

14 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: fix Live Merge logging ...................................................................... core: fix Live Merge logging Minor fixes to log messages appearing during Live Merge. Change-Id: I18bcd3b135b45a443e23afdc4872234cc7c994c3 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DestroyImageParameters.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Greg Padgett: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29971 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18bcd3b135b45a443e23afdc4872234cc7c994c3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: fix coverity issue
by tnisan＠redhat.com 14 Jul '14

14 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: fix coverity issue ...................................................................... core: fix coverity issue Fix CID 1223222: Se: Incorrect definition of Serializable class (FB.SE_BAD_FIELD) The MergeStatusReturnValue member of RemoveSnapshotSingleDiskParameters did not implement Serializable. Change-Id: I7363ae80b3f6c6bdcf1f5dbb615d6021cce23872 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MergeStatusReturnValue.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Greg Padgett: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7363ae80b3f6c6bdcf1f5dbb615d6021cce23872 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Fix optional parameters of add template
by tnisan＠redhat.com 14 Jul '14

14 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Fix optional parameters of add template ...................................................................... restapi: Fix optional parameters of add template The operation to add a template accepts the cluster name and id as optional parameters, but they aren't documented in the metadata, thus they aren't available in the CLI. Change-Id: I612da88a8de940f635cf11efd7bafb0a5ea9f17f Bug-Url: https://bugzilla.redhat.com/1109548 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 2be1f639381be1b0843391b9e24fb947e64d4421) --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29965 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I612da88a8de940f635cf11efd7bafb0a5ea9f17f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Make GetVmsInit query accessible to users
by juan.hernandez＠redhat.com 14 Jul '14

14 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: core: Make GetVmsInit query accessible to users ...................................................................... core: Make GetVmsInit query accessible to users This is required for regular users to access VMs via the RESTAPI. Change-Id: If2278f0b8116ba873b8dc27f4d11d80f346cb216 Bug-Url: https://bugzilla.redhat.com/1102801 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/29941 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2278f0b8116ba873b8dc27f4d11d80f346cb216 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: build: post ovirt-hosted-engine-ha-1.2 branch
by msivak＠redhat.com 14 Jul '14

14 Jul '14

Martin Sivák has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-ha-1.2 branch ...................................................................... build: post ovirt-hosted-engine-ha-1.2 branch Change-Id: I1dd4c7edcf0be44b6af268ef207c2f8d4a526ef3 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 12 insertions(+), 57 deletions(-) Approvals: Sandro Bonazzola: Verified Martin Sivák: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29958 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1dd4c7edcf0be44b6af268ef207c2f8d4a526ef3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: build: post ovirt-hosted-engine-ha-1.2 branch
by msivak＠redhat.com 14 Jul '14

14 Jul '14

Martin Sivák has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-ha-1.2 branch ...................................................................... build: post ovirt-hosted-engine-ha-1.2 branch Change-Id: I0e992a3749652de1fe43dfb367e79a3c2c5d8b47 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 11 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Verified Martin Sivák: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jiří Moskovčák: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29959 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e992a3749652de1fe43dfb367e79a3c2c5d8b47 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Set boot order to more then one CDROM if selected
by oourfali＠redhat.com 14 Jul '14

14 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Set boot order to more then one CDROM if selected ...................................................................... engine: Set boot order to more then one CDROM if selected When dealing with more then one CDROM we set only the first in list if user select boot order from CDROM, which can cause a problem if the first CDROM is payload or cloud-init which are not bootable. When setting all CDROM to be bootable qemu will try to boot from one of them. Change-Id: I1f0b8b6a8346dd71b716df8d90f852de550bae97 Bug-Url: https://bugzilla.redhat.com/1064927 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java 1 file changed, 2 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29773 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f0b8b6a8346dd71b716df8d90f852de550bae97 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.1]: packaging: setup: adding an error message if no compatible C...
by sbonazzo＠redhat.com 14 Jul '14

14 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: adding an error message if no compatible CPUs are detected ...................................................................... packaging: setup: adding an error message if no compatible CPUs are detected With certain CPU models VMX support is not enought to support virtualization, NX needs to be enabled too. Adding an error message to explain it if no compatible CPUs are found. Change-Id: Idfa1daa84a0168983d729f5ebed45e62054db4f9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1119145 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit 148cb6c7d490d8684b86961d291aabdcd02591bb) --- M src/plugins/ovirt-hosted-engine-setup/vdsmd/cpu.py 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30008 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfa1daa84a0168983d729f5ebed45e62054db4f9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.1 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: conflict in engine-config.properties
by masayag＠redhat.com 14 Jul '14

14 Jul '14

Moti Asayag has submitted this change and it was merged. Change subject: tools: conflict in engine-config.properties ...................................................................... tools: conflict in engine-config.properties HostTimeDriftInSec.type was defined twice in engine-config.properties. Change-Id: I4a0c5bbb2928dc2d51438f385a4e3aa2cb424a23 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M packaging/etc/engine-config/engine-config.properties 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29347 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a0c5bbb2928dc2d51438f385a4e3aa2cb424a23 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Fix update VM optional parameters
by juan.hernandez＠redhat.com 14 Jul '14

14 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix update VM optional parameters ...................................................................... restapi: Fix update VM optional parameters The metadata for the operation to update a VM doesn't include the guaranteed memory option, thus it isn't available in the CLI. Change-Id: I5d32fb2db5bf4b9f2f3271820ce7b0caeac9e050 Bug-Url: https://bugzilla.redhat.com/1082594 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d32fb2db5bf4b9f2f3271820ce7b0caeac9e050 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0