- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: spec: updated deps
by sbonazzo＠redhat.com 11 Jul '14

11 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: updated deps ...................................................................... packaging: spec: updated deps Updated dependencies and removed legacy provides / requires Change-Id: If059609fd1ce0e93f770e20f2428764a2bdb05e3 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 10 insertions(+), 17 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve oVirt Jenkins CI Server: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29866 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If059609fd1ce0e93f770e20f2428764a2bdb05e3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Fix optional parameters of add template
by juan.hernandez＠redhat.com 11 Jul '14

11 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix optional parameters of add template ...................................................................... restapi: Fix optional parameters of add template The operation to add a template accepts the cluster name and id as optional parameters, but they aren't documented in the metadata, thus they aren't available in the CLI. Change-Id: I612da88a8de940f635cf11efd7bafb0a5ea9f17f Bug-Url: https://bugzilla.redhat.com/1109548 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I612da88a8de940f635cf11efd7bafb0a5ea9f17f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine : Save CommandContext in ContextCache
by piotr.kliczewski＠gmail.com 11 Jul '14

11 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine : Save CommandContext in ContextCache ...................................................................... engine : Save CommandContext in ContextCache Cache the command context in ContextCache which is backed by a map. Change-Id: I6b968f787b60f83cf96411a97dd6380421f724b9 Bug-Url: https://bugzilla.redhat.com/1115127 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandContextsCacheImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TaskManagerUtil.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCRUDOperations.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandContextsCache.java 13 files changed, 89 insertions(+), 21 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b968f787b60f83cf96411a97dd6380421f724b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: packaging: setup: raising an exception on SDK failure
by sbonazzo＠redhat.com 11 Jul '14

11 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: raising an exception on SDK failure ...................................................................... packaging: setup: raising an exception on SDK failure Raising an exception to interrupt the normal flow on SDK failures. Change-Id: I4d7cf8c1505ae4da5e719049bc11499c04b3c086 Bug-Url: https://bugzilla.redhat.com/1109929 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit 6ee1fe82fabef649e1b340fa6cb7f05f83841b78) --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d7cf8c1505ae4da5e719049bc11499c04b3c086 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: raising an exception on SDK failure
by sbonazzo＠redhat.com 11 Jul '14

11 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: raising an exception on SDK failure ...................................................................... packaging: setup: raising an exception on SDK failure Raising an exception to interrupt the normal flow on SDK failures. Change-Id: I4d7cf8c1505ae4da5e719049bc11499c04b3c086 Bug-Url: https://bugzilla.redhat.com/1109929 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/29898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d7cf8c1505ae4da5e719049bc11499c04b3c086 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: engine-backup: ignore uuid-ossp errors
by oourfali＠redhat.com 11 Jul '14

11 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: engine-backup: ignore uuid-ossp errors ...................................................................... packaging: engine-backup: ignore uuid-ossp errors Change-Id: I4234351cc55d982035e259eecddc2c9749427c96 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 2d3c5c6baf822f2869121e6337dd80f1b25e1c30) (cherry picked from commit 67f359d313b8a25c987b2f000b4578206be12b6b) --- M packaging/bin/engine-backup.sh 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/29926 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4234351cc55d982035e259eecddc2c9749427c96 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Reason does not get updated when trying to shutdow...
by awels＠redhat.com 11 Jul '14

11 Jul '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Reason does not get updated when trying to shutdown a VM which is Powering up of Shutting Down ...................................................................... webadmin: Reason does not get updated when trying to shutdown a VM which is Powering up of Shutting Down When trying to stop the VM while it is powering up or shutting down, the reason comment does not get saved in the DB On the second shut down, the reason text box should be initialized with the former reason text, and the user will be allowed to edit it as he will The reason column is populated with the reason only when a single vm is being shutdown Change-Id: I0b10ed39563385cf99a366a32eebcc0c5ce08e72 Bug-Url: https://bugzilla.redhat.com/1114903 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b10ed39563385cf99a366a32eebcc0c5ce08e72 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: correct path for snapshot links
by piotr.kliczewski＠gmail.com 11 Jul '14

11 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: correct path for snapshot links ...................................................................... core: correct path for snapshot links The links to the relevant snapshot objects should be under the snapshot object and not under the vm object to be consistent with the displayed path. Change-Id: I223b0cef14b887c1e1e3cff6f06b01fd3ac050c9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1077678 Signed-off-by: Liron Aravot <laravot(a)redhat.com> (cherry picked from commit 7842e5cf1dfa9ebf62057774b3cbf91c37b88b65) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotsResource.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29927 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I223b0cef14b887c1e1e3cff6f06b01fd3ac050c9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: adding an error message if no compatible C...
by sbonazzo＠redhat.com 11 Jul '14

11 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: adding an error message if no compatible CPUs are detected ...................................................................... packaging: setup: adding an error message if no compatible CPUs are detected With certain CPU models VMX support is not enought to support virtualization, NX needs to be enabled too. Adding an error message to explain it if no compatible CPUs are found. Change-Id: Idfa1daa84a0168983d729f5ebed45e62054db4f9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1103672 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/vdsmd/cpu.py 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/29739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfa1daa84a0168983d729f5ebed45e62054db4f9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: CSRF protection filter
by piotr.kliczewski＠gmail.com 11 Jul '14

11 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: CSRF protection filter ...................................................................... restapi: CSRF protection filter This patch introduces a filter that protects the RESTAPI from CSRF attacks. Protection is enabled/disabled globally, using the new CSRFProtection configuration parameter. By default this parameter is "false", so the protection isn't enabled. This can be changed with the "engine-config" tool, as follows: # engine-config -s CSRFProtection=true If the protection is enabled globally, then the caller can enable for a particular session using the "csrf-protection" preference: GET /ovirt-engine/api HTTP/1.1 Authorization: Basic P/c1qcSSGuTlxUCTEUCosZfZ Host: ovirt.example.com Prefer: persistent-auth, csrf-protection If this preference isn't specified then the session won't be protected, even if it is enabled globally. For protected sessions the caller must always include the "JSESSIONID" header, which should contain the value of the session identifier: GET /ovirt-engine/api HTTP/1.1 Cookie: JSESSIONID=y+FXYivGm2rdajrNhTRatNjl Prefer: persistent-auth, csrf-protection JSESSIONID: y+FXYivGm2rdajrNhTRatNjl If the protection is enabled and the caller fails to send this token then the request will be rejected and logged. Change-Id: I5700192b62e514091c9f29910596f312c068c5b2 Bug-Url: https://bugzilla.redhat.com/1077441 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 9491d9e6e34e1115fac9cfe4309c81cf554efdba) --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml A backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/CSRFProtectionFilter.java M backend/manager/modules/restapi/interface/common/jaxrs/src/main/modules/org/ovirt/engine/api/interface-common-jaxrs/main/module.xml M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml M ear/src/main/resources/META-INF/MANIFEST.MF M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 8 files changed, 243 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5700192b62e514091c9f29910596f312c068c5b2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0