- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Enable RESTAPI CSRF protection
by piotr.kliczewski＠gmail.com 11 Jul '14

11 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Enable RESTAPI CSRF protection ...................................................................... webadmin: Enable RESTAPI CSRF protection This patch changes the webadmin application so that it will always request CSRF protection when creating RESTAPI sessions. Change-Id: I92c41f18bcbb90441f352444dcc78408e8e61b16 Related: https://bugzilla.redhat.com/1077441 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 86c27b6f57b9361dce29245324e3eec6314841ef) --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, but someone else must approve Vojtech Szocs: Looks good to me, approved Keith Robertson: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29850 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92c41f18bcbb90441f352444dcc78408e8e61b16 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Spenser Shumaker <sshumake(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: correct path for snapshot links
by juan.hernandez＠redhat.com 11 Jul '14

11 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: core: correct path for snapshot links ...................................................................... core: correct path for snapshot links The links to the relevant snapshot objects should be under the snapshot object and not under the vm object to be consistent with the displayed path. Change-Id: I223b0cef14b887c1e1e3cff6f06b01fd3ac050c9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1077678 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotsResource.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I223b0cef14b887c1e1e3cff6f06b01fd3ac050c9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: engine-backup: ignore uuid-ossp errors
by piotr.kliczewski＠gmail.com 11 Jul '14

11 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging: engine-backup: ignore uuid-ossp errors ...................................................................... packaging: engine-backup: ignore uuid-ossp errors Change-Id: I4234351cc55d982035e259eecddc2c9749427c96 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 2d3c5c6baf822f2869121e6337dd80f1b25e1c30) --- M packaging/bin/engine-backup.sh 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4234351cc55d982035e259eecddc2c9749427c96 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: engine-backup: ignore uuid-ossp errors
by sbonazzo＠redhat.com 11 Jul '14

11 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: ignore uuid-ossp errors ...................................................................... packaging: engine-backup: ignore uuid-ossp errors Change-Id: I4234351cc55d982035e259eecddc2c9749427c96 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/29873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4234351cc55d982035e259eecddc2c9749427c96 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.1]: Treat migration state as Up and check engine health normally
by msivak＠redhat.com 11 Jul '14

11 Jul '14

Martin Sivák has submitted this change and it was merged. Change subject: Treat migration state as Up and check engine health normally ...................................................................... Treat migration state as Up and check engine health normally We used to treat migration source state as Vm up Health bad. That is not the correct report as the source Vm still works properly during live-merge. This caused a situation when a migration caused other hosts to try to start the Vm and fail because of sanlock protection. This moves migration source state to the group of states with Vm up Health <query the status page> behaviour. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093366 Change-Id: If3c813461909103b11266c902ccc51b2df2d0d36 Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit 0554e4208c4915863baeaa16fa5baeb678bfa0cf) --- M ovirt_hosted_engine_ha/broker/submonitors/engine_health.py 1 file changed, 9 insertions(+), 10 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jiří Moskovčák: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29903 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3c813461909103b11266c902ccc51b2df2d0d36 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.1 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: Treat migration state as Up and check engine health normally
by msivak＠redhat.com 11 Jul '14

11 Jul '14

Martin Sivák has submitted this change and it was merged. Change subject: Treat migration state as Up and check engine health normally ...................................................................... Treat migration state as Up and check engine health normally We used to treat migration source state as Vm up Health bad. That is not the correct report as the source Vm still works properly during live-merge. This caused a situation when a migration caused other hosts to try to start the Vm and fail because of sanlock protection. This moves migration source state to the group of states with Vm up Health <query the status page> behaviour. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093366 Change-Id: If3c813461909103b11266c902ccc51b2df2d0d36 Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit 0554e4208c4915863baeaa16fa5baeb678bfa0cf) --- M ovirt_hosted_engine_ha/broker/submonitors/engine_health.py 1 file changed, 9 insertions(+), 10 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jiří Moskovčák: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3c813461909103b11266c902ccc51b2df2d0d36 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.2 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: Use max instead of min when computing the best score
by msivak＠redhat.com 11 Jul '14

11 Jul '14

Martin Sivák has submitted this change and it was merged. Change subject: Use max instead of min when computing the best score ...................................................................... Use max instead of min when computing the best score The best score is the highest score, so this was a 'thinko'. However this bug manifests itself only if there are more than 2 hosts in the setup. Change-Id: I0c265aa60611793b1cd4738ec057e9e7d02747a1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093366 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/state_machine.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jiří Moskovčák: Verified -- To view, visit http://gerrit.ovirt.org/29580 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c265aa60611793b1cd4738ec057e9e7d02747a1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: try harder when connecting the storage
by msivak＠redhat.com 11 Jul '14

11 Jul '14

Martin Sivák has submitted this change and it was merged. Change subject: try harder when connecting the storage ...................................................................... try harder when connecting the storage the agent has to wait between attempts to connect the storage to give vdsm some time to initialize Change-Id: I4c512aad490366b0fbd890d156b37243993dc498 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093621 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/hosted_engine.py 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jiří Moskovčák: Verified -- To view, visit http://gerrit.ovirt.org/29862 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c512aad490366b0fbd890d156b37243993dc498 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Enable balloon by default - Patch 2 of 2
by piotr.kliczewski＠gmail.com 11 Jul '14

11 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Enable balloon by default - Patch 2 of 2 ...................................................................... core: Enable balloon by default - Patch 2 of 2 The "New VM"/"New Pool" dialogs in the frontend were changed to enable the balloon device in guest OSes where the "balloon.enabled" osinfo property is enabled. This way the system administrator will have an usable VM by default even in problematic guest OSes. Change-Id: I7803e45f07539090e5527ebc81bbc6c31df4e120 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1069858 Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Signed-off-by: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 2 files changed, 45 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7803e45f07539090e5527ebc81bbc6c31df4e120 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Add resteasy dependency to engine.ear manifest
by piotr.kliczewski＠gmail.com 11 Jul '14

11 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: Add resteasy dependency to engine.ear manifest ...................................................................... engine: Add resteasy dependency to engine.ear manifest The org.jboss.resteasy.resteasy-jaxrs is being added to the engine.ear manifest for the sake openstack-java sdk which requires it. Change-Id: I1d41c63bc023f025dff46c054deeed0f18188c97 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M ear/src/main/resources/META-INF/MANIFEST.MF 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29767 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d41c63bc023f025dff46c054deeed0f18188c97 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0