- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: use previously used address of balloon device
by ofrenkel＠redhat.com 13 Jul '14

13 Jul '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: use previously used address of balloon device ...................................................................... core: use previously used address of balloon device We should pass the previously used address of balloon device when running VM so it won't be detected as a new device and trigger the 'install driver for new device' dialog in the guest Change-Id: Ie4b93a14f395c3e7bdb83dc0a25dbda0546e4e92 Bug-Url: https://bugzilla.redhat.com/1028387 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/29838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4b93a14f395c3e7bdb83dc0a25dbda0546e4e92 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: reset migration progress on migration end
by ofrenkel＠redhat.com 13 Jul '14

13 Jul '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: reset migration progress on migration end ...................................................................... core: reset migration progress on migration end There where 2 problems: - if the qemu process died on source host the migration progress was never nulled - if the qemu process died on the destination host the migration progress was never nulled Change-Id: Ifeb3875da032622d53f3921b0186b08009e4a191 Bug-Url: https://bugzilla.redhat.com/1114997 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifeb3875da032622d53f3921b0186b08009e4a191 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine, webadmin: Inconsistent maintenance mode handling via...
by oourfali＠redhat.com 13 Jul '14

13 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine, webadmin: Inconsistent maintenance mode handling via host-deploy ...................................................................... engine, webadmin: Inconsistent maintenance mode handling via host-deploy When the host is reinstalled a new check box is presented that lets the host be activated after reinstall. Change-Id: Ic90eb22664ead14fbe64523fbd4f42cd02ab1601 Bug-Url: https://bugzilla.redhat.com/1087524 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeInternalCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsOperationActionParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/InstallModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.ui.xml 10 files changed, 53 insertions(+), 2 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic90eb22664ead14fbe64523fbd4f42cd02ab1601 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: engine-config.properties: remove left over line.
by oourfali＠redhat.com 13 Jul '14

13 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: tools: engine-config.properties: remove left over line. ...................................................................... tools: engine-config.properties: remove left over line. commit 116fef64 added meaningful description of the WebSocketProxy different options. However it seems as though the old description (value) was listed as a new unknown key. This causes the following line to be outputed as a value: null: (Value Type: String) Change-Id: I4a991e5aeabdf2195624a2899e6f2bf62e49296a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1116392 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M packaging/etc/engine-config/engine-config.properties 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a991e5aeabdf2195624a2899e6f2bf62e49296a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Implement sorting by simple status image
by lvernia＠redhat.com 13 Jul '14

13 Jul '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Implement sorting by simple status image ...................................................................... webadmin: Implement sorting by simple status image Implemented a couple of helper classes to sort simple status (i.e. none, down or up) columns in a generic way, and applied this logic to the Network/Clusters, Network/Hosts and Network/VMs subtabs. Change-Id: I9ac043ef1d522f67678b5c70b461833a82d3d9f0 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/NicActivateStatusColumn.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/SimpleStatusColumnComparator.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/SimpleStatusImageComparator.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkClusterView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkVmView.java 6 files changed, 85 insertions(+), 6 deletions(-) Approvals: Vojtech Szocs: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/28753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ac043ef1d522f67678b5c70b461833a82d3d9f0 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.4]: packaging: Added release notes
by ydary＠redhat.com 13 Jul '14

13 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: Added release notes ...................................................................... packaging: Added release notes Change-Id: I6959b3d1eaeb616d9ac4aef52a88553e8ee0be2a Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-dwh.spec.in 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29983 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6959b3d1eaeb616d9ac4aef52a88553e8ee0be2a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.4 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: ui: remove last delimiter in CustomProperties
by shavivi＠redhat.com 13 Jul '14

13 Jul '14

Shahar Havivi has submitted this change and it was merged. Change subject: ui: remove last delimiter in CustomProperties ...................................................................... ui: remove last delimiter in CustomProperties Change-Id: I3909f97cf2e02845c41a25bf5ca6f8327a6da3cd Bug-Url: https://bugzilla.redhat.com/1113503 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified -- To view, visit http://gerrit.ovirt.org/29891 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3909f97cf2e02845c41a25bf5ca6f8327a6da3cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: fix flatGroups recursive
by yzaslavs＠redhat.com 11 Jul '14

11 Jul '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: fix flatGroups recursive ...................................................................... aaa: fix flatGroups recursive incorrect get of groups of group record from principal record. also clean up the implementation to simplify. Topic: AAA Change-Id: Ief72097b8248ffb0c8d51d170a463453170b51c4 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/DirectoryUtils.java 1 file changed, 11 insertions(+), 13 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29948 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief72097b8248ffb0c8d51d170a463453170b51c4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core : [AAA] NPE is raised when searching user in domain by ...
by yzaslavs＠redhat.com 11 Jul '14

11 Jul '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core : [AAA] NPE is raised when searching user in domain by lastname ...................................................................... core : [AAA] NPE is raised when searching user in domain by lastname NPE when searching for user by lastname. SearchQuery passes $SN for lastname as key but the map in SearchQueryParsingUtils is missing $SN as key for the attributes map Change-Id: I294d415201f155d263d588b5a21f803c0870cb95 Bug-Url: https://bugzilla.redhat.com/1117240 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SearchQueryParsingUtils.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ravi Nori: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I294d415201f155d263d588b5a21f803c0870cb95 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: aaa: fix group list comma construction
by awels＠redhat.com 11 Jul '14

11 Jul '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: aaa: fix group list comma construction ...................................................................... webadmin: aaa: fix group list comma construction actually, the counter should have been incremented. but there is no reason to use extra variable. Topic: AAA Change-Id: Ic8b5bd60cfdcea2f5593364ed4c9a36ff4f3550d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29950 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8b5bd60cfdcea2f5593364ed4c9a36ff4f3550d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0