- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Add templates to the return value of query
by mlipchuk＠redhat.com 08 Jul '14

08 Jul '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add templates to the return value of query ...................................................................... core: Add templates to the return value of query Adding templates to the Map of GetTemplatesFromExportDomainQuery, once they parsed from the OVF. This query is being called when the user wants to view the list of templates in the export domain. Change-Id: I3af09baee674814418b00254fcf65f48b3961d28 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetTemplatesFromExportDomainQuery.java 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Omer Frenkel: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/29702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3af09baee674814418b00254fcf65f48b3961d28 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix server-side sort issue
by vszocs＠redhat.com 08 Jul '14

08 Jul '14

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Fix server-side sort issue ...................................................................... webadmin: Fix server-side sort issue This patch fixes an issue where triggering server-side sorting on a given column (via mouse click on sortable column header) might corrupt the actual search query dispatched by the model. - UI search string contains syntax error(s) - UI search string contains SORTBY syntax object If any of above holds true, sorting should be cleared across all columns of the given table - all columns should appear as not sorted. After applying this patch, following behavior is enforced: a, assume there is NO sorting applied on the given table, user triggers server-side sorting on a given column: a1, if the UI search string is 'valid' (no syntax errors, no SORTBY present), append SORTBY to the search string when dispatching actual search query (without updating UI search string) and execute refresh to fetch items a2, otherwise, clear sorting on given table - all columns should appear as not sorted b, assume the given table is sorted on a given column, user enters new UI search string and applies it via Search icon (or by pressing Enter key): b1, if the UI search string is NOT 'valid' (syntax errors and/or SORTBY present), clear sorting on given table - all columns should appear as not sorted b2, otherwise, proceed with applying sorting on the given column Change-Id: I7ce39a4e2b6323e6e0276a3a462a3f9da005344b Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java 5 files changed, 143 insertions(+), 43 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28557 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ce39a4e2b6323e6e0276a3a462a3f9da005344b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-cli[master]: cli: Update version number to 3.6.0.0
by juan.hernandez＠redhat.com 08 Jul '14

08 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Update version number to 3.6.0.0 ...................................................................... cli: Update version number to 3.6.0.0 Now that the 3.5 branch has been created the version of the master branch should be 3.6.0.0. Change-Id: I0ee16102056afcf948b42d13da154dacd4e58c8b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M ovirt-engine-cli.spec.in M setup.py 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ee16102056afcf948b42d13da154dacd4e58c8b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: sdk: Update version number to 3.6.0.0
by juan.hernandez＠redhat.com 08 Jul '14

08 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Update version number to 3.6.0.0 ...................................................................... sdk: Update version number to 3.6.0.0 Now that the 3.5 branch has been created the version of master should be 3.6.0.0. Change-Id: I9f114454d93f59ae2d927da516b5e1640a4a9455 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M setup.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f114454d93f59ae2d927da516b5e1640a4a9455 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk-java[master]: sdk: Update version number to 3.6.0.0
by juan.hernandez＠redhat.com 08 Jul '14

08 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Update version number to 3.6.0.0 ...................................................................... sdk: Update version number to 3.6.0.0 Now that the 3.5 branch has been created the version of the master branch should be 3.6. Change-Id: I4e4ed90a5bf7b7d94d4e442fdd815b8976fae43b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java/Makefile M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in M ovirt-engine-sdk-java/pom.xml 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29717 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e4ed90a5bf7b7d94d4e442fdd815b8976fae43b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.5]: upload: remove nossl option
by sbonazzo＠redhat.com 08 Jul '14

08 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: upload: remove nossl option ...................................................................... upload: remove nossl option Rest APIs doesn't support plain http connection so nossl doesn't make sense. Removing it. Change-Id: I04934a3a2c7b004c94692d5b163a73746c29d38c Bug-Url: https://bugzilla.redhat.com/1100825 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit 2619a581f6c0e00688a1d49618f28b53da83b884) --- M src/__main__.py 1 file changed, 1 insertion(+), 9 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04934a3a2c7b004c94692d5b163a73746c29d38c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-iso-uploader[master]: upload: remove nossl option
by sbonazzo＠redhat.com 08 Jul '14

08 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: upload: remove nossl option ...................................................................... upload: remove nossl option Rest APIs doesn't support plain http connection so nossl doesn't make sense. Removing it. Change-Id: I04934a3a2c7b004c94692d5b163a73746c29d38c Bug-Url: https://bugzilla.redhat.com/1100825 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/__main__.py 1 file changed, 1 insertion(+), 9 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/29711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04934a3a2c7b004c94692d5b163a73746c29d38c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: jsonrpc: Missing hostId parameter on reconstructMaster
by oourfali＠redhat.com 08 Jul '14

08 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: jsonrpc: Missing hostId parameter on reconstructMaster ...................................................................... jsonrpc: Missing hostId parameter on reconstructMaster Vdsm json schema was not consistent with vdsm api and there was missing hostId parameter. Change-Id: Ibe40b9f054278a7ffe108efb0e2c5a60bf643b64 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1115466 --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Federico Simoncelli: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29511 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe40b9f054278a7ffe108efb0e2c5a60bf643b64 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: remove PatternFly from source tree
by awels＠redhat.com 08 Jul '14

08 Jul '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: remove PatternFly from source tree ...................................................................... userportal, webadmin: remove PatternFly from source tree *NOTE:* after this commit, developers must install the PatternFly RPM dependency, or the web UI will be severely broken. Remove PatternFly dependency from source tree. Symlink ovirt.brand to PatternFly installation at /usr/share/patternfly1/resources. Create patternfly-ovirt.css that contains ovirt's customizations of PatternFly classes. Change-Id: I1da6bece78951a98be148050078c6d8201018273 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M Makefile M README.branding M README.developer M ovirt-engine.spec.in M packaging/branding/ovirt.brand/common.css D packaging/branding/ovirt.brand/fonts/OpenSans-Bold-webfont.eot D packaging/branding/ovirt.brand/fonts/OpenSans-Bold-webfont.svg D packaging/branding/ovirt.brand/fonts/OpenSans-Bold-webfont.ttf D packaging/branding/ovirt.brand/fonts/OpenSans-Bold-webfont.woff D packaging/branding/ovirt.brand/fonts/OpenSans-BoldItalic-webfont.eot D packaging/branding/ovirt.brand/fonts/OpenSans-BoldItalic-webfont.svg D packaging/branding/ovirt.brand/fonts/OpenSans-BoldItalic-webfont.ttf D packaging/branding/ovirt.brand/fonts/OpenSans-BoldItalic-webfont.woff D packaging/branding/ovirt.brand/fonts/OpenSans-ExtraBold-webfont.eot D packaging/branding/ovirt.brand/fonts/OpenSans-ExtraBold-webfont.svg D packaging/branding/ovirt.brand/fonts/OpenSans-ExtraBold-webfont.ttf D packaging/branding/ovirt.brand/fonts/OpenSans-ExtraBold-webfont.woff D packaging/branding/ovirt.brand/fonts/OpenSans-ExtraBoldItalic-webfont.eot D packaging/branding/ovirt.brand/fonts/OpenSans-ExtraBoldItalic-webfont.svg D packaging/branding/ovirt.brand/fonts/OpenSans-ExtraBoldItalic-webfont.ttf D packaging/branding/ovirt.brand/fonts/OpenSans-ExtraBoldItalic-webfont.woff D packaging/branding/ovirt.brand/fonts/OpenSans-Italic-webfont.eot D packaging/branding/ovirt.brand/fonts/OpenSans-Italic-webfont.svg D packaging/branding/ovirt.brand/fonts/OpenSans-Italic-webfont.ttf D packaging/branding/ovirt.brand/fonts/OpenSans-Italic-webfont.woff D packaging/branding/ovirt.brand/fonts/OpenSans-Light-webfont.eot D packaging/branding/ovirt.brand/fonts/OpenSans-Light-webfont.svg D packaging/branding/ovirt.brand/fonts/OpenSans-Light-webfont.ttf D packaging/branding/ovirt.brand/fonts/OpenSans-Light-webfont.woff D packaging/branding/ovirt.brand/fonts/OpenSans-LightItalic-webfont.eot D packaging/branding/ovirt.brand/fonts/OpenSans-LightItalic-webfont.svg D packaging/branding/ovirt.brand/fonts/OpenSans-LightItalic-webfont.ttf D packaging/branding/ovirt.brand/fonts/OpenSans-LightItalic-webfont.woff D packaging/branding/ovirt.brand/fonts/OpenSans-Regular-webfont.eot D packaging/branding/ovirt.brand/fonts/OpenSans-Regular-webfont.svg D packaging/branding/ovirt.brand/fonts/OpenSans-Regular-webfont.ttf D packaging/branding/ovirt.brand/fonts/OpenSans-Regular-webfont.woff D packaging/branding/ovirt.brand/fonts/OpenSans-Semibold-webfont.eot D packaging/branding/ovirt.brand/fonts/OpenSans-Semibold-webfont.svg D packaging/branding/ovirt.brand/fonts/OpenSans-Semibold-webfont.ttf D packaging/branding/ovirt.brand/fonts/OpenSans-Semibold-webfont.woff D packaging/branding/ovirt.brand/fonts/OpenSans-SemiboldItalic-webfont.eot D packaging/branding/ovirt.brand/fonts/OpenSans-SemiboldItalic-webfont.svg D packaging/branding/ovirt.brand/fonts/OpenSans-SemiboldItalic-webfont.ttf D packaging/branding/ovirt.brand/fonts/OpenSans-SemiboldItalic-webfont.woff D packaging/branding/ovirt.brand/fonts/PatternFlyIcons-webfont.eot D packaging/branding/ovirt.brand/fonts/PatternFlyIcons-webfont.svg D packaging/branding/ovirt.brand/fonts/PatternFlyIcons-webfont.ttf D packaging/branding/ovirt.brand/fonts/PatternFlyIcons-webfont.woff D packaging/branding/ovirt.brand/fonts/fontawesome-webfont.eot D packaging/branding/ovirt.brand/fonts/fontawesome-webfont.svg D packaging/branding/ovirt.brand/fonts/fontawesome-webfont.ttf D packaging/branding/ovirt.brand/fonts/fontawesome-webfont.woff D packaging/branding/ovirt.brand/fonts/glyphicons-halflings-regular.eot D packaging/branding/ovirt.brand/fonts/glyphicons-halflings-regular.svg D packaging/branding/ovirt.brand/fonts/glyphicons-halflings-regular.ttf D packaging/branding/ovirt.brand/fonts/glyphicons-halflings-regular.woff D packaging/branding/ovirt.brand/js/patternfly.min.js A packaging/branding/ovirt.brand/patternfly-ovirt.css 59 files changed, 170 insertions(+), 2,139 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/29018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1da6bece78951a98be148050078c6d8201018273 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[sdk_3.5]: codegen: Ignore errors when cleaning old connection
by juan.hernandez＠redhat.com 08 Jul '14

08 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Ignore errors when cleaning old connection ...................................................................... codegen: Ignore errors when cleaning old connection The constructor of the API object tries to clean connections left around by the user, calling their "disconnect" method. If this fails the creation of the new API object fails as well. To avoid that this patch changes the SDK so that any error during that cleaup is ignored. Change-Id: Id2a5c690aa9336bc0b441ca57100b9d6cd09e335 Bug-Url: https://bugzilla.redhat.com/1116009 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 3b6ed1ed646eb57eadacc59e0e66cfa56d4547b2) --- M src/codegen/templates/entrypointtemplate 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29707 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2a5c690aa9336bc0b441ca57100b9d6cd09e335 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0