- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[master]: codegen: Ignore errors when cleaning old connection
by juan.hernandez＠redhat.com 08 Jul '14

08 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Ignore errors when cleaning old connection ...................................................................... codegen: Ignore errors when cleaning old connection The constructor of the API object tries to clean connections left around by the user, calling their "disconnect" method. If this fails the creation of the new API object fails as well. To avoid that this patch changes the SDK so that any error during that cleaup is ignored. Change-Id: Id2a5c690aa9336bc0b441ca57100b9d6cd09e335 Bug-Url: https://bugzilla.redhat.com/1116009 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/codegen/templates/entrypointtemplate 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Simone Tiraboschi: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29684 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2a5c690aa9336bc0b441ca57100b9d6cd09e335 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: fix filter/weight/balance getter
by gchaplik＠redhat.com 08 Jul '14

08 Jul '14

Gilad Chaplik has submitted this change and it was merged. Change subject: restapi: fix filter/weight/balance getter ...................................................................... restapi: fix filter/weight/balance getter fixes both get and remove policy units per scheduling policy. Change-Id: I0a336e9fe3f8fa77d94469d28ecad64234e9b685 Bug-Url: https://bugzilla.redhat.com/1114944 Bug-Url: https://bugzilla.redhat.com/1115071 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendBalanceResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendBalancesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendFilterResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendFiltersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendPolicyUnitResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendPolicyUnitsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendWeightResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendWeightsResource.java 8 files changed, 45 insertions(+), 14 deletions(-) Approvals: Ori Liel: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/29514 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a336e9fe3f8fa77d94469d28ecad64234e9b685 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: impossible to delete scheduling policy
by gchaplik＠redhat.com 08 Jul '14

08 Jul '14

Gilad Chaplik has submitted this change and it was merged. Change subject: restapi: impossible to delete scheduling policy ...................................................................... restapi: impossible to delete scheduling policy Change-Id: I36b14ca91aaa0aa862b42fd598b9831f6a7b3893 Bug-Url: https://bugzilla.redhat.com/1114926 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/SchedulingPoliciesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSchedulingPoliciesResource.java 2 files changed, 20 insertions(+), 3 deletions(-) Approvals: Ori Liel: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/29513 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36b14ca91aaa0aa862b42fd598b9831f6a7b3893 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-release[master]: packaging: add repo for PatternFly
by sbonazzo＠redhat.com 08 Jul '14

08 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: add repo for PatternFly ...................................................................... packaging: add repo for PatternFly Change-Id: I5ce5b58e3fd5a7f3377d35cc6965b04f8b3c2c91 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M ovirt-release-3.5/Makefile.am M ovirt-release-3.5/configure.ac M ovirt-release-3.5/ovirt-el-deps.repo.in M ovirt-release-3.5/ovirt-f19-deps.repo.in A ovirt-release-3.5/ovirt-f20-deps.repo.in M ovirt-release-3.5/ovirt-release35.spec.in 6 files changed, 31 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified Kiril Nesenko: Looks good to me, approved Greg Sheremeta: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ce5b58e3fd5a7f3377d35cc6965b04f8b3c2c91 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: frontend: Fix NPE in ConsoleProtocol
by oourfali＠redhat.com 08 Jul '14

08 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: frontend: Fix NPE in ConsoleProtocol ...................................................................... frontend: Fix NPE in ConsoleProtocol This patch fixes NPE when changing VM console protocol. The exception was caused by modifying collection that was created using Arrays.asList() and this list implementation throws NPE when removing elements from it. Fixed by wrapping the list in ArrayList implementation, so that client code can mutate the collection. Change-Id: Iaafdc72b83552b51ae65fcf3130b86b1949a3a56 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1109376 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsoleProtocol.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaafdc72b83552b51ae65fcf3130b86b1949a3a56 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-engine-reports-3.4]: packaging: added release notes
by ydary＠redhat.com 08 Jul '14

08 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: added release notes ...................................................................... packaging: added release notes Change-Id: Ica53b81e43b5191632e4a6357cc6e8f2854ca402 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-reports.spec.in 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica53b81e43b5191632e4a6357cc6e8f2854ca402 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.4 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core, engine: Fix CD-ROM payload in ppc64 VMs
by rgolan＠redhat.com 08 Jul '14

08 Jul '14

Roy Golan has submitted this change and it was merged. Change subject: core, engine: Fix CD-ROM payload in ppc64 VMs ...................................................................... core, engine: Fix CD-ROM payload in ppc64 VMs This change fixes the addressing for payload CD-ROMs in ppc64 VMs, previously there was not a way to address two virtual CD drives at the same time in the sPAPR VSCSI controller. Change-Id: Ieca8008621392b95cb9dcd5eb8ca230233de19dc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073540 Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 1 file changed, 14 insertions(+), 6 deletions(-) Approvals: Gustavo Frederico Temple Pedrosa: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieca8008621392b95cb9dcd5eb8ca230233de19dc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-engine-reports-3.4]: packaging: setup: disable Spring integration in JRS pro
by ydary＠redhat.com 08 Jul '14

08 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: disable Spring integration in JRS pro ...................................................................... packaging: setup: disable Spring integration in JRS pro This is needed to be compatiable with some versions of JBoss. Change-Id: Ic1e4bd0ece4ae9386ac4f816a89d68ae7dabf4c0 Bug-Url: https://bugzilla.redhat.com/1117190 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> (cherry picked from commit 87f9750c6e25317fab20b4f8faf4c406674fd186) --- A packaging/jasper-war-patches/pro/200_007_web-inf_disable_spring_integration.patch 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1e4bd0ece4ae9386ac4f816a89d68ae7dabf4c0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.4 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Change trigger for VnicProfileWidget ValueChangeEvent
by lvernia＠redhat.com 08 Jul '14

08 Jul '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Change trigger for VnicProfileWidget ValueChangeEvent ...................................................................... webadmin: Change trigger for VnicProfileWidget ValueChangeEvent VnicProfileWidget used to listen on its nameEditor's ValueChangeEvent in order to fire a ValueChangeEvent on its own. However, when the nameEditor's value was changed programmatically from its model, UiCommonEditorVisitor would call an overload of nameEditor.setValue() that would set the value without firing a ValueChangeEvent. This patch registers directly to the model, so that the programmatical change on the model side would trigger a ValueChangeEvent of VnicProfileWidget. Change-Id: I330c38ecedb0df6433491bedaeb7afdc2bd11ae5 Bug-Url: https://bugzilla.redhat.com/1114971 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/29526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I330c38ecedb0df6433491bedaeb7afdc2bd11ae5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Bind port to agent when port is being activated
by masayag＠redhat.com 08 Jul '14

08 Jul '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Bind port to agent when port is being activated ...................................................................... engine: Bind port to agent when port is being activated When using the ml2 core plugin, the activated port should be associated with the host on which it has been scheduled. Bug-Url: http://bugzilla.redhat.com/1078862 Change-Id: I0cb5bf95054b6d2711f88a09d374a74f156a4055 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/NetworkProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java M ovirt-engine.spec.in M pom.xml 6 files changed, 41 insertions(+), 15 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Omer Frenkel: Looks good to me, but someone else must approve Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/28792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cb5bf95054b6d2711f88a09d374a74f156a4055 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0