- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix Dynamic Queries to search all fields for non exist...
by oourfali＠redhat.com 08 Jul '14

08 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Fix Dynamic Queries to search all fields for non existing field ...................................................................... core: Fix Dynamic Queries to search all fields for non existing field Make sure that when searching for a field that doesn't appear we search the _with_tags table. Change-Id: I1aef8977331f9b3bd1d5003fbd9c7104b176eb92 Bug-Url: https://bugzilla.redhat.com/1114992 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 2 files changed, 53 insertions(+), 10 deletions(-) Approvals: Liran Zelkha: Verified Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1aef8977331f9b3bd1d5003fbd9c7104b176eb92 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove redundant synchronization (CoCo cleanup)
by oourfali＠redhat.com 08 Jul '14

08 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: remove redundant synchronization (CoCo cleanup) ...................................................................... core: remove redundant synchronization (CoCo cleanup) a method which is executed by our quartz in fixed delay can only be executed by one thread at each given time, because before executing it we remove it from the quartz pool and when it ends we put it back. so no need to synchronize anything for protecting from parallel executions of the same critical section Change-Id: I588de14e21f19ef59781b382b2450b8723635667 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java 1 file changed, 5 insertions(+), 10 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Arik Hadas: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29522 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I588de14e21f19ef59781b382b2450b8723635667 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: Fixing hostPopupView tab indexes
by oourfali＠redhat.com 07 Jul '14

07 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: ui: Fixing hostPopupView tab indexes ...................................................................... ui: Fixing hostPopupView tab indexes Change-Id: Ie183a178c86cbdfc58e52baf75700d44e5a40934 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1115045 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yaniv Bronhaim: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29626 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie183a178c86cbdfc58e52baf75700d44e5a40934 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Warning instead of error if kdump not configured
by oourfali＠redhat.com 07 Jul '14

07 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Warning instead of error if kdump not configured ...................................................................... core: Warning instead of error if kdump not configured Show warning instead of error if kdump is not configured properly on host. Change-Id: I51f21f74198a2e81222363c31e399139844a06ed Bug-Url: https://bugzilla.redhat.com/1114965 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51f21f74198a2e81222363c31e399139844a06ed Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[master]: packaging: Depend on ovirt-host-deploy-offline >= 1.3.0
by dougsland＠redhat.com 07 Jul '14

07 Jul '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: packaging: Depend on ovirt-host-deploy-offline >= 1.3.0 ...................................................................... packaging: Depend on ovirt-host-deploy-offline >= 1.3.0 Adds dependency on ovirt-host-deploy-offline >= 1.3.0 to fetch needed dependencies for kdump integration. Change-Id: I28e0f11269bdc26a24a9892b17cfef557b02e42b Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28e0f11269bdc26a24a9892b17cfef557b02e42b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: remove display field from add network to data-cente...
by juan.hernandez＠redhat.com 07 Jul '14

07 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: remove display field from add network to data-center action parameters ...................................................................... restapi: remove display field from add network to data-center action parameters Remove display field from add network to data-center action parameters as it isn't relevant to the action on data-center level. Change-Id: Ie8a135347ccdd3e8692b12a639c4ee214384e5e4 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8a135347ccdd3e8692b12a639c4ee214384e5e4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: add usages field to "add network to data-center" ac...
by juan.hernandez＠redhat.com 07 Jul '14

07 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: add usages field to "add network to data-center" action params ...................................................................... restapi: add usages field to "add network to data-center" action params 1. Add network usages field to "add network" action parameters. 2. Copy optional parameters definition from "/networks|rel=add" URL to "/datacenters/{datacenter:id}/networks|rel=add" URL. 3. Re-arrange the parameter blocks for better readability. Change-Id: Ia5549de3adee242801cd6034426ec67310cbf8d6 Bug-Url: https://bugzilla.redhat.com/1085464 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 30 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5549de3adee242801cd6034426ec67310cbf8d6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[sdk_3.5]: sdk: Indicate that session_timeout is in minutes
by juan.hernandez＠redhat.com 07 Jul '14

07 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Indicate that session_timeout is in minutes ...................................................................... sdk: Indicate that session_timeout is in minutes This patch changes the SDK so that the documentation for the "session_timeout" parameter explicitly indicates that the unit is minutes. Change-Id: I4d82a2e990e7286fb3a5858c6d8dbe52f8a75a78 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 548a1c5901d90611c30798fdacb97f409f6a024d) --- M src/codegen/templates/entrypointtemplate 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d82a2e990e7286fb3a5858c6d8dbe52f8a75a78 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: sdk: Indicate that session_timeout is in minutes
by juan.hernandez＠redhat.com 07 Jul '14

07 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Indicate that session_timeout is in minutes ...................................................................... sdk: Indicate that session_timeout is in minutes This patch changes the SDK so that the documentation for the "session_timeout" parameter explicitly indicates that the unit is minutes. Change-Id: I4d82a2e990e7286fb3a5858c6d8dbe52f8a75a78 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/codegen/templates/entrypointtemplate 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d82a2e990e7286fb3a5858c6d8dbe52f8a75a78 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Gadi Ickowicz <gickowic(a)redhat.com> Gerrit-Reviewer: Ilia Meerovich <imeerovi(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: packaging: setup: disable Spring integration in JRS pro
by ydary＠redhat.com 07 Jul '14

07 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: disable Spring integration in JRS pro ...................................................................... packaging: setup: disable Spring integration in JRS pro This is needed to be compatiable with some versions of JBoss. Change-Id: Ic1e4bd0ece4ae9386ac4f816a89d68ae7dabf4c0 Bug-Url: https://bugzilla.redhat.com/1115569 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- A packaging/jasper-war-patches/pro/200_007_web-inf_disable_spring_integration.patch 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1e4bd0ece4ae9386ac4f816a89d68ae7dabf4c0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0