- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-java[master]: codegen: Handle duplicated URL segments
by juan.hernandez＠redhat.com 04 Jul '14

04 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Handle duplicated URL segments ...................................................................... codegen: Handle duplicated URL segments There are some entities and collections whose names can't be directly derived by the corresponding URL segments. For example, the following two URLs contain segments that are equal: hosts/{host:id}/numanodes vms/{vm:id}/numanodes But the corresponding types are "NumaNode" in the first case and "VirtualNumaNode" in the second, so it isn't possible to derive the type name using only the URL segment. To address this issue this patch introduces a table of exceptions that the generator will lookup. This table will initially contain the exception in the example above. Change-Id: I7fcbfe5e490bb23aa2e1785560dd016d63e3a9ae Bug-Url: https://bugzilla.redhat.com/1116119 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/rsdl/RsdlCodegen.java M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/utils/ArrayUtils.java 2 files changed, 133 insertions(+), 33 deletions(-) Approvals: Jason Liao: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29569 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fcbfe5e490bb23aa2e1785560dd016d63e3a9ae Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jason Liao <chuan.liao(a)hp.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk-java[sdk_3.5]: codegen: Handle plural exceptions
by juan.hernandez＠redhat.com 04 Jul '14

04 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Handle plural exceptions ...................................................................... codegen: Handle plural exceptions The rules for forming plurals are more complicated than just adding a "s" to the end of the word. We need to implement them correctly, or have a table of exceptions. For simplicity this patch introduces a table of exceptions. Change-Id: I02d75c47af205f25dfe00c1c98dc0045f5d463f6 Bug-Url: https://bugzilla.redhat.com/1113548 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit c8d3d7484ec08109b49c42c717ace5e187bd23f7) --- M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/utils/StringUtils.java 1 file changed, 39 insertions(+), 15 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02d75c47af205f25dfe00c1c98dc0045f5d463f6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk-java[master]: codegen: Handle plural exceptions
by juan.hernandez＠redhat.com 04 Jul '14

04 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Handle plural exceptions ...................................................................... codegen: Handle plural exceptions The rules for forming plurals are more complicated than just adding a "s" to the end of the word. We need to implement them correctly, or have a table of exceptions. For simplicity this patch introduces a table of exceptions. Change-Id: I02d75c47af205f25dfe00c1c98dc0045f5d463f6 Bug-Url: https://bugzilla.redhat.com/1113548 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/utils/StringUtils.java 1 file changed, 39 insertions(+), 15 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02d75c47af205f25dfe00c1c98dc0045f5d463f6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Rename "kdump detection" to "kdump integration"
by oourfali＠redhat.com 04 Jul '14

04 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Rename "kdump detection" to "kdump integration" ...................................................................... webadmin: Rename "kdump detection" to "kdump integration" Renames term "kdump detection" to "kdump integration" in user visible parts (UI and logs). Change-Id: I4bdcf78eb27902951f0298b13bf671bebd828fc6 Bug-Url: https://bugzilla.redhat.com/1079821 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 11 insertions(+), 13 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29478 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4bdcf78eb27902951f0298b13bf671bebd828fc6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: Moving question about WSP configuration to...
by oschreib＠redhat.com 04 Jul '14

04 Jul '14

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: Moving question about WSP configuration to product options ...................................................................... packaging: setup: Moving question about WSP configuration to product options Moving question about websocket proxy configuration to product options section. Change-Id: I594f6d396b3ad75dabc44dc187d5ac99687ad78b Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Simone Tiraboschi: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I594f6d396b3ad75dabc44dc187d5ac99687ad78b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[master]: packaging: add version information
by dougsland＠redhat.com 03 Jul '14

03 Jul '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: packaging: add version information ...................................................................... packaging: add version information add /etc/default/version.$(PACKAGE) as: PACKAGE=@PACKAGE_NAME@ VERSION=@PACKAGE_RPM_VERSION@ RELEASE=@PACKAGE_RPM_RELEASE@ to enable software to detect plugin version while running on node. Change-Id: I3743ef37e804137e2a3517180a67c5fb1a6cecbc Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile.am M configure.ac M ovirt-node-plugin-vdsm.spec.in A version.ovirt-node-plugin-vdsm.in 5 files changed, 24 insertions(+), 5 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3743ef37e804137e2a3517180a67c5fb1a6cecbc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: fixed badly formed multi-line values.
by lvernia＠redhat.com 03 Jul '14

03 Jul '14

Lior Vernia has submitted this change and it was merged. Change subject: userportal, webadmin: fixed badly formed multi-line values. ...................................................................... userportal, webadmin: fixed badly formed multi-line values. few multi-line values were invalid, which caused that only substring was presented to the user. Bug-Url: https://bugzilla.redhat.com/1075509 Change-Id: I58f14efbc29ea7a8ba9f741175b17a62ee320f86 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 3 files changed, 4 insertions(+), 9 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58f14efbc29ea7a8ba9f741175b17a62ee320f86 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Support generic types for "add"
by juan.hernandez＠redhat.com 03 Jul '14

03 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Support generic types for "add" ...................................................................... restapi: Support generic types for "add" Currently the RSDL builder doesn't support generic types as parameters to the "add" operation. As a result the generation of the Java SDK doesn't work correctly. Change-Id: I60d4b44c183eaaa4a42737382bcc6ad33a5ff989 Bug-Url: https://bugzilla.redhat.com/1115610 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlBuilder.java 1 file changed, 36 insertions(+), 23 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Gilad Chaplik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60d4b44c183eaaa4a42737382bcc6ad33a5ff989 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: use updated storage allocation validation
by amureini＠redhat.com 03 Jul '14

03 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: use updated storage allocation validation ...................................................................... core: use updated storage allocation validation StorageDomainValidator.hasSpaceForClonedDisks() was introduced to the system in commit 53b5eba699a695edc5b2e963e28b43ea5290b299 in order to align all storage allocation checks throughout the system. This patch applies above validation instead of the existing one LiveMigrateVmDisksCommand. Change-Id: I886967b7c2dadbbd301eadbea0c7eac9992aba08 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java 1 file changed, 8 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28945 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I886967b7c2dadbbd301eadbea0c7eac9992aba08 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: LSM without context
by amureini＠redhat.com 03 Jul '14

03 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: LSM without context ...................................................................... core: LSM without context LiveMigrateVmDisksCommand did not have a c'tor without CommandContext, which made it impossible to use LSM. Change-Id: I55ac1cc3b234a56a5d269ab4ebaeac528a3190de Bug-Url: http://bugzilla.redhat.com/1116031 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29507 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55ac1cc3b234a56a5d269ab4ebaeac528a3190de Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0