- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Setup networks- limiting 'network label' text width
by alkaplan＠redhat.com 06 Jul '14

06 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Setup networks- limiting 'network label' text width ...................................................................... webadmin: Setup networks- limiting 'network label' text width LabelWithTooltip is used to limit the width of the label name. In case the name width is bigger than the limited width (in pixels), the name is trimmed and '...' are add to it. The tooltip displays the whole name. Change-Id: I7315c42d39969de8eaa0c922b1f25050195ec352 Bug-Url: https://bugzilla.redhat.com/1084748 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkLabelPanel.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7315c42d39969de8eaa0c922b1f25050195ec352 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Limiting vnic name label width on vm dialog
by alkaplan＠redhat.com 06 Jul '14

06 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Limiting vnic name label width on vm dialog ...................................................................... webadmin: Limiting vnic name label width on vm dialog LabelWithTooltip is used to limit the width of the vnic name label. In case the name width is bigger than the limited width (in pixels), the name is trimmed and '...' are add to it. The tooltip displays the whole name. Change-Id: I32d30aa8d1824b127030a533fcde57aaa75983b3 Bug-Url: https://bugzilla.redhat.com/1029973 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.ui.xml 2 files changed, 16 insertions(+), 5 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29126 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32d30aa8d1824b127030a533fcde57aaa75983b3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: LabelWithTextOverflow trims long text and add "..."
by alkaplan＠redhat.com 06 Jul '14

06 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: LabelWithTextOverflow trims long text and add "..." ...................................................................... webadmin: LabelWithTextOverflow trims long text and add "..." In case the lable's text is cropped, the text is visually trimmed. To let the user know that the text was trimmed '...' are appended to the string. The tooltip contains the full text string. Bug-Url: https://bugzilla.redhat.com/1096662 Change-Id: I3a0c6292b874d0994042366940123b42b38b7a8d Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ElementUtils.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/LabelWithCustomToolTip.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/LabelWithTextOverflow.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractCellWithTooltip.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/BondPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfaceLabelWithToolTip.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/StatisticsPanel.java D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/LabelWithToolTip.java 9 files changed, 202 insertions(+), 119 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29125 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a0c6292b874d0994042366940123b42b38b7a8d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: integrate make into maven
by rgolan＠redhat.com 06 Jul '14

06 Jul '14

Roy Golan has submitted this change and it was merged. Change subject: core: integrate make into maven ...................................................................... core: integrate make into maven Use maven to deploy the artifact to prefix using make: #exclusivly deploy from ovirt-engine root mvn install -pl org.ovirt.engine:make -Pmake #build the project and deploy to $OVIRT_ENGINE_PREFIX mvn clean install -Pmake #For explicit prefix use: mvn install -Pmake -Dprefix=/path/to/prefix The prefix defaults to env variable OVIRT_ENGINE_PREFIX Change-Id: I8981f04b26a2d36429f8bfccaada8dfbadfbf9c3 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- A mavenmake/pom.xml M pom.xml 2 files changed, 54 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Roy Golan: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8981f04b26a2d36429f8bfccaada8dfbadfbf9c3 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Use ValidationResult enhancements in ProviderValidator
by masayag＠redhat.com 06 Jul '14

06 Jul '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use ValidationResult enhancements in ProviderValidator ...................................................................... engine: Use ValidationResult enhancements in ProviderValidator The ValidationResult.failWith().when() provides a nice api for validation. The patch uses it in ProviderValidator. Change-Id: Ibcff64a7f77a95a6ae788c8871c7d673829a0223 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderValidator.java 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/29608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibcff64a7f77a95a6ae788c8871c7d673829a0223 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Nic labels should be sorted
by alkaplan＠redhat.com 06 Jul '14

06 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Nic labels should be sorted ...................................................................... webadmin: Nic labels should be sorted Nic labels should be presented according to LexoNumeric order. There are two places that should be sorted- 1. Setup Networks- edit nic dialog- the current labels. 2. Host interface subtab- the labels tooltip (on nic or bond). Note- Setup Networks->edit nic dialog->suggested labels- are already sorted. HostSetupNetworksModel.getFreeLabels() takes care of it. Change-Id: I28fb7750504bffdadd9d92f00565e21c272127ff Bug-Url: https://bugzilla.redhat.com/1091674 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NicLabelModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfaceLabelWithToolTip.java 2 files changed, 9 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28fb7750504bffdadd9d92f00565e21c272127ff Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Interface dialog- when opening the labels scroll s...
by alkaplan＠redhat.com 06 Jul '14

06 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Interface dialog- when opening the labels scroll should be down ...................................................................... webadmin: Interface dialog- when opening the labels scroll should be down when opening the network labels window, the scrollbar should be down, so you should be able to click on '+' button without using scrollbar. Being there fixed all the other classes that extends AddRemoveRowWidget a have a scrollPanel. Change-Id: I4a2d5bd7280ef98a6ac0e94c336fcc6f30666c8a Bug-Url: https://bugzilla.redhat.com/1091695 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/ScrollableAddRemoveRowWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/DnsServersWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/DnsServersWidget.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.ui.xml 9 files changed, 37 insertions(+), 12 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28884 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a2d5bd7280ef98a6ac0e94c336fcc6f30666c8a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : Live Merge fails to find cotr for RemoveSnapshotSin...
by oourfali＠redhat.com 06 Jul '14

06 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine : Live Merge fails to find cotr for RemoveSnapshotSingleDiskLiveCommand ...................................................................... engine : Live Merge fails to find cotr for RemoveSnapshotSingleDiskLiveCommand Live deletion of a snapshot (live merge) fails to find constructor for RemoveSnapshotSingleDiskLiveCommand Change-Id: I8b1053621030049ed2e04de3fb5965f98a33ad05 Bug-Url: https://bugzilla.redhat.com/1115127 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java 5 files changed, 21 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Verified Greg Padgett: Verified; Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29533 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b1053621030049ed2e04de3fb5965f98a33ad05 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fixing format for external provider objects
by oourfali＠redhat.com 06 Jul '14

06 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: fixing format for external provider objects ...................................................................... core: fixing format for external provider objects Change-Id: I6b1cc0c30b366e11bb7847a41c6234829a83e0bf Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanComputerResource.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanComputerResourceWrapper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanDiscoveredHost.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanDiscoveredHostWrapper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHost.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostGroup.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostGroupWrapper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostWrapper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanOperatingSystem.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanOperatingSystemWrapper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalComputeResource.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalDiscoveredHost.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalEntityBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalHost.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalHostGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalOperatingSystem.java 17 files changed, 271 insertions(+), 71 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/29548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b1cc0c30b366e11bb7847a41c6234829a83e0bf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Edit interface- the last label should get the focus
by alkaplan＠redhat.com 06 Jul '14

06 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Edit interface- the last label should get the focus ...................................................................... webadmin: Edit interface- the last label should get the focus Change-Id: I3ad1d11aab2a833ac210a737bbb95319197c4f1e Bug-Url: https://bugzilla.redhat.com/1091676 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelEditor.java 2 files changed, 27 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ad1d11aab2a833ac210a737bbb95319197c4f1e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0