- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: simplify isSameSourceAndDest
by amureini＠redhat.com 03 Jul '14

03 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: simplify isSameSourceAndDest ...................................................................... core: simplify isSameSourceAndDest Simplified LiveMigrateVmDisksCommand.isSameSourceAndDest() 's implementation. Change-Id: Ie5c32734d517f27230efd7ea67d4841d55d2c8ec Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5c32734d517f27230efd7ea67d4841d55d2c8ec Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: changed method call for readability
by amureini＠redhat.com 03 Jul '14

03 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: changed method call for readability ...................................................................... core: changed method call for readability In LiveMigrateVmDisksCommand, changed calls to parameters.getStorageDomainId to paramaters.getTargetStorageDomainId for readability. The latter's impelementation only calls the former. Change-Id: Id1c95635d602094a7d5babb532f4e79038c43039 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1c95635d602094a7d5babb532f4e79038c43039 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: AddLSM source sd allocation validation
by amureini＠redhat.com 03 Jul '14

03 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddLSM source sd allocation validation ...................................................................... core: AddLSM source sd allocation validation In LiveMigrateVmDisksCommand - added space allocation validation in the source domains. A snapshot is taken on the source domain before actual migration. Therefore source domains should have enough space for a new active image, a fact verified by this patch. Also changed relevant error message to not contain the word "target" to suggest target storage domain since the same validation message is set for both source and target storage domains. Note the message includes the name of the specific storage domain, so this should do. Change-Id: I1914f5efe50d2f5a4fb9debf0c0bde4ffc9e32eb Bug-Url: https://bugzilla.redhat.com/1099894 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmTemplateCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 19 files changed, 65 insertions(+), 39 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1914f5efe50d2f5a4fb9debf0c0bde4ffc9e32eb Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Add the option to create Posix/Gluster export domains
by tnisan＠redhat.com 03 Jul '14

03 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Add the option to create Posix/Gluster export domains ...................................................................... webadmin: Add the option to create Posix/Gluster export domains In the new storage domain dialog, added the option to add a Posix export domain and a Gluster export domain Change-Id: I4f39ed43026292011ae000f30806e02db9468d99 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1065963 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 2 files changed, 18 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f39ed43026292011ae000f30806e02db9468d99 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: Adding base class for external entity objects
by oourfali＠redhat.com 03 Jul '14

03 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: ui: Adding base class for external entity objects ...................................................................... ui: Adding base class for external entity objects Change-Id: Ieedfa9efcd062c3a4a41250fee0a8b1a22844ff6 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalComputeResource.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalDiscoveredHost.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalEntityBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalHostGroup.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java 7 files changed, 68 insertions(+), 94 deletions(-) Approvals: Yaniv Bronhaim: Verified Daniel Erez: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieedfa9efcd062c3a4a41250fee0a8b1a22844ff6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: history: fixed users external_id type due to engine change
by ydary＠redhat.com 03 Jul '14

03 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: history: fixed users external_id type due to engine change ...................................................................... history: fixed users external_id type due to engine change external_id feild changed to type text on engine. update etl and history db accordingly. Change-Id: I328a5d27ca90eb4ebb338cedf41fe9d0e4f49f7e Bug-Url: https://bugzilla.redhat.com/1113193 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- A packaging/dbscripts/upgrade/03_05_0050_updated_users_history_table_external_id.sql M tos_project/process/ConfigurationSync_3.5.item M tos_project/process/ConfigurationSync_3.5.properties 3 files changed, 13 insertions(+), 9 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I328a5d27ca90eb4ebb338cedf41fe9d0e4f49f7e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: add buttons in the new cluster dialog and make it ...
by gchaplik＠redhat.com 03 Jul '14

03 Jul '14

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: add buttons in the new cluster dialog and make it closeable ...................................................................... webadmin: add buttons in the new cluster dialog and make it closeable When create a cluster from the system tree panel, e.g. select a ovirtmgmt node in the system tree and select Clusters source tab, then click the New button, the "New Cluster" dialog has no OK button, Cancel button and cannot be closed. The selected node in the system tree is not a Data Center Node, but it was converted into a Data Center Node in the codes. So the codes generated a exception and could not reach the codes that add buttons. This patch fixed the problem. Change-Id: I33802bc7d3a703e6b15b7674a8255a50cf34e4f0 Bug-Url: https://bugzilla.redhat.com/1079180 Signed-off-by: Ma Like <like.ma(a)cs2c.com.cn> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28380 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33802bc7d3a703e6b15b7674a8255a50cf34e4f0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Malike <like.ma(a)cs2c.com.cn> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Malike <like.ma(a)cs2c.com.cn> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: deleted trigger on db upgrade
by laravot＠redhat.com 03 Jul '14

03 Jul '14

Liron Aravot has submitted this change and it was merged. Change subject: core: deleted trigger on db upgrade ...................................................................... core: deleted trigger on db upgrade The upgrade script 03_05_0730_drop_disk_image_dynamic_fk.sql replaces the use of a cascade delete of a foregin key with a trigger. When performing a further update to the db, the functions are being deleted with CASCADE, which will cause the trigger and the function to be deleted and never be added again. The quick solution is to move the trigger/function creation to disk_image_dynamic_sp as we currently don't have any trigger creation infrastructure after update is performed. Upgrade script is provided as well to perform cleanup of orphand records that might have been left in disk_image_dynamic. Change-Id: I594cddb968795a5a6a0d04e2c6bed9002c025ef9 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M packaging/dbscripts/disk_image_dynamic_sp.sql A packaging/dbscripts/upgrade/03_05_0750_delete_orphand_disk_image_dynamic_records.sql 2 files changed, 16 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/29547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I594cddb968795a5a6a0d04e2c6bed9002c025ef9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: Enhance to multi line list box for discovered hosts info
by oourfali＠redhat.com 03 Jul '14

03 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: ui: Enhance to multi line list box for discovered hosts info ...................................................................... ui: Enhance to multi line list box for discovered hosts info Adding host group, discovered host and compute resource informations to multi line list box using ListModelTypeAheadListBoxEditor. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1109543 Change-Id: I3013e6c27f214c92acd50f1867ae84e2e25fcf75 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanComputerResource.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanDiscoveredHost.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostGroup.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalComputeResource.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalDiscoveredHost.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalHostGroup.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 9 files changed, 147 insertions(+), 27 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Yaniv Bronhaim: Verified Vojtech Szocs: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3013e6c27f214c92acd50f1867ae84e2e25fcf75 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: RetrieveImageData headers - use range instead of size
by laravot＠redhat.com 03 Jul '14

03 Jul '14

Liron Aravot has submitted this change and it was merged. Change subject: core: RetrieveImageData headers - use range instead of size ...................................................................... core: RetrieveImageData headers - use range instead of size On patch http://gerrit.ovirt.org/#/c/28465/ the Size header is being replaced with the standart Range header in GET requests for downloading image data - this patch changes the engine to use the Range header as well. Change-Id: Ie15ad8b48c24d3983ae352f719267356eea16572 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/RetrieveImageDataVDSCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/29481 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie15ad8b48c24d3983ae352f719267356eea16572 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0