- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Change how Affinity behaves if the assumptions are inv...
by dfediuck＠redhat.com 28 May '14

28 May '14

Doron Fediuck has submitted this change and it was merged. Change subject: core: Change how Affinity behaves if the assumptions are invalid ...................................................................... core: Change how Affinity behaves if the assumptions are invalid This fixes the situation when VMs belonging to the same hard constraint positive affinity group are actually running on more than one host. It used to fail the scheduling task for any VM belonging to the same affinity group (both new VMs and migrating ones). This patch just passes all hosts with VM from that group to the weighting mechanism making it possible for the balancer or administrator to recover from this situation. This change also makes it easier to report per host scheduling information which we need for the following patches. Change-Id: I506bcb6e96c622694e6bf7b8ce7a0f54a82e5713 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1080521 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityFilterPolicyUnit.java 1 file changed, 43 insertions(+), 48 deletions(-) Approvals: Martin Sivák: Verified Jiří Moskovčák: Looks good to me, but someone else must approve Doron Fediuck: Looks good to me, approved Kobi Ianko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I506bcb6e96c622694e6bf7b8ce7a0f54a82e5713 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: support custom preview snapshot
by derez＠redhat.com 28 May '14

28 May '14

Daniel Erez has submitted this change and it was merged. Change subject: restapi: support custom preview snapshot ...................................................................... restapi: support custom preview snapshot Accept optional 'restore_memory' and 'disks' tags in preview_snapshot action. Preview Snapshot: POST /api/vms/{vm_id}/preview_snapshot <action> <snapshot id="{snapshot_id}"/> <restore_memory>true|false</restore_memory> <disks> <disk id="{disk_id}"> <image_id>{image_id}</image_id> <snapshot id="{snapshot_id}"/> </disk> </disks> </action> Feature-Page: http://www.ovirt.org/Features/Single_Disk_Snapshot#REST-API Change-Id: I89d004dec75aa23c6a7105ddb064e93d7f4652ed Bug-Url: https://bugzilla.redhat.com/1095494 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java 3 files changed, 8 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28086 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89d004dec75aa23c6a7105ddb064e93d7f4652ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Wait before clearing gluster tasks
by ofrenkel＠redhat.com 28 May '14

28 May '14

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Wait before clearing gluster tasks ...................................................................... engine: Wait before clearing gluster tasks Introduced a wait time before clearing any orphan gluster tasks to take care of possible race condition in returning task list from gluster CLI Change-Id: I3a8a4878abb7ef46adedfdb099404884419f89de Bug-Url: https://bugzilla.redhat.com/1065227 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJobTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 4 files changed, 37 insertions(+), 11 deletions(-) Approvals: Sahina Bose: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a8a4878abb7ef46adedfdb099404884419f89de Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: simplify CommonVmPoolWithVmsCommand#executeCommand
by ofrenkel＠redhat.com 28 May '14

28 May '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: simplify CommonVmPoolWithVmsCommand#executeCommand ...................................................................... core: simplify CommonVmPoolWithVmsCommand#executeCommand The method CommonVmPoolWithVmsCommand#executeCommand was too long with a lot of responsibilities inside. This patch extracts the name generation for the VMs and the creation of the parameters for AddVmAndAttachToPool to separate methods. In addition, we are now taking the pool's name from the VmPool object in the parameters class as we should do, and not from the VM object. Change-Id: I10b7bd20780f734cbe7c9b7c102b2e5442a722ac Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NameForVmInPoolGenerator.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NameForVmInPoolGeneratorTest.java 3 files changed, 83 insertions(+), 45 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/26363 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10b7bd20780f734cbe7c9b7c102b2e5442a722ac Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: warning on move disks from file to block
by derez＠redhat.com 28 May '14

28 May '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: warning on move disks from file to block ...................................................................... webadmin: warning on move disks from file to block Moving raw/thin disks that reside on a file domain to a block domain will cause them to become preallocated. Hence, it may consume considerably more space on the target domain. To warn the user, added an appropriate message to the move disks dialog. Screenshot - http://i.imgur.com/gyMwXy9.jpg Change-Id: I08fb316c76a9132467d26bbc5305a30a9883d38e Bug-Url: https://bugzilla.redhat.com/1099083 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelTextAreaLabel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MoveDiskModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/DisksAllocationPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/DisksAllocationPopupView.ui.xml 6 files changed, 153 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08fb316c76a9132467d26bbc5305a30a9883d38e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: extract PrepareSnapshotConfig method to ImagesHandler
by derez＠redhat.com 28 May '14

28 May '14

Daniel Erez has submitted this change and it was merged. Change subject: core: extract PrepareSnapshotConfig method to ImagesHandler ...................................................................... core: extract PrepareSnapshotConfig method to ImagesHandler Extracted PrepareSnapshotConfigWithoutImageSingleImage from BaseImagesCommand into ImagesHandler for reusability in other commands. Change-Id: I8c5e8d2763df3bcf18fb13a030148de352f57846 Bug-Url: https://bugzilla.redhat.com/1056935 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveImageCommandTest.java 5 files changed, 50 insertions(+), 50 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27610 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c5e8d2763df3bcf18fb13a030148de352f57846 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[master]: readme.dialog: fixed typo and improved CLI section
by Alon Bar-Lev 28 May '14

28 May '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: readme.dialog: fixed typo and improved CLI section ...................................................................... readme.dialog: fixed typo and improved CLI section Added info how to prompt command line interface. Change-Id: I19922b07813604d97797eb8351351597b2c69e72 Signed-off-by: Lukas Bednar <lbednar(a)redhat.com> --- M README.dialog 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28167 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19922b07813604d97797eb8351351597b2c69e72 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Lukas Bednar <lbednar(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: VM dialog - organize resource allocation section
by derez＠redhat.com 28 May '14

28 May '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: VM dialog - organize resource allocation section ...................................................................... webadmin: VM dialog - organize resource allocation section VM dialog -> Resource Allocation: To improve tab display, added 'Disks Allocation' section which contains disks related widgets: - Disks table. - VirtIO-SCSI checkbox. Screenshot: http://i.imgur.com/J5TypMQ.jpg Change-Id: Ic16354dcfc7cc50a8e1969b54e0ca32722e54e8f Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml 2 files changed, 23 insertions(+), 26 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic16354dcfc7cc50a8e1969b54e0ca32722e54e8f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: disable format selection on thin provisioning
by derez＠redhat.com 28 May '14

28 May '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: disable format selection on thin provisioning ...................................................................... webadmin: disable format selection on thin provisioning VM dialog -> resource allocation: disk format should be unchangeable when storage thin provisioning is selected (changing format is applicable only on clone template provisioning). Change-Id: I6b270bb753bcceb4c085db79e413cf9ed3bc04e3 Bug-Url: https://bugzilla.redhat.com/1101003 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/28079 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b270bb753bcceb4c085db79e413cf9ed3bc04e3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: custom preview dialog - close on success
by derez＠redhat.com 28 May '14

28 May '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: custom preview dialog - close on success ...................................................................... webadmin: custom preview dialog - close on success Custom preview dialog: close dialog only on return value success; i.e. keep dialog open after canDoAction popup (to allow selection amend). Change-Id: I7c35c03bd1fdd7b8b2a46c7ff7596d344ab729e0 Related-To: https://bugzilla.redhat.com/1096884 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27818 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c35c03bd1fdd7b8b2a46c7ff7596d344ab729e0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0