- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Support ; current on cdroms collection
by juan.hernandez＠redhat.com 22 May '14

22 May '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Support ;current on cdroms collection ...................................................................... restapi: Support ;current on cdroms collection Add support for displaying current CDs (as opposed the configured) using the ;current matrix parameter on the BackendCdRomsResource. So far it was possible to get current CD only per individual VM (using BackendCdRomResource) Change-Id: Iaa14b3ceb09ab8d824fa9fae0ef3eb7d4df7f855 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1092070 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/QueryHelper.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCdRomResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCdRomsResource.java 4 files changed, 29 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/27974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa14b3ceb09ab8d824fa9fae0ef3eb7d4df7f855 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin:Removed console tab from new/edit cluster popup in ...
by kmayilsa＠redhat.com 22 May '14

22 May '14

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin:Removed console tab from new/edit cluster popup in gluster only mode ...................................................................... webadmin:Removed console tab from new/edit cluster popup in gluster only mode Console side tab in new/edit cluster dialog to configure a SPICE proxy for individual clusters is removed from Gluster only mode. Change-Id: I00a7fa05b42180d3b582bd7d1374d40b3de8e72f Bug-Url: https://bugzilla.redhat.com/1096665 Signed-off-by: Karnan <kchidamb(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Karnan t c: Verified anmolbabu: Looks good to me, but someone else must approve Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27927 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00a7fa05b42180d3b582bd7d1374d40b3de8e72f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Karnan t c <kchidamb(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Karnan t c <kchidamb(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: [RFE] Restart HA VMs ASAP
by emesika＠redhat.com 22 May '14

22 May '14

Eli Mesika has submitted this change and it was merged. Change subject: core: [RFE] Restart HA VMs ASAP ...................................................................... core: [RFE] Restart HA VMs ASAP [RFE] Restart HA VMs when power management reports host is in powered off state This patch changes the following flows 1) soft-fencing : if Host has PM configured, check host status and if it is off , skip soft-fencing and put host status to DOWN 2) Restart : if Host has PM configured, check host status and if it is off , skip the stop command and put host status to DOWN The result of that is a faster HA VMs release on the fenced host and restart on another host saving us unnecessary retries and wait time. Change-Id: Iaca0111d13a625014fb424bdccd3709b8ea03382 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1058737 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java 3 files changed, 79 insertions(+), 17 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27985 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaca0111d13a625014fb424bdccd3709b8ea03382 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Validate action links are terminated properly
by juan.hernandez＠redhat.com 22 May '14

22 May '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Validate action links are terminated properly ...................................................................... restapi: Validate action links are terminated properly Due to code generator limitations, the action links are not allowed to be terminated by "/". The patch provides the validation for it. Signed-off-by: Moti Asayag <masayag(a)redhat.com> Change-Id: I22e52348e3ecc95599907fb04f6ec63fdc2b07b0 --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlManager.java 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/27984 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22e52348e3ecc95599907fb04f6ec63fdc2b07b0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster:Hide skipped file count in remove brick status
by kmayilsa＠redhat.com 22 May '14

22 May '14

Kanagaraj M has submitted this change and it was merged. Change subject: gluster:Hide skipped file count in remove brick status ...................................................................... gluster:Hide skipped file count in remove brick status Skipped file count will be always zero in remove brick status and it can be removed from remove-brick status dialog. Change-Id: Iefaea9d3bfab34e405386e70f18277b488c10cc2 Bug-Url: https://bugzilla.redhat.com/1064712 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/RemoveBrickStatusPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java 2 files changed, 16 insertions(+), 6 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit http://gerrit.ovirt.org/27928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefaea9d3bfab34e405386e70f18277b488c10cc2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Consolidating DiskValidator's RO validations
by amureini＠redhat.com 21 May '14

21 May '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Consolidating DiskValidator's RO validations ...................................................................... core: Consolidating DiskValidator's RO validations In DiskValidator: isReadOnlyPropertyCompatibleWithLunInterface() was consolidated into isReadOnlyPropertyCompatibleWithInterface(). Amended all existing tests in validator and related commands, Added missing tests. Some related tests did not follow unit-tests conventions and are now corrected. Validator class in now the only one to test validator inner flow. Other tests (commands) rely on expected input and should generate the expected result according to that input. The above note only applies to isReadOnlyPropertyCompatibleWithInterface() usages. Change-Id: I292f729c981df6563ec65d684e1b2b5ae12283a0 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AttachDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 13 files changed, 300 insertions(+), 100 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I292f729c981df6563ec65d684e1b2b5ae12283a0 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix comment
by amureini＠redhat.com 21 May '14

21 May '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix comment ...................................................................... core: Fix comment Comment refers to AddVmFromTemlateCommand. Replaced "Create" with "Add" in order to avoid confusion. Change-Id: I419ae0231e9fda1f8a59766876271fbee1c2c8ed Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/26744 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I419ae0231e9fda1f8a59766876271fbee1c2c8ed Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix typo
by ahadas＠redhat.com 21 May '14

21 May '14

Arik Hadas has submitted this change and it was merged. Change subject: core: fix typo ...................................................................... core: fix typo s/separete/separate Change-Id: I92ddda877689209c2f4612de6a66f7177798efb7 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmUpdatesOnNextRunExistsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmUpdatesOnNextRunExistsQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/customprop/VmPropertiesUtils.java 5 files changed, 8 insertions(+), 8 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92ddda877689209c2f4612de6a66f7177798efb7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: extmgr: use extension class loader when calling extension
by yzaslavs＠redhat.com 21 May '14

21 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: extmgr: use extension class loader when calling extension ...................................................................... extmgr: use extension class loader when calling extension currently the context class loader is set to the jboss module that is at top level. this does not allow the extension to use extra dependencies it may have in its module.xml. to solve this we set the context class loader of the extension module before calling the extension, in this case the extension finds all its dependencies. Change-Id: I38031776f1d740da8f8f07f0d4a52b640534bcff Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/Base.java M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionProxy.java M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java 3 files changed, 63 insertions(+), 49 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38031776f1d740da8f8f07f0d4a52b640534bcff Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: Changes to ExtensionsManager
by yzaslavs＠redhat.com 21 May '14

21 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Changes to ExtensionsManager ...................................................................... aaa: Changes to ExtensionsManager The following changes are introduced: 1. ExtensionsManager is no longer singleton. 2. For engine related modules - EngineExtensionsManager is a singleton wrapper. that also initilizes ExtensionsManager with the proper application name. 3. Splitting load to loading the extension and activating it. Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1 topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/aaa/pom.xml M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java M backend/manager/modules/aaa/src/main/modules/org/ovirt/engine/core/aaa/main/module.xml M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java M backend/manager/modules/builtin-extensions/exclude-filters.xml M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthn.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthz.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthn.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/Base.java M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionProxy.java M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java M backend/manager/modules/extensions-manager/src/main/modules/org/ovirt/engine/core/extensions-manager/main/module.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/logger/src/main/java/org/ovirt/engine/core/logger/LoggerHandler.java M backend/manager/modules/logger/src/main/modules/org/ovirt/engine/core/logger/main/module.xml M backend/manager/modules/pom.xml M backend/manager/modules/utils/pom.xml A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java M backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml 21 files changed, 453 insertions(+), 332 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1 Gerrit-PatchSet: 37 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0