- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: remove duplicated custom properties handling
by ahadas＠redhat.com 21 May '14

21 May '14

Arik Hadas has submitted this change and it was merged. Change subject: core: remove duplicated custom properties handling ...................................................................... core: remove duplicated custom properties handling The logic of extracting the predefined and user properties from VM custom properties was duplicated in some places. This patch keep only the one which is located in VmPropertiesUtils and change the other places to use it. Change-Id: I4c37a001985da09cbb7e3f78db1e419901d532cf Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 2 files changed, 10 insertions(+), 25 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/27883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c37a001985da09cbb7e3f78db1e419901d532cf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: extapi: switch sensitive scalar with flags mask, add non pri...
by yzaslavs＠redhat.com 21 May '14

21 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: extapi: switch sensitive scalar with flags mask, add non printable ...................................................................... extapi: switch sensitive scalar with flags mask, add non printable there is a case of loops within the map especially when global context and the context points to each other. add a flag to skip dump of keys. Change-Id: I9f9204d2b44af052196b0be0c4ad4ef3727c0768 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/Base.java M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtKey.java M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtMap.java M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authn.java 4 files changed, 29 insertions(+), 22 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f9204d2b44af052196b0be0c4ad4ef3727c0768 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: adding labels column to Network->Hosts sub-tab
by alkaplan＠redhat.com 21 May '14

21 May '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: adding labels column to Network->Hosts sub-tab ...................................................................... webadmin: adding labels column to Network->Hosts sub-tab Adding a tag image to the device name column if the network is attacehd via label. Change-Id: I610703df29dcae7ace390e0ebb109475fb202263 Bug-Url: https://bugzilla.redhat.com/1063797 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/SafeHtmlWithSafeHtmlTooltipColumn.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java 5 files changed, 89 insertions(+), 25 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24992 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I610703df29dcae7ace390e0ebb109475fb202263 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-live[master]: build: ovirt-live 3.5.0-alpha
by sbonazzo＠redhat.com 21 May '14

21 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live 3.5.0-alpha ...................................................................... build: ovirt-live 3.5.0-alpha Change-Id: I92eee2e621be35b2cd601a035ac672f4b28b8f82 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile M centos/kickstart/ovirt-live-base.ks.in 2 files changed, 4 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve Ohad Basan: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27960 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92eee2e621be35b2cd601a035ac672f4b28b8f82 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: No trailing / in network labels metadata
by juan.hernandez＠redhat.com 21 May '14

21 May '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: No trailing / in network labels metadata ...................................................................... restapi: No trailing / in network labels metadata The RSDL metadata that describes the operations to add network labels contains an extra slash at the end of the URL. This makes the RSDL generator ignore the URL. As a result the RSDL documentation doesn't contains the headers, and the SDKs are generated incorrectly. Change-Id: I88781dad71e9dca372de6a84c5c2eb3c8d36c21f Bug-Url: https://bugzilla.redhat.com/1099415 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27946 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88781dad71e9dca372de6a84c5c2eb3c8d36c21f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: rename upgrade script
by mlipchuk＠redhat.com 21 May '14

21 May '14

Maor Lipchuk has submitted this change and it was merged. Change subject: engine: rename upgrade script ...................................................................... engine: rename upgrade script Change-Id: Ic1ce90bebe53e4554a2c6024b56aa6ff769f58f6 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- R packaging/dbscripts/upgrade/03_05_0480_add_org_name_for_sysprep.sql 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1ce90bebe53e4554a2c6024b56aa6ff769f58f6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Repair disallow RO in UI
by oourfali＠redhat.com 21 May '14

21 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Repair disallow RO in UI ...................................................................... webadmin: Repair disallow RO in UI Qemu currently does not support direct-LUN disks connected using VirtIO-SCSI. This patch blocks this option from UI when adding/editing/attaching a direct-LUN disk with VirtIO-SCSI interface to a VM. This wasn't checked in Add/Edit Disk to Vm dialog, nor in Attach table. IDE behaviour was changed to comply with this behaviour in this patch as well. This patch also removes un-needed verfication for IDE disk. Change-Id: Ieb1923d03785be7f228076e12f4865242aed5c90 Bug-Url: https://bugzilla.redhat.com/1097754 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 3 files changed, 21 insertions(+), 21 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/27958 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb1923d03785be7f228076e12f4865242aed5c90 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Fix potential NPE when in CheckboxColumn
by oourfali＠redhat.com 21 May '14

21 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Fix potential NPE when in CheckboxColumn ...................................................................... webadmin: Fix potential NPE when in CheckboxColumn getValue(object)) in checkboxColumn.render() might return null, resulting in an NPE when used in if. Fix the if to handle null. Note: this bug could only occur if a checkboxColumn is not editable *and* it's value is null. Change-Id: I26f688984083fbd6964972e79e50960b254c547b Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1097754 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/CheckboxColumn.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/27957 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26f688984083fbd6964972e79e50960b254c547b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: resetapi: root password return via GetVmsInitQuery
by shavivi＠redhat.com 21 May '14

21 May '14

Shahar Havivi has submitted this change and it was merged. Change subject: resetapi: root password return via GetVmsInitQuery ...................................................................... resetapi: root password return via GetVmsInitQuery No need to return the password only indicate that the password is set in DataBase Change-Id: I97aa160a00d2777dfd4eafa45f21a9f5d7c4ef4b Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsInitQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 3 files changed, 17 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27675 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97aa160a00d2777dfd4eafa45f21a9f5d7c4ef4b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Engine: add Admin password and OrgName for Sysprep
by shavivi＠redhat.com 21 May '14

21 May '14

Shahar Havivi has submitted this change and it was merged. Change subject: Engine: add Admin password and OrgName for Sysprep ...................................................................... Engine: add Admin password and OrgName for Sysprep Changes: DB: added org_name column to vm_init table restapi: added org_name field to initialization element UI: Sysprep two new fields: admin-password, organization-name engine: set Sysprep appropriate values for admin-password and organization-name Change-Id: Ie33cce7b395ba8e7e7a46bc31a7564410f808888 https://bugzilla.redhat.com/1025831 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmInit.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmInitDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/MatchFieldsValidator.java A packaging/dbscripts/upgrade/03_05_0470_add_org_name_for_sysprep.sql M packaging/dbscripts/vms_sp.sql 13 files changed, 343 insertions(+), 101 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie33cce7b395ba8e7e7a46bc31a7564410f808888 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0