- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: add time tolerance to websocket proxy
by sbonazzo＠redhat.com 15 May '14

15 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: core: add time tolerance to websocket proxy ...................................................................... core: add time tolerance to websocket proxy This small patch adds 5 second tolerance to the past in ovirt-websocket-proxy. This is to prevent really small time drifts between clocks of the engine and the machine where the proxy is deployed in situations when the proxy clock is ahead of the engine clock (and therefore the ticket is not yet valid from the proxy POV). Change-Id: I811f6c3c4413576c1dc8d209408767367b3687ad Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1052921 --- M packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/27643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I811f6c3c4413576c1dc8d209408767367b3687ad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: utils: return an unmodifiable map for ShellLikeConfd.getProp...
by oourfali＠redhat.com 15 May '14

15 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: utils: return an unmodifiable map for ShellLikeConfd.getProperties() ...................................................................... utils: return an unmodifiable map for ShellLikeConfd.getProperties() Without wrapping users can unexpectedly change internal values after calling getProperties(). Change-Id: I33c5e05b5e433634575285e19b435127dd0ae968 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/config/ShellLikeConfd.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33c5e05b5e433634575285e19b435127dd0ae968 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fixed header position in Hosts > Network subtab
by alkaplan＠redhat.com 15 May '14

15 May '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: fixed header position in Hosts > Network subtab ...................................................................... webadmin: fixed header position in Hosts > Network subtab PatternFly patch caused the header to be badly positioned in Hosts > Network Interfaces subtab, only in Firefox. It was a div clear issue. Fixed. Change-Id: I1db1830a203cb8c4ebb3b6d7c140676213506b35 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.ui.xml 1 file changed, 101 insertions(+), 97 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/27710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1db1830a203cb8c4ebb3b6d7c140676213506b35 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: fix coverity issues
by yzaslavs＠redhat.com 15 May '14

15 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: fix coverity issues ...................................................................... aaa: fix coverity issues Change-Id: I057929e0f2dc7672bc5d06457d14c548f4726112 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/Domain.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/SimpleLdapTemplateWrapper.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/RootDSEData.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/DetectMixedMode.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KrbConfCreator.java 7 files changed, 99 insertions(+), 88 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27397 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I057929e0f2dc7672bc5d06457d14c548f4726112 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: Fix ExtMap.get with default value
by yzaslavs＠redhat.com 15 May '14

15 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Fix ExtMap.get with default value ...................................................................... aaa: Fix ExtMap.get with default value The implementation before the fix failed to support a case where the default value was a subclass of the type associated with the ExtKey Change-Id: Ib9d04c4650ff0a01866ffd7edf2cce6801d422a1 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtMap.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27660 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9d04c4650ff0a01866ffd7edf2cce6801d422a1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: history: modified 03_05_0020 upgrade file
by ydary＠redhat.com 15 May '14

15 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: history: modified 03_05_0020 upgrade file ...................................................................... history: modified 03_05_0020 upgrade file In relation to the retroactive update of user and system cpu usage percent, according to the number of cpus of the vm. I removed the bug url comment from the upgrade file so it will be identical to the upgrade file for 3.4. Change-Id: If8230763deb0e69a39425b410bbdbaef191f782e Bug-Url: https://bugzilla.redhat.com/1078897 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/dbscripts/upgrade/03_05_0020_update_cpu_usage_percent.sql 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8230763deb0e69a39425b410bbdbaef191f782e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add Venezuela time zone
by ofrenkel＠redhat.com 15 May '14

15 May '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: add Venezuela time zone ...................................................................... core: add Venezuela time zone Change-Id: Ia536ba0adc91b371be695dff4b15fd47d7c784f9 Bug-Url: https://bugzilla.redhat.com/1088568 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/TimeZoneType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/27250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia536ba0adc91b371be695dff4b15fd47d7c784f9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: minor instance type correction
by tjelinek＠redhat.com 15 May '14

15 May '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: minor instance type correction ...................................................................... frontend: minor instance type correction Previously when changing display type on entity, InstanceTypeManager prevented the change to happen. This patch removes deactivating and activating instance type manager when display type of entity changes which caused this problem. Change-Id: I85f2301e12b194c8373d7f531e077e52d49b9d02 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java 2 files changed, 2 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/27717 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85f2301e12b194c8373d7f531e077e52d49b9d02 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Update the version of the deploy plugin
by yzaslavs＠redhat.com 15 May '14

15 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Update the version of the deploy plugin ...................................................................... core: Update the version of the deploy plugin The version used by default doesn't support the "altReleaseDeploymentRepository" and "altSnapshotDeployment" configuration parameters that are convenient in order to deploy to alternative respositories without changing the POMs. This patch updats the version to 2.8.1. Change-Id: Ib19fd5d443531623ecf17329f8e6a0cce9f9b920 Related: https://bugzilla.redhat.com/1069196 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/extensions-api-root/pom.xml M pom.xml 2 files changed, 8 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib19fd5d443531623ecf17329f8e6a0cce9f9b920 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: storage_domains_with_hosts_view generate slow query
by oourfali＠redhat.com 15 May '14

15 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: storage_domains_with_hosts_view generate slow query ...................................................................... core: storage_domains_with_hosts_view generate slow query When using the Host tab on the StorageDomain, a very slow query is generated. The following is a comparison of before/after from a scale environment: SELECT count(*) FROM vds WHERE ( vds_id IN (select vds_id from storage_domains_with_hosts_view WHERE storage_domains_with_hosts_view.storage_name LIKE 'storage_real')); count ------- 39 (1 row) Time: 7347.615 ms SELECT count(*) FROM vds WHERE ( storage_pool_id IN (select storage_pool_id from storage_domains WHERE storage_domains.storage_name LIKE 'storage_real')); count ------- 39 (1 row) Time: 528.767 ms Change-Id: Iab5887ea432de78776340da87ee873733bec7d15 Bug-Url: https://bugzilla.redhat.com/1097160 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/27634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab5887ea432de78776340da87ee873733bec7d15 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0