- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Mark management network as display and migration
by lvernia＠redhat.com 18 May '14

18 May '14

Lior Vernia has submitted this change and it was merged. Change subject: core: Mark management network as display and migration ...................................................................... core: Mark management network as display and migration Introducing an upgrade script to mark the management network as display and/or migration, if no other network in the cluster has that role. This is implicitly the case anyway because when these roles haven't been assigned they fall back to the management network, this makes it explicit. Also added code to assign the roles to the management network when another network loses the role, or when a new cluster is created. Change-Id: I73bf3c583ae28bf32d7c602ec9f4b0fb5c7f391d Bug-Url: https://bugzilla.redhat.com/1023722 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkOnClusterCommand.java A packaging/dbscripts/upgrade/03_05_0460_set_display_migration_cluster_network.sql 5 files changed, 61 insertions(+), 8 deletions(-) Approvals: oVirt Jenkins CI Server: Looks good to me, but someone else must approve Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73bf3c583ae28bf32d7c602ec9f4b0fb5c7f391d Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Maintain lowercase mac addresses
by masayag＠redhat.com 18 May '14

18 May '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Maintain lowercase mac addresses ...................................................................... engine: Maintain lowercase mac addresses The mac addresses used to be stored in lowercase. This patch preserves that old behaviour. Change-Id: Ia2fb0ce1baed6882381065a2cd3eec58ce60302a Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MacAddressRangeUtilsTest.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Martin Mucha: Looks good to me, but someone else must approve Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/27707 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2fb0ce1baed6882381065a2cd3eec58ce60302a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: history: Fixed sleep time for delete/aggregations
by ydary＠redhat.com 18 May '14

18 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: history: Fixed sleep time for delete/aggregations ...................................................................... history: Fixed sleep time for delete/aggregations Fixed sleep time for interations of DeleteTimeKeepingJob,HourlyTimeKeepingJob and DailyTimeKeepingJob so it will run at the correct time. Change-Id: I1a1a05400812b41fa70bf618c03afb72a606f525 Bug-Url: https://bugzilla.redhat.com/1086389 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M etl_export/src/ovirt_engine_dwh/dailytimekeepingjob_3_5/DailyTimeKeepingJob.java M etl_export/src/ovirt_engine_dwh/deletetimekeepingjob_3_5/DeleteTimeKeepingJob.java M etl_export/src/ovirt_engine_dwh/hourlytimekeepingjob_3_5/HourlyTimeKeepingJob.java M tos_project/process/DailyTimeKeepingJob_3.5.item M tos_project/process/DailyTimeKeepingJob_3.5.properties M tos_project/process/DeleteTimeKeepingJob_3.5.item M tos_project/process/DeleteTimeKeepingJob_3.5.properties M tos_project/process/HourlyTimeKeepingJob_3.5.item M tos_project/process/HourlyTimeKeepingJob_3.5.properties 9 files changed, 2,054 insertions(+), 311 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a1a05400812b41fa70bf618c03afb72a606f525 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[node-3.0]: engine_page: replace netinfo to xmlrpc
by dougsland＠redhat.com 18 May '14

18 May '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: replace netinfo to xmlrpc ...................................................................... engine_page: replace netinfo to xmlrpc Currently ovirt-node-plugin-vdsm uses vdsm netinfo module to consult data. However, if for some reason the connection between vdsm and libvirt is not available vdsm kills the caller. This patch will replace the uses of netinfo to use xmlrpc via vdscli module. Change-Id: I2a1243342a5f46861940dda353798e3413587969 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1097645 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 19 insertions(+), 8 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27788 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a1243342a5f46861940dda353798e3413587969 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: node-3.0 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[master]: engine_page: replace netinfo to xmlrpc
by dougsland＠redhat.com 18 May '14

18 May '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: replace netinfo to xmlrpc ...................................................................... engine_page: replace netinfo to xmlrpc Currently ovirt-node-plugin-vdsm uses vdsm netinfo module to consult data. However, if for some reason the connection between vdsm and libvirt is not available vdsm kills the caller. This patch will replace the uses of netinfo to use xmlrpc via vdscli module. Change-Id: I2a1243342a5f46861940dda353798e3413587969 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1097645 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 19 insertions(+), 8 deletions(-) Approvals: Fabian Deutsch: Looks good to me, but someone else must approve Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27779 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a1243342a5f46861940dda353798e3413587969 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core : Allow redirection of all logs using extension
by yzaslavs＠redhat.com 17 May '14

17 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core : Allow redirection of all logs using extension ...................................................................... core : Allow redirection of all logs using extension A custom handler in a new module org.ovirt.engine.core.logger handles all logging using extensions. Change-Id: Ia0dae8ffe53c3489af06d6684c72e6b431002404 Bug-Url: https://bugzilla.redhat.com/1078738 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- A backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/logger/Logger.java A backend/manager/modules/logger/pom.xml A backend/manager/modules/logger/src/main/java/org/ovirt/engine/core/logger/LoggerHandler.java A backend/manager/modules/logger/src/main/modules/org/ovirt/engine/core/logger/main/module.xml M backend/manager/modules/pom.xml M packaging/services/ovirt-engine/ovirt-engine.xml.in 6 files changed, 177 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Ravi Nori: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0dae8ffe53c3489af06d6684c72e6b431002404 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: GetHostListFromExternalProvider test asserts
by amureini＠redhat.com 17 May '14

17 May '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetHostListFromExternalProvider test asserts ...................................................................... core: GetHostListFromExternalProvider test asserts Use proper JUnit assertEquals statements instead of Java's asserts. Change-Id: I3a542ca5cb806a931f4606312932d2de22cbf4cf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetHostListFromExternalProviderQueryTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a542ca5cb806a931f4606312932d2de22cbf4cf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: ActionGroupDAOTest#testRemoveActionVersionMap
by amureini＠redhat.com 17 May '14

17 May '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: ActionGroupDAOTest#testRemoveActionVersionMap ...................................................................... core: ActionGroupDAOTest#testRemoveActionVersionMap The current implementation of this test removes existingActionMap from the database. Since there is no rollback performed between tests, and since other tests in this class assume this object will be present in the database, this implementation caused sporadic failures on various environments [1], depending on the order the tests were executed. This patch rewrites the test to be safer. It now creates a dummy record in the table, inserts it (and asserts it was indeed inserted), and then removes it (again, asserting it was properly removed). [1] Details of the system where a failure was spotted: Apache Maven 3.0.4 (r1232337; 2012-01-17 10:44:56+0200) Maven home: /usr/local/apache-maven-3.0.4 Java version: 1.7.0_51, vendor: Oracle Corporation Java home: /usr/lib/jvm/java-1.7.0-openjdk-1.7.0.51.x86_64/jre Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "2.6.32-431.11.2.el6.x86_64", arch: "amd64", family: "unix" Change-Id: Icba824009bec7763c38b3040eb9b1be88558f037 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ActionGroupDAOTest.java 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icba824009bec7763c38b3040eb9b1be88558f037 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: extapi: add extension notes field
by yzaslavs＠redhat.com 17 May '14

17 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: extapi: add extension notes field ...................................................................... extapi: add extension notes field extra information extension would like to present, such as display version, build options. Change-Id: I2d061a08531849b5d85af9c8e403f73f89497304 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/Base.java M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java 2 files changed, 9 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d061a08531849b5d85af9c8e403f73f89497304 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-release[master]: packaging: fix conflicts with ovirt-release34
by sbonazzo＠redhat.com 16 May '14

16 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: fix conflicts with ovirt-release34 ...................................................................... packaging: fix conflicts with ovirt-release34 fixes file /etc/pki/rpm-gpg/RPM-GPG-ovirt from install of ovirt-release35-001-0.0.alpha1.noarch conflicts with file from package ovirt-release34-1.0.0-1.noarch Change-Id: I0b07bd273b9dc88224d4582e3d9c976230ce0c73 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-release-3.5/ovirt-release35.spec.in M ovirt-release-3.5/ovirt.repo.in 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve David Caro: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b07bd273b9dc88224d4582e3d9c976230ce0c73 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0