- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: fixed right-click context menu spacing
by awels＠redhat.com 16 May '14

16 May '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fixed right-click context menu spacing ...................................................................... webadmin: fixed right-click context menu spacing PatternFly patch caused the right-click context menu spacing to be 2 pixels too much. Fixed. Change-Id: I69b9d04fb18fa77ce3760ce6ca97c45dd6638bbb Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/public/WebAdmin.css 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/27761 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69b9d04fb18fa77ce3760ce6ca97c45dd6638bbb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: fixed misc broken spacings
by awels＠redhat.com 16 May '14

16 May '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fixed misc broken spacings ...................................................................... webadmin: fixed misc broken spacings PatternFly introduced border-box model which breaks hardcoded cell spacings and paddings. Added some css classes to fix, and changed attributes and method calls for spacings and paddings to use the css classes. Change-Id: Ifdf31a1ffe7698c08e9fbfc008c75ae9c03ecc56 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/GlusterHookResolveConflictsPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/MultipleHostsPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/BondPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkGroup.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkLabelPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NicPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/UnassignedNetworksPanel.java M packaging/branding/ovirt.brand/patternfly-custom-hacks.css 10 files changed, 49 insertions(+), 18 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27744 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdf31a1ffe7698c08e9fbfc008c75ae9c03ecc56 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fixed contrast issue in search bar prefix label
by awels＠redhat.com 16 May '14

16 May '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fixed contrast issue in search bar prefix label ...................................................................... webadmin: fixed contrast issue in search bar prefix label PatternFly update introduced a change to the search bar, and the prefix label was hard to read because it was gray on gray. This updates that label to be black text in a light gray box, which is much easier to read. Change-Id: I50cc91a5943f350291b5e1d8938a0912dbe30a7b Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/SearchPanelView.ui.xml M packaging/branding/ovirt.brand/patternfly-custom-hacks.css 2 files changed, 23 insertions(+), 8 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/27701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50cc91a5943f350291b5e1d8938a0912dbe30a7b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-release[master]: build: ovirt-release35-001_alpha1
by sbonazzo＠redhat.com 16 May '14

16 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-release35-001_alpha1 ...................................................................... build: ovirt-release35-001_alpha1 Provide oVirt pre release repository for oVirt 3.5.0 alpha1 Change-Id: If75f973c737818a113a6e79a641c12773419af45 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M .gitignore A ovirt-release-3.5/Makefile.am A ovirt-release-3.5/RPM-GPG-ovirt A ovirt-release-3.5/autogen.sh A ovirt-release-3.5/configure.ac A ovirt-release-3.5/ovirt-el-deps.repo.in A ovirt-release-3.5/ovirt-f19-deps.repo.in A ovirt-release-3.5/ovirt-release35.spec.in A ovirt-release-3.5/ovirt.repo.in 9 files changed, 262 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve David Caro: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27755 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If75f973c737818a113a6e79a641c12773419af45 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Fixing RootDSEData bind
by yzaslavs＠redhat.com 16 May '14

16 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Fixing RootDSEData bind ...................................................................... tools: Fixing RootDSEData bind Changing the way RootDSE is obtained at manage domains to the way it is obtained at engine - Using SIMPLE bind with no credentials. Change-Id: I6b5709ba7f01eb34cfb72f271f3963e0e635f2a5 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/RootDSEData.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b5709ba7f01eb34cfb72f271f3963e0e635f2a5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: copy disks from template instead of instance type
by tjelinek＠redhat.com 16 May '14

16 May '14

Tomas Jelinek has submitted this change and it was merged. Change subject: core: copy disks from template instead of instance type ...................................................................... core: copy disks from template instead of instance type When the VM was created from both template and instance type, all the devices (including the disks) were taken from the instance type. The problem is that the disks are supposed to be taken from the template. This patch ensures that if the VM is created from an instance type, the disks are taken from the template. Change-Id: Iaddc4d3da99c0a459c7339639cca15cbb597df18 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 26 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaddc4d3da99c0a459c7339639cca15cbb597df18 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: setup: Write the answer file if file path is valid
by sbonazzo＠redhat.com 16 May '14

16 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: setup: Write the answer file if file path is valid ...................................................................... setup: Write the answer file if file path is valid Added a exception handling to make sure answer file gets written only if the file path is valid one. If the path is invalid, instead of erroring out and marking the whole setup as failed, it shows a warning and setup is marked as completed successfully. A valid use case is calling "engine-setup --generate-answer =root/engine-answer.txt". In this case the current working dir does not contain a directory with name root. In the above scenario, earlier engine setup used to display an error saying "No such file or directory: '<CurrDir>/root/ engine-answer.txt'". Also the overall engine-setup output used to report "[ ERROR ] Execution of setup failed". With the fix, now the output looks as below - [WARNING] [Errno 2] No such file or directory: '<CurrDir>/root/engine-answer.txt' and the overall engine setup reports a success as below - "[ INFO ] Execution of setup completed successfully" Change-Id: I8c595449e631f0bdb9524d74bdc3d9b1a256439f Bug-Url: https://bugzilla.redhat.com/1089067 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/base/core/answerfile.py 1 file changed, 49 insertions(+), 31 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Shubhendu Tripathi: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve Sahina Bose: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27731 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c595449e631f0bdb9524d74bdc3d9b1a256439f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add Debian 7 to the list of operating systems
by tjelinek＠redhat.com 16 May '14

16 May '14

Tomas Jelinek has submitted this change and it was merged. Change subject: core: Add Debian 7 to the list of operating systems ...................................................................... core: Add Debian 7 to the list of operating systems Added entry for Debian 7 in osinfo (deriving from Ubuntu) and two icons for userportal. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073453 Change-Id: I2f41e8ea651d900b89944c791f25e7d99d2de5e8 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationResourcesWithLookup.java A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/os/debian_7.png A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/os/large/debian_7.png M packaging/conf/osinfo-defaults.properties 4 files changed, 11 insertions(+), 0 deletions(-) Approvals: Martin Betak: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f41e8ea651d900b89944c791f25e7d99d2de5e8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Allow adding of NFS export/ISO domains to a local DC
by oourfali＠redhat.com 16 May '14

16 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Allow adding of NFS export/ISO domains to a local DC ...................................................................... webadmin: Allow adding of NFS export/ISO domains to a local DC Change-Id: I7122566506fe4b146fa8e3035c5656303a6bd9ae Bug-Url: https://bugzilla.redhat.com/1097837 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27746 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7122566506fe4b146fa8e3035c5656303a6bd9ae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: fix constant name in initOnStartup
by yzaslavs＠redhat.com 16 May '14

16 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: fix constant name in initOnStartup ...................................................................... aaa: fix constant name in initOnStartup Topic: AAA Change-Id: Iadef26d067e9b9dd29fcf845f16288815e2f0415 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iadef26d067e9b9dd29fcf845f16288815e2f0415 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0