- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Fix typo
by juan.hernandez＠redhat.com 07 May '14

07 May '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix typo ...................................................................... restapi: Fix typo Remove annotation, at first we wanted to fix to the correct annotation syntax but that would have changed the SDK API so we are removing it altogether. Change-Id: I3780ff5c186227420f62d5434f8d241c9618988e Signed-off-by: Dima Kuznetsov <dkuznets(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 2 insertions(+), 14 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27008 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3780ff5c186227420f62d5434f8d241c9618988e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4.1]: packaging: ovirt-engine-3.4.1
by sbonazzo＠redhat.com 07 May '14

07 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: ovirt-engine-3.4.1 ...................................................................... packaging: ovirt-engine-3.4.1 Change-Id: I0079a8879a6a56a2ed17dc986a7b44f84585e5d9 Bug-Url: https://bugzilla.redhat.com/1080483 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M backend/manager/dependencies/pom.xml M backend/manager/modules/authentication/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M ovirt-engine.spec.in M pom.xml M version.mak 45 files changed, 53 insertions(+), 50 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0079a8879a6a56a2ed17dc986a7b44f84585e5d9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in otopi[master]: config: warn if config append is missing
by Alon Bar-Lev 07 May '14

07 May '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: config: warn if config append is missing ...................................................................... config: warn if config append is missing Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1092397 Change-Id: Ic6ef2a2e349a46905bef7706c66103f6c9dc1380 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/otopi/core/config.py 2 files changed, 30 insertions(+), 8 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved Sandro Bonazzola: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27430 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6ef2a2e349a46905bef7706c66103f6c9dc1380 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Accept vlan devices identified by any name
by alkaplan＠redhat.com 07 May '14

07 May '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Accept vlan devices identified by any name ...................................................................... webadmin: Accept vlan devices identified by any name Vlan device name is no longer in the format baseInterface.vlanId. Vlan id and base interface name can be detemined by- vlanDevice.getVlanId(), vlanDevice.getBaseInterface(). Change-Id: Ic871fe32377e1b972315aa9c21d9e5cfabd03a03 Bug-Url: https://bugzilla.redhat.com/1091863 Bug-Url: https://bugzilla.redhat.com/999975 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java 4 files changed, 32 insertions(+), 29 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27154 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic871fe32377e1b972315aa9c21d9e5cfabd03a03 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Adjust NetworkUtils to accept any vlan device name -...
by alkaplan＠redhat.com 07 May '14

07 May '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Adjust NetworkUtils to accept any vlan device name - phase 2 ...................................................................... engine: Adjust NetworkUtils to accept any vlan device name - phase 2 This patch contains- 1. Removing from all the old methods assuming vlan device name format is baseNic.vlanId from NetworkUtils. 2. Fixing NetworkUtilsTest. The patch is the last one in a chain of patches. The previous patches fixed all the places thats used the old methods. Change-Id: I884ea51d4c7b47fef2b7fb2c89b4efd36701980c Bug-Url: https://bugzilla.redhat.com/1091863 Bug-Url: https://bugzilla.redhat.com/999975 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkUtilsTest.java 2 files changed, 17 insertions(+), 75 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Alona Kaplan: Verified -- To view, visit http://gerrit.ovirt.org/27153 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I884ea51d4c7b47fef2b7fb2c89b4efd36701980c Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: refactoring NetworkUtils.getVlanDeviceName
by alkaplan＠redhat.com 07 May '14

07 May '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: refactoring NetworkUtils.getVlanDeviceName ...................................................................... engine: refactoring NetworkUtils.getVlanDeviceName This patch changes the method name to constructVlanDeviceName. The method should be used only for constructing new vlan devices. Other places shoulded assume the vlan device name is in format- baseIface.vlanId Change-Id: I34ed8b14fb8e22d9681bdbc34d863c52b6d23be5 Bug-Url: https://bugzilla.redhat.com/1091863 Bug-Url: https://bugzilla.redhat.com/999975 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java 2 files changed, 7 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Alona Kaplan: Verified -- To view, visit http://gerrit.ovirt.org/27152 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34ed8b14fb8e22d9681bdbc34d863c52b6d23be5 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Adjust NetworkMonitoringHelper to accept any vlan de...
by alkaplan＠redhat.com 07 May '14

07 May '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Adjust NetworkMonitoringHelper to accept any vlan device name ...................................................................... engine: Adjust NetworkMonitoringHelper to accept any vlan device name Changes done in this patch- 1. Using iface.getBaseInterface() and iface.getVlanId() instead of determining this values from the vlan device name (since its format is no longer- baseIface.vlanId). 2. Using the new methods indroduced in NetworkUtils instead of the old ones (that should be removed in a following patch). Change-Id: I96c998b8575bc8d48ec482d725de3579f51a7c88 Bug-Url: https://bugzilla.redhat.com/1091863 Bug-Url: https://bugzilla.redhat.com/999975 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/NetworkMonitoringHelper.java 1 file changed, 6 insertions(+), 27 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Alona Kaplan: Verified -- To view, visit http://gerrit.ovirt.org/27151 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96c998b8575bc8d48ec482d725de3579f51a7c88 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Adjust GetVlanParentQuery to accept any vlan device ...
by alkaplan＠redhat.com 07 May '14

07 May '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Adjust GetVlanParentQuery to accept any vlan device name ...................................................................... engine: Adjust GetVlanParentQuery to accept any vlan device name Changes done in this patch- 1. Using iface.getBaseInterface() and iface.getVlanId() instead of determining this values from the vlan device name (since its format is no longer- baseIface.vlanId). 2. Using the new methods indroduced in NetworkUtils instead of the old ones (that should be removed in a following patch). Change-Id: I15fc7bb0c198fb5ff67701399ee523057e337370 Bug-Url: https://bugzilla.redhat.com/1091863 Bug-Url: https://bugzilla.redhat.com/999975 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVlanParentQuery.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Alona Kaplan: Verified -- To view, visit http://gerrit.ovirt.org/27150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15fc7bb0c198fb5ff67701399ee523057e337370 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Adjust VdsUpdateRunTimeInfo to accept any vlan devic...
by alkaplan＠redhat.com 07 May '14

07 May '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Adjust VdsUpdateRunTimeInfo to accept any vlan device name ...................................................................... engine: Adjust VdsUpdateRunTimeInfo to accept any vlan device name Changes done in this patch- 1. Using iface.getBaseInterface() and iface.getVlanId() instead of determining this values from the vlan device name (since its format is no longer- baseIface.vlanId). 2. Using the new methods indroduced in NetworkUtils instead of the old ones (that should be removed in a following patch). Change-Id: I57b89a8401782200a608be67da5ffd32c6590275 Bug-Url: https://bugzilla.redhat.com/1091863 Bug-Url: https://bugzilla.redhat.com/999975 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Alona Kaplan: Verified -- To view, visit http://gerrit.ovirt.org/26618 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57b89a8401782200a608be67da5ffd32c6590275 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Adjust UpdateNetworkToVdsInterfaceCommand to accept ...
by alkaplan＠redhat.com 07 May '14

07 May '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Adjust UpdateNetworkToVdsInterfaceCommand to accept any vlan device name ...................................................................... engine: Adjust UpdateNetworkToVdsInterfaceCommand to accept any vlan device name Changes done in the command- 1. The command uses iface.getBaseInterface() and iface.getVlanId() instead of determining this values from the vlan device name (since its format is no longer- baseIface.vlanId). 2. The command uses the new methods indroduced in NetworkUtils instead of the old ones (that should be removed in a following patch). Change-Id: I8f003a2889ca429b6158889bc2f3335d111c9192 Bug-Url: https://bugzilla.redhat.com/1091863 Bug-Url: https://bugzilla.redhat.com/999975 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UpdateNetworkToVdsInterfaceCommand.java 1 file changed, 8 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Alona Kaplan: Verified -- To view, visit http://gerrit.ovirt.org/26617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f003a2889ca429b6158889bc2f3335d111c9192 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0