- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[master]: codegen: Allow = in replaced function parameters
by juan.hernandez＠redhat.com 06 May '14

06 May '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Allow = in replaced function parameters ...................................................................... codegen: Allow = in replaced function parameters The code generator replaces some of the functions in the params.py file generated by generateDS.py. To locate these functions it uses regular expressions, but it doesn't take into account that parameters can contain the equals sign. In version 2.9a of generateDS.py the generated functions didn't have parameters with default values, so the equals sign wasn't present: def parseString(inString) In version 2.12a of generateDS.py the generated functions have parameters with default values: def parseString(inString, silence=False) This patch changes the code generator so that it will locate the functions correctly in both cases, with or without the equals sign. Change-Id: I7eccef883def440e04e47a7e04c476a3d3348a91 Related: https://bugzilla.redhat.com/1091688 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/codegen/xsd/genparams.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Looks good to me, approved Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/27221 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7eccef883def440e04e47a7e04c476a3d3348a91 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.4]: build: post ovirt-iso-uploader-3.4.1
by sbonazzo＠redhat.com 06 May '14

06 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-iso-uploader-3.4.1 ...................................................................... build: post ovirt-iso-uploader-3.4.1 Change-Id: Ibc7edb3df1a104c195c0ffac786e8a6397099262 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-iso-uploader.spec.in 2 files changed, 7 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Kiril Nesenko: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27406 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc7edb3df1a104c195c0ffac786e8a6397099262 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.4]: build: ovirt-iso-uploader-3.4.1
by sbonazzo＠redhat.com 06 May '14

06 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-iso-uploader-3.4.1 ...................................................................... build: ovirt-iso-uploader-3.4.1 Change-Id: I54d3a3db97f234e421937b9e7e794d5fd19ac54b Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-iso-uploader.spec.in 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Kiril Nesenko: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27405 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54d3a3db97f234e421937b9e7e794d5fd19ac54b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.4]: Removing useless info line on specific exception
by sbonazzo＠redhat.com 06 May '14

06 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: Removing useless info line on specific exception ...................................................................... Removing useless info line on specific exception On an exception it always says "INFO: Use the -h option to see usage." but this is not always useful Change-Id: Ie4ff43555cb8105e27a83ef8dff5b7df42038ae1 Bug-Url: https://bugzilla.redhat.com/1023507 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/__main__.py 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4ff43555cb8105e27a83ef8dff5b7df42038ae1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-image-uploader[ovirt-image-uploader-3.4]: build: post ovirt-image-uploader-3.4.1
by sbonazzo＠redhat.com 06 May '14

06 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-image-uploader-3.4.1 ...................................................................... build: post ovirt-image-uploader-3.4.1 Change-Id: I29219b0c455d281a5b2fcf6793e24d179204c127 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-image-uploader.spec.in 2 files changed, 7 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29219b0c455d281a5b2fcf6793e24d179204c127 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: ovirt-image-uploader-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-image-uploader[ovirt-image-uploader-3.4]: build: ovirt-image-uploader-3.4.1
by sbonazzo＠redhat.com 06 May '14

06 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-image-uploader-3.4.1 ...................................................................... build: ovirt-image-uploader-3.4.1 Change-Id: I6665cdb2561462caacb2f12d53d0fc4aa3024197 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-image-uploader.spec.in 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6665cdb2561462caacb2f12d53d0fc4aa3024197 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: ovirt-image-uploader-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Don't use inner classes in LinkBuilder
by juan.hernandez＠redhat.com 06 May '14

06 May '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Don't use inner classes in LinkBuilder ...................................................................... restapi: Don't use inner classes in LinkBuilder We use anonymous classes in a rather unusual way in the LinkBuilder. We do the follwing: whatever.setBody(new Body(){{setType(type);}}); Instead of this: Body body = new Body(); body.setType(type); whatever.setBody(body); The former is probably nicer syntax, but it has the side effect of introducing a synthetic field in the anonymous subclass of Body that the compiler generates automatically. This synthetic field is a reference to the outer LinkHelper class. When Jackson tries to convert this object to JSON it finds the synthetic field, and tries to serialize it as well. This fails because the LinkHelper class doesn't have a suitable constructor. The net effect is an error when the server tries to return an error message to the user. The solution is to avoid completely the anonymous classes, and thus the synthetic fields. Change-Id: I10e0ecb68b3e0d412de486c3a38dbefa3c4dd9d2 Bug-Url: https://bugzilla.redhat.com/1093755 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlBuilder.java 1 file changed, 8 insertions(+), 7 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27380 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10e0ecb68b3e0d412de486c3a38dbefa3c4dd9d2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-iso-uploader[master]: Removing useless info line on specific exception
by sbonazzo＠redhat.com 06 May '14

06 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: Removing useless info line on specific exception ...................................................................... Removing useless info line on specific exception On an exception it always says "INFO: Use the -h option to see usage." but this is not always useful Change-Id: Ie4ff43555cb8105e27a83ef8dff5b7df42038ae1 Bug-Url: https://bugzilla.redhat.com/1023507 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/__main__.py 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/27413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4ff43555cb8105e27a83ef8dff5b7df42038ae1 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.4]: build: post ovirt-log-collector-3.4.2
by sbonazzo＠redhat.com 06 May '14

06 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-log-collector-3.4.2 ...................................................................... build: post ovirt-log-collector-3.4.2 Change-Id: I43ebc606d6f13d1f3b766684e3f973c39dc930dd Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-log-collector.spec.in 2 files changed, 7 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43ebc606d6f13d1f3b766684e3f973c39dc930dd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.4]: build: ovirt-log-collector-3.4.2
by sbonazzo＠redhat.com 06 May '14

06 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-log-collector-3.4.2 ...................................................................... build: ovirt-log-collector-3.4.2 Change-Id: Ia86ed8925fe9fc450a26732c1f64d7d92ffd64e5 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-log-collector.spec.in 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia86ed8925fe9fc450a26732c1f64d7d92ffd64e5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0