- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Adjust SetupNetworks to accept any vlan device name
by alkaplan＠redhat.com 07 May '14

07 May '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Adjust SetupNetworks to accept any vlan device name ...................................................................... engine: Adjust SetupNetworks to accept any vlan device name Changes done in this patch- 1. SetupNetworks uses iface.getBaseInterface() and iface.getVlanId() instead of determining this values from the vlan device name (since its format is no longer- baseIface.vlanId). 2. SetupNetworks uses the new methods indroduced in NetworkUtils instead of the old ones (that should be removed in a following patch). Change-Id: Ic08c952a7c1902d176709af7126f54ab37a0344d Bug-Url: https://bugzilla.redhat.com/1091863 Bug-Url: https://bugzilla.redhat.com/999975 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java 4 files changed, 47 insertions(+), 13 deletions(-) Approvals: Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26616 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic08c952a7c1902d176709af7126f54ab37a0344d Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Adjust RemoveBondCommand to accept any vlan device name
by alkaplan＠redhat.com 07 May '14

07 May '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Adjust RemoveBondCommand to accept any vlan device name ...................................................................... engine: Adjust RemoveBondCommand to accept any vlan device name Changes done in the command- 1. The command uses iface.getBaseInterface() and iface.getVlanId() instead of determining this values from the vlan device name (since its format is no longer- baseIface.vlanId). 2. The command uses the new methods indroduced in NetworkUtils instead of the old ones (that should be removed in a following patch). Change-Id: Iaaa99b53249a56a3870bf6c812fa9ae618d09787 Bug-Url: https://bugzilla.redhat.com/1091863 Bug-Url: https://bugzilla.redhat.com/999975 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/RemoveBondCommand.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaaa99b53249a56a3870bf6c812fa9ae618d09787 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Adjust LabelNicCommand to accept any vlan device name
by alkaplan＠redhat.com 07 May '14

07 May '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Adjust LabelNicCommand to accept any vlan device name ...................................................................... engine: Adjust LabelNicCommand to accept any vlan device name Changes done in the command- 1. The command uses iface.getBaseInterface() and iface.getVlanId() instead of determining this values from the vlan device name (since its format is no longer- baseIface.vlanId). 2. The command uses the new methods indroduced in NetworkUtils instead of the old ones (that should be removed in a following patch). Change-Id: I396ab046280c22cd98d77fc38bf7e942de156667 Bug-Url: https://bugzilla.redhat.com/1091863 Bug-Url: https://bugzilla.redhat.com/999975 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/LabelNicCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26614 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I396ab046280c22cd98d77fc38bf7e942de156667 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Adjust GetAllSiblingVlanInterfacesQuery to accept an...
by alkaplan＠redhat.com 07 May '14

07 May '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Adjust GetAllSiblingVlanInterfacesQuery to accept any vlan name ...................................................................... engine: Adjust GetAllSiblingVlanInterfacesQuery to accept any vlan name Changes done in the command- 1. The query uses iface.getBaseInterface() and iface.getVlanId() instead of determining this values from the vlan device name (since its format is no longer- baseIface.vlanId). 2. The query uses the new methods indroduced in NetworkUtils instead of the old ones (that should be removed in a following patch). Change-Id: I95a20887f8359bab66ea54747d21e05c310fc21c Bug-Url: https://bugzilla.redhat.com/1091863 Bug-Url: https://bugzilla.redhat.com/999975 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetAllSiblingVlanInterfacesQuery.java 1 file changed, 15 insertions(+), 6 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Alona Kaplan: Verified -- To view, visit http://gerrit.ovirt.org/26613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95a20887f8359bab66ea54747d21e05c310fc21c Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Adjust GetAllChildVlanInterfacesQuery to accept any ...
by alkaplan＠redhat.com 07 May '14

07 May '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Adjust GetAllChildVlanInterfacesQuery to accept any vlan name ...................................................................... engine: Adjust GetAllChildVlanInterfacesQuery to accept any vlan name Changes done in the command- 1. The query uses iface.getBaseInterface() and iface.getVlanId() instead of determining this values from the vlan device name (since its format is no longer- baseIface.vlanId). 2. The query uses the new methods indroduced in NetworkUtils instead of the old ones (that should be removed in a following patch). Change-Id: Ia1cc427a951ac1647469936cff519c3d440bc75a Bug-Url: https://bugzilla.redhat.com/1091863 Bug-Url: https://bugzilla.redhat.com/999975 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetAllChildVlanInterfacesQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1cc427a951ac1647469936cff519c3d440bc75a Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Adjust DetachNetworkFromVdsInterfaceCommand to accep...
by alkaplan＠redhat.com 07 May '14

07 May '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Adjust DetachNetworkFromVdsInterfaceCommand to accept any vlan name ...................................................................... engine: Adjust DetachNetworkFromVdsInterfaceCommand to accept any vlan name Changes done in the command- 1. The command uses iface.getBaseInterface() and iface.getVlanId() instead of determining this values from the vlan device name (since its format is no longer- baseIface.vlanId). 2. The command uses the new methods indroduced in NetworkUtils instead of the old ones (that should be removed in a following patch). Change-Id: I2c90bbbc1b3d6bd8df87c83301956556d1c6eafd Bug-Url: https://bugzilla.redhat.com/1091863 Bug-Url: https://bugzilla.redhat.com/999975 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/DetachNetworkFromVdsInterfaceCommand.java 1 file changed, 13 insertions(+), 12 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Alona Kaplan: Verified -- To view, visit http://gerrit.ovirt.org/26611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c90bbbc1b3d6bd8df87c83301956556d1c6eafd Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: RemoveNetworksByLabelParametersBuilder accepts any v...
by alkaplan＠redhat.com 07 May '14

07 May '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: RemoveNetworksByLabelParametersBuilder accepts any vlan device name ...................................................................... engine: RemoveNetworksByLabelParametersBuilder accepts any vlan device name Changes done in this patch- 1. The builder uses iface.getBaseInterface() and iface.getVlanId() instead of determining this values from the vlan device name (since its format is no longer- baseIface.vlanId). 2. The builder uses the new methods indroduced in NetworkUtils instead of the old ones (that should be removed in a following patch). Change-Id: If22225ae3d971aa6072b161df0965dd663deff1e Bug-Url: https://bugzilla.redhat.com/1091863 Bug-Url: https://bugzilla.redhat.com/999975 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworksByLabelParametersBuilder.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Alona Kaplan: Verified -- To view, visit http://gerrit.ovirt.org/26610 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If22225ae3d971aa6072b161df0965dd663deff1e Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Adjust MigrateVmCommand to accept any vlan device name
by alkaplan＠redhat.com 07 May '14

07 May '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Adjust MigrateVmCommand to accept any vlan device name ...................................................................... engine: Adjust MigrateVmCommand to accept any vlan device name Changes done in the command- 1. The command uses iface.getBaseInterface() and iface.getVlanId() instead of determining this values from the vlan device name (since its format is no longer- baseIface.vlanId). 2. The command uses the new methods indroduced in NetworkUtils instead of the old ones (that should be removed in a following patch). Change-Id: I0d8989320d39ef74d55574cfb1da0f5efe4ac6ec Bug-Url: https://bugzilla.redhat.com/1091863 Bug-Url: https://bugzilla.redhat.com/999975 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Alona Kaplan: Verified -- To view, visit http://gerrit.ovirt.org/26609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d8989320d39ef74d55574cfb1da0f5efe4ac6ec Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Adjust NetworkUtils to accept any vlan device name- ...
by alkaplan＠redhat.com 07 May '14

07 May '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Adjust NetworkUtils to accept any vlan device name- phase 1 ...................................................................... engine: Adjust NetworkUtils to accept any vlan device name- phase 1 The changes in this class will be done in two phases. Phase 1 (in this patch)- Adjusting NetworkUtils to get the underling interface name of the nic by using VdsNetworkInterface.getBaseInterface() instead of determine the underling nicName from the vlan device name. In this patch old methods signatures are NOT changed in order to avoid breaking the compilation. If a change to the signature is needed, a new method overloads the old one is added. Phase 2- Removing the old methods. Will be done after all the usages of the old methods are replaced/fixed. Change-Id: I426159c169b1fa478776abafb38cb7ae6fdac3be Bug-Url: https://bugzilla.redhat.com/1091863 Bug-Url: https://bugzilla.redhat.com/999975 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkUtilsTest.java 2 files changed, 35 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Alona Kaplan: Verified -- To view, visit http://gerrit.ovirt.org/26608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I426159c169b1fa478776abafb38cb7ae6fdac3be Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: remove unnecessary parameters from VBOB
by alkaplan＠redhat.com 07 May '14

07 May '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: remove unnecessary parameters from VBOB ...................................................................... engine: remove unnecessary parameters from VBOB currVlan and networkVlan are passed and initilaized through some methods in VBOB. But they are not actually used anywhere. Change-Id: I252f1e789a346d045afdf32d638c163abcbe03c1 Bug-Url: https://bugzilla.redhat.com/1091863 Bug-Url: https://bugzilla.redhat.com/999975 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 4 insertions(+), 26 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Alona Kaplan: Verified -- To view, visit http://gerrit.ovirt.org/26607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I252f1e789a346d045afdf32d638c163abcbe03c1 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0