- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: New cluster dialog does not reflect data center co...
by iheim＠redhat.com 13 Apr '14

13 Apr '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: New cluster dialog does not reflect data center compatibility version ...................................................................... webadmin: New cluster dialog does not reflect data center compatibility version The default compatibility version of the cluster is not the same as the DC one when creating a cluster via webadmin using the 'New DC Guide Me'. Change-Id: I52e189cb2a779edfdc87f8c3d58b8d703975ecf9 Bug-Url: https://bugzilla.redhat.com/1082321 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Ravi Nori: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26693 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52e189cb2a779edfdc87f8c3d58b8d703975ecf9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Engine is sending bad credentials repeatdely
by iheim＠redhat.com 13 Apr '14

13 Apr '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Engine is sending bad credentials repeatdely ...................................................................... core: Engine is sending bad credentials repeatdely In some errors (like wrong credentials) engine should not try to work with the next ldap server, unfortunately this information (that it should not try the next ldap server) is only logged , and it continues to the next ldap server Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1085529 Change-Id: I9c04d586a776b469f0e619d3ea0ff844ea07a357 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcher.java 1 file changed, 13 insertions(+), 5 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26696 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c04d586a776b469f0e619d3ea0ff844ea07a357 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-host-deploy[master]: common: pep8-1.5 fixups
by Alon Bar-Lev 11 Apr '14

11 Apr '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: common: pep8-1.5 fixups ...................................................................... common: pep8-1.5 fixups Change-Id: I52c60540f75ebdee9d0862d3f6e1217c4948285d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/ovirt-host-deploy/vdsm/vdsmid.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52c60540f75ebdee9d0862d3f6e1217c4948285d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in otopi[master]: common: pep8-1.5 fixups
by Alon Bar-Lev 11 Apr '14

11 Apr '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: common: pep8-1.5 fixups ...................................................................... common: pep8-1.5 fixups Change-Id: I49751b31d2e2a14f99ca997f72ac3cd57061ddc2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/main.py M src/plugins/otopi/network/firewalld.py M src/plugins/otopi/network/iptables.py 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49751b31d2e2a14f99ca997f72ac3cd57061ddc2 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: pep8 1.5.4 fixes
by sbonazzo＠redhat.com 11 Apr '14

11 Apr '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: pep8 1.5.4 fixes ...................................................................... packaging: setup: pep8 1.5.4 fixes Change-Id: I171dddd68243fa7895d25bae654e6bb723e1840e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/pythonlib/ovirt_engine/service.py M packaging/setup/ovirt_engine_setup/domains.py M packaging/setup/ovirt_engine_setup/util.py M packaging/setup/plugins/ovirt-engine-common/base/core/uninstall.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/config/ca.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/files/simple.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/cpu.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/sshd.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/iso_domain.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/sysctl.py 12 files changed, 31 insertions(+), 32 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I171dddd68243fa7895d25bae654e6bb723e1840e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Adding mock config generator script
by dcaroest＠redhat.com 11 Apr '14

11 Apr '14

David Caro has submitted this change and it was merged. Change subject: Adding mock config generator script ...................................................................... Adding mock config generator script First generate your mock configuration, adding repos, other options based on the default configurations and then to use them use the --configdir option pointing to this dir. Remember to run --init first. Change-Id: I5ac788bb92949af0e497a2088431ea550407d80a Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A .gitignore A mock_configs/epel-6-i386.cfg A mock_configs/epel-6-x86_64.cfg A mock_configs/fedora-19-i386.cfg A mock_configs/fedora-19-x86_64.cfg A mock_configs/fedora-20-i386.cfg A mock_configs/fedora-20-x86_64.cfg A mock_configs/logging.ini A mock_configs/mock_genconfig A mock_configs/site-defaults.cfg 10 files changed, 712 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ac788bb92949af0e497a2088431ea550407d80a Gerrit-PatchSet: 8 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: added missing devices to edit template
by tjelinek＠redhat.com 11 Apr '14

11 Apr '14

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: added missing devices to edit template ...................................................................... engine: added missing devices to edit template It was not possible to edit virtio-scsi and mem balloon for the template. This patch adds it. Change-Id: I286575e8b84881bf49d71e30cfdcb4f3d61475c7 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmTemplateParametersBase.java 4 files changed, 32 insertions(+), 28 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I286575e8b84881bf49d71e30cfdcb4f3d61475c7 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: added proper instance type handling for the watchdog
by tjelinek＠redhat.com 11 Apr '14

11 Apr '14

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: added proper instance type handling for the watchdog ...................................................................... engine: added proper instance type handling for the watchdog 1: Added support for adding the watchdog also for the UpdateTemplateCommand. 2: If the watchdog is added/updated on the instance type, the specific validation should not be run since you can add any device to the instance type. The proper validations are added only when creating the specific VM from the instance type. Change-Id: Ibd953828b7bc3ce1607377a7db28970f5ab7a03e Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddWatchdogCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateWatchdogCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/WatchdogParameters.java 6 files changed, 81 insertions(+), 63 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd953828b7bc3ce1607377a7db28970f5ab7a03e Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Added missing parts for the instance types
by tjelinek＠redhat.com 11 Apr '14

11 Apr '14

Tomas Jelinek has submitted this change and it was merged. Change subject: core: Added missing parts for the instance types ...................................................................... core: Added missing parts for the instance types Since the implementation of the backend of the instance types some new devices has been added, this patch introduces them to the InstanceType interface. Change-Id: Ia78d33c5d91217884568a87e22868749ce4a9316 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/InstanceType.java 1 file changed, 19 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia78d33c5d91217884568a87e22868749ce4a9316 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: added filtering to ensure only the templates return
by tjelinek＠redhat.com 11 Apr '14

11 Apr '14

Tomas Jelinek has submitted this change and it was merged. Change subject: core: added filtering to ensure only the templates return ...................................................................... core: added filtering to ensure only the templates return If the search type in search query was "VmTemplate" it anyway returned all the content of the vm_templastes_view which is a union of instance types, images and templates. Fixed by adding the filtering to the SearchQuery directly and not the DB level because the vm_templates_view is used in a way that it expects that all three types are present in it. Change-Id: Id2b8366f9099fd4461ae7f876fda782e0c8568ab Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24731 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2b8366f9099fd4461ae7f876fda782e0c8568ab Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0