- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: findbugs: remove unused local variable
by tjelinek＠redhat.com 11 Apr '14

11 Apr '14

Tomas Jelinek has submitted this change and it was merged. Change subject: findbugs: remove unused local variable ...................................................................... findbugs: remove unused local variable Change-Id: I350c528beb5ad86191ef41fa452150094afb8160 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified Allon Mureinik: Looks good to me, but someone else must approve Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26695 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I350c528beb5ad86191ef41fa452150094afb8160 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fixed findbugs issue
by tjelinek＠redhat.com 11 Apr '14

11 Apr '14

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: Fixed findbugs issue ...................................................................... engine: Fixed findbugs issue It was a comparision of VmDeviceType and String using the equals which did never pass. Fixed by correctly comparing the Strings Change-Id: If587c985360b54a5fed6e72dbee2bf9c21487a33 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If587c985360b54a5fed6e72dbee2bf9c21487a33 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Engine is sending bad credentials repeatdely
by yzaslavs＠redhat.com 10 Apr '14

10 Apr '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Engine is sending bad credentials repeatdely ...................................................................... core: Engine is sending bad credentials repeatdely In some errors (like wrong credentials) engine should not try to work with the next ldap server, unfortunately this information (that it should not try the next ldap server) is only logged , and it continues to the next ldap server Bug-Ur: https://bugzilla.redhat.com/show_bug.cgi?id=1085529 Change-Id: I9c04d586a776b469f0e619d3ea0ff844ea07a357 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/DirectorySearcher.java 1 file changed, 13 insertions(+), 5 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Yair Zaslavsky: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c04d586a776b469f0e619d3ea0ff844ea07a357 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: New cluster dialog does not reflect data center co...
by oourfali＠redhat.com 10 Apr '14

10 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: New cluster dialog does not reflect data center compatibility version ...................................................................... webadmin: New cluster dialog does not reflect data center compatibility version The default compatibility version of the cluster is not the same as the DC one when creating a cluster via webadmin using the 'New DC Guide Me'. Change-Id: I52e189cb2a779edfdc87f8c3d58b8d703975ecf9 Bug-Url: https://bugzilla.redhat.com/1082321 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26511 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52e189cb2a779edfdc87f8c3d58b8d703975ecf9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core, webadmin: remove name from template version
by ofrenkel＠redhat.com 10 Apr '14

10 Apr '14

Omer Frenkel has submitted this change and it was merged. Change subject: core, webadmin: remove name from template version ...................................................................... core, webadmin: remove name from template version >From now, the template.name for template versions will be the name of the base template, and template versions will only use the version name. in this patch: - backend: make sure name of template version is the same as the name of the base template (ie. allow duplicate name for template base and its versions). - backend + UI: dont check name already exist for template versions. - UI: disable 'name' field on new template dialog for versions, this field will show the selected base name. - UI: template grid - show 'version_name (version_number)' instead of 'name (version_name)'. - UI: show template version name for importing templates, on template sub tab of export domain, and on import template dialog. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1075074 Change-Id: I27f26e7d196d1d2eebfe86e8aac886f3e6a8fc5e Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportTemplatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabTemplateView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageTemplateBackupView.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties A packaging/dbscripts/upgrade/03_05_0270_update_template_version_naming.sql M packaging/dbscripts/vm_templates_sp.sql 20 files changed, 136 insertions(+), 29 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27f26e7d196d1d2eebfe86e8aac886f3e6a8fc5e Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: posible NPE in domain selected item
by shavivi＠redhat.com 10 Apr '14

10 Apr '14

Shahar Havivi has submitted this change and it was merged. Change subject: ui: posible NPE in domain selected item ...................................................................... ui: posible NPE in domain selected item No need to call toString() since the selected item is String. Change-Id: If3a18f8c711f886fe4dfbe4031b2de2aedc59477 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3a18f8c711f886fe4dfbe4031b2de2aedc59477 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: fetch exit reason from VDSM
by ofrenkel＠redhat.com 10 Apr '14

10 Apr '14

Omer Frenkel has submitted this change and it was merged. Change subject: engine: fetch exit reason from VDSM ...................................................................... engine: fetch exit reason from VDSM VDSM has gained the capability to report the reason why a VM is gone in `down` status. see http://gerrit.ovirt.org/#/c/22631/ This patch adds support for this field; backward compatibility with old VDSM lacking this field is ensured. Feature page: http://www.ovirt.org/Features/Detailed_Exit_Reason Relates-To: https://bugzilla.redhat.com/557125 Relates-To: https://bugzilla.redhat.com/697277 Change-Id: Ib36f06f3ba63a743d624e417fe2c96b84dda60be Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmExitReason.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_05_0260_add_exit_reason_to_vm_dynamic.sql M packaging/dbscripts/vms_sp.sql 15 files changed, 110 insertions(+), 18 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23946 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib36f06f3ba63a743d624e417fe2c96b84dda60be Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: reports: br21 report - added comments to queries
by ydary＠redhat.com 10 Apr '14

10 Apr '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: br21 report - added comments to queries ...................................................................... reports: br21 report - added comments to queries Changed the code structure so it will be more readable and added commets. Change-Id: I6011ea7812ab7abdf5367da5f61c44a8bc2d6d3c Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/Reports/Inventory/Storage_Domain_Report_BR21_files/Storage_Domain_Report_BR21_jrxml.data M packaging/ovirt-reports/resources/Reports/Inventory/Storage_Domain_Report_BR21_files/full details br21.jrxml.data 2 files changed, 473 insertions(+), 356 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25136 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6011ea7812ab7abdf5367da5f61c44a8bc2d6d3c Gerrit-PatchSet: 8 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: sdk: Add support for filtering kwargs on collection based pr...
by juan.hernandez＠redhat.com 10 Apr '14

10 Apr '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Add support for filtering kwargs on collection based properties ...................................................................... sdk: Add support for filtering kwargs on collection based properties Enable filtering of results on restrictions for collections Change-Id: I6bc675ce9653b67396f21dd1726726294dc517d9 Bug-Url: https://bugzilla.redhat.com/902976 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtsdk/utils/searchhelper.py 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Looks good to me, but someone else must approve Ravi Nori: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26546 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bc675ce9653b67396f21dd1726726294dc517d9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Fix NPE in HostListModel when non-admin user logge...
by tjelinek＠redhat.com 10 Apr '14

10 Apr '14

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Fix NPE in HostListModel when non-admin user logged in ...................................................................... webadmin: Fix NPE in HostListModel when non-admin user logged in When non admin user logged in the hasAdminSystemPermission Boolean was null and implicitly cast to primitive boolean. Change-Id: Ibcfcb1cb6214066d718a720ca78c195f9512b143 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/26665 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibcfcb1cb6214066d718a720ca78c195f9512b143 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0