- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal: Edit VM on UP fails on NPE
by tjelinek＠redhat.com 10 Apr '14

10 Apr '14

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: Edit VM on UP fails on NPE ...................................................................... userportal: Edit VM on UP fails on NPE The regression has been introduced by the SerialNumber feature: 72fcf57dc92d4e5469b1911cb5b3b42e433bd784 which adds the possibility to edit the serial number also to the UP but the query which is supposed to return, if the serial number is supported for the specific version is not a user query leading to a NPE in AbstractVmPopupWidget where the isSerialNumberPolicySupported was being converted to boolean. And since it was null, this conversion failed on NPE. Change-Id: Ifdd13ded70e3b4abb17c114ebbe86b11a3ef31ea Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Martin Betak: Looks good to me, but someone else must approve Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26524 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdd13ded70e3b4abb17c114ebbe86b11a3ef31ea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: clone VM from snapshot looses the original template
by tjelinek＠redhat.com 10 Apr '14

10 Apr '14

Tomas Jelinek has submitted this change and it was merged. Change subject: core: clone VM from snapshot looses the original template ...................................................................... core: clone VM from snapshot looses the original template Fixed by making sure that when cloned (from VM or from snapshot) that the original template info is copied from the proper source. Change-Id: I7d3daef32ac03b1783b987e682bca6fb5cb9c07b Bug-Url: https://bugzilla.redhat.com/1064001 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java 3 files changed, 18 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26172 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d3daef32ac03b1783b987e682bca6fb5cb9c07b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: clone vm
by tjelinek＠redhat.com 10 Apr '14

10 Apr '14

Tomas Jelinek has submitted this change and it was merged. Change subject: restapi: clone vm ...................................................................... restapi: clone vm REST API part of the clone VM: - added new action: 'clone' - contains a parameter 'vm' where the type is VM - only the 'name' is used from this VM, but used the VM for simple extensebility in the future Change-Id: I18cb01dc83f0a57a7a572fa0da0c7e3397c43707 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1058832 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java 5 files changed, 63 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18cb01dc83f0a57a7a572fa0da0c7e3397c43707 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: clone VM
by tjelinek＠redhat.com 10 Apr '14

10 Apr '14

Tomas Jelinek has submitted this change and it was merged. Change subject: core: clone VM ...................................................................... core: clone VM Implementation of the clone VM feature (in CloneVmCommand). The implementation is done by extracting the common logic from AddVmFromSnapshotCommand to AddVmAndCloneImageCommand and using it in the CloneVmCommand. Change-Id: I3038638314e399e9d2390e7204ce4cc00e85e6ae Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1058832 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CloneVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 13 files changed, 632 insertions(+), 312 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23805 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3038638314e399e9d2390e7204ce4cc00e85e6ae Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: host-deploy: SSHDialog: close streams after sink is stopped
by oourfali＠redhat.com 10 Apr '14

10 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: host-deploy: SSHDialog: close streams after sink is stopped ...................................................................... host-deploy: SSHDialog: close streams after sink is stopped this solves Pipe Closed exception happens because of try-with-resources that was introduced at main thread, this closed the input stream before the reader thread could terminate properly. this also reverts 4d544a99, as it happens from same root cause, and I read the java sources incorrectly, the buffered input stream uses byte-by-byte read and not buffered. add unit test to reproduce this issue. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1084911 Change-Id: I180a9883eefac57c9b528ff7b6df0eda11149255 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHDialog.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHDialogTest.java 3 files changed, 167 insertions(+), 75 deletions(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I180a9883eefac57c9b528ff7b6df0eda11149255 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: host-deploy: flush both stdout, stderr at ssh execute
by oourfali＠redhat.com 10 Apr '14

10 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: host-deploy: flush both stdout, stderr at ssh execute ...................................................................... host-deploy: flush both stdout, stderr at ssh execute although until unclear why it is needed. 1. flush before java attempt to close using try-with-resources. 2. flush also stderr. 3. perform at one location. Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1084911 Change-Id: I14424723f2ef6abff6f3abdc1072e5ac621d4e67 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHClient.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHDialog.java 2 files changed, 10 insertions(+), 12 deletions(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14424723f2ef6abff6f3abdc1072e5ac621d4e67 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: userportal, webadmin: validation error on create template
by oourfali＠redhat.com 10 Apr '14

10 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: userportal,webadmin: validation error on create template ...................................................................... userportal,webadmin: validation error on create template It was not possible to create a new template. The problem was that: - UnitVmModel.validate() did not pass the CPU validation: new IntegerValidation(1, behavior.maxCpus) because the behavior.maxCpus was not inited. - the behavior.maxCpus was not inited because it is inited in the VmModelBehaviorBase.updateMaxNumOfVmCpus() which is called which is triggered by calling the VmModelBehaviorBase.updateNumOfSockets() which is supposed to be called from the specific behavior classes' postDataCenterWithClusterSelectedItemChanged. - The problem was that the NewTemplateVmModelBehavior.postDataCenterWithClusterSelectedItemChanged did not called the updateNumOfSockets() Change-Id: Ida04f94dcbe4d357f306eec60134661c43d9fcdf Bug-Url: https://bugzilla.redhat.com/1085754 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26595 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida04f94dcbe4d357f306eec60134661c43d9fcdf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: tools: Fix empty password error handling in engine-manage-do...
by oourfali＠redhat.com 10 Apr '14

10 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: tools: Fix empty password error handling in engine-manage-domains ...................................................................... tools: Fix empty password error handling in engine-manage-domains Fixed empty password error handling in engine-manage-domains (now it displays clear error message instead of stacktrace). Change-Id: I7fa948f31694c59ce36fc52cd7eb293a8e0b750f Bug-Url: https://bugzilla.redhat.com/1083033 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsResultEnum.java 2 files changed, 12 insertions(+), 7 deletions(-) Approvals: Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26662 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fa948f31694c59ce36fc52cd7eb293a8e0b750f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: nit: pep8 1.5.4 fixes
by sbonazzo＠redhat.com 10 Apr '14

10 Apr '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: nit: pep8 1.5.4 fixes ...................................................................... nit: pep8 1.5.4 fixes Change-Id: I9c96c656b681d3baefecf32ac7f8dbc40ec2447a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/ovirt_hosted_engine_setup/check_liveliness.py M src/ovirt_hosted_engine_setup/tasks.py M src/plugins/ovirt-hosted-engine-setup/core/conf.py M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/ha/ha_services.py M src/plugins/ovirt-hosted-engine-setup/libvirt/workarounds.py M src/plugins/ovirt-hosted-engine-setup/network/bridge.py M src/plugins/ovirt-hosted-engine-setup/network/gateway.py M src/plugins/ovirt-hosted-engine-setup/network/iptables.py M src/plugins/ovirt-hosted-engine-setup/pki/vdsmpki.py M src/plugins/ovirt-hosted-engine-setup/storage/storage.py M src/plugins/ovirt-hosted-engine-setup/system/vdsmenv.py M src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py 14 files changed, 38 insertions(+), 40 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26639 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c96c656b681d3baefecf32ac7f8dbc40ec2447a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Fix empty password error handling in engine-manage-do...
by yzaslavs＠redhat.com 10 Apr '14

10 Apr '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Fix empty password error handling in engine-manage-domains ...................................................................... tools: Fix empty password error handling in engine-manage-domains Fixed empty password error handling in engine-manage-domains (now it displays clear error message instead of stacktrace). Change-Id: I7fa948f31694c59ce36fc52cd7eb293a8e0b750f Bug-Url: https://bugzilla.redhat.com/1083033 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsResultEnum.java 2 files changed, 12 insertions(+), 7 deletions(-) Approvals: Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fa948f31694c59ce36fc52cd7eb293a8e0b750f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0