- Engine-commits - oVirt List Archives

Change in ovirt-image-uploader[master]: Clean the code to pass pyflakes checks
by sbonazzo＠redhat.com 09 Apr '14

09 Apr '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: Clean the code to pass pyflakes checks ...................................................................... Clean the code to pass pyflakes checks Remove unused imports and variables due to pyflakes complains in order to be able to reenable it in the stardard build process Change-Id: Ia2d26c15ffb15ce3d4c112d2cbf2bafe105fe0de Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/__main__.py 1 file changed, 6 insertions(+), 20 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/25955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2d26c15ffb15ce3d4c112d2cbf2bafe105fe0de Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: [Fix] NPE in GlusterSyncJob
by ofrenkel＠redhat.com 09 Apr '14

09 Apr '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: [Fix] NPE in GlusterSyncJob ...................................................................... core: [Fix] NPE in GlusterSyncJob Add validation for corrupt brick(s). Change-Id: Ia11d8bf25a4638c6c205508b26868bfcd2f873cb Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Reviewed-on: http://gerrit.ovirt.org/23817 Reviewed-on: http://gerrit.ovirt.org/24110 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia11d8bf25a4638c6c205508b26868bfcd2f873cb Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: test negative flows for pattern-based name
by ahadas＠redhat.com 09 Apr '14

09 Apr '14

Arik Hadas has submitted this change and it was merged. Change subject: core: test negative flows for pattern-based name ...................................................................... core: test negative flows for pattern-based name Validate pattern-based names are not supported for VMs and Templates. In addition, additional test was added to AddVmPoolWithVmsCommandTest to validate that the validations pass when the pool's name is not pattern-based as well. Change-Id: I893a117a8eaa6abcb9d15abf599eb31426baab35 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java 4 files changed, 49 insertions(+), 3 deletions(-) Approvals: Roy Golan: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/26566 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I893a117a8eaa6abcb9d15abf599eb31426baab35 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix support for pattern-based name for pool
by ahadas＠redhat.com 09 Apr '14

09 Apr '14

Arik Hadas has submitted this change and it was merged. Change subject: core: fix support for pattern-based name for pool ...................................................................... core: fix support for pattern-based name for pool Adding the validation group 'CreateEntity' to UpdateVmPoolWithVmsCommand caused a regression that prevented to set pattern-based name for pool. The problem was that the validation which is declared on VmStatic#getName was checked also for pools and it doesn't accept name that contains '?'. The solution is to introduce 4 additional validation groups for create & update VMs and for create & update Templates, which extend the 'CreateEntity' and 'CreateUpdate' groups, and to change the groups of the validation on VmStatic#getName to these instead of 'CreateEntity' and 'CreateUpdate'. This change is safe because every validation that was checked before will still be checked since the new groups extend the previous ones, except for the validation on VmStatic#getName which will be checked only for commands that add or update VM or Template. Change-Id: I5bfa9fb37d464dd0e77b0bc206c1804713ed9575 Bug-Url: https://bugzilla.redhat.com/1078875 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/group/CreateVm.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/group/UpdateVm.java 7 files changed, 31 insertions(+), 9 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/26356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5bfa9fb37d464dd0e77b0bc206c1804713ed9575 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-live[ovirt-live_3.3]: ovirt-live: update answer file
by obasan＠redhat.com 09 Apr '14

09 Apr '14

Ohad Basan has submitted this change and it was merged. Change subject: ovirt-live: update answer file ...................................................................... ovirt-live: update answer file Change-Id: I1fff7ae4dc75a595986153e05f9347c5e546ee0f Signed-off-by: Ohad Basan <obasan(a)redhat.com> --- M centos/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/ovirt-answer 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ohad Basan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23903 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fff7ae4dc75a595986153e05f9347c5e546ee0f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live_3.3 Gerrit-Owner: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: dropping builddep on otopi-devtool
by sbonazzo＠redhat.com 09 Apr '14

09 Apr '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: dropping builddep on otopi-devtool ...................................................................... packaging: dropping builddep on otopi-devtool We don't use otopi-bundle, so no reason for requiring it. We can also avoid to require otopi at build time since it's not used by the build process. It's a runtime requirement only. Change-Id: I0e3f21ad146c75cd2bc75f13a7bf49dcb35c6b3d Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac D m4/ax_python_module.m4 M ovirt-hosted-engine-setup.spec.in 3 files changed, 0 insertions(+), 55 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved David Caro: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e3f21ad146c75cd2bc75f13a7bf49dcb35c6b3d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-3.3]: build: ovirt-engine-reports-3.3.5-1
by ydary＠redhat.com 09 Apr '14

09 Apr '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: ovirt-engine-reports-3.3.5-1 ...................................................................... build: ovirt-engine-reports-3.3.5-1 Also added release notes. Change-Id: Ic754a2d86993ebad114092406f5bd69c7de4d79b Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-engine-reports.spec.in M version.mak 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26600 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic754a2d86993ebad114092406f5bd69c7de4d79b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[ovirt-3.3]: build: ovirt-engine-dwh-3.3.5-1
by ydary＠redhat.com 09 Apr '14

09 Apr '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: ovirt-engine-dwh-3.3.5-1 ...................................................................... build: ovirt-engine-dwh-3.3.5-1 Also added release notes Change-Id: I98e8dc5c931742d6ba3c08d1674ef41e090b2283 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-engine-dwh.spec.in M version.mak 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26599 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98e8dc5c931742d6ba3c08d1674ef41e090b2283 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: reports: br7b report - added comments to queries
by ydary＠redhat.com 09 Apr '14

09 Apr '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: br7b report - added comments to queries ...................................................................... reports: br7b report - added comments to queries Changed the code structure so it will be more readable and added commets. Change-Id: If15e13abe907bcdfb903d02aab049f262d7bf350 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/Reports/Service_level/Hosts/top_10_downtime_hosts_br7b_files/br7b full details.jrxml.data M packaging/ovirt-reports/resources/Reports/Service_level/Hosts/top_10_downtime_hosts_br7b_files/top_10_downtime_hosts_br7b_jrxml.data 2 files changed, 767 insertions(+), 565 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25237 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If15e13abe907bcdfb903d02aab049f262d7bf350 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: aaa: Introducing changes to REST-API (at domain groups and ids)
by yzaslavs＠redhat.com 09 Apr '14

09 Apr '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Introducing changes to REST-API (at domain groups and ids) ...................................................................... aaa: Introducing changes to REST-API (at domain groups and ids) For domain groups/users the ids do not serve as primary keys in db any longer. Primary keys (internal ids) are generated by engine code. The forma of the domain group/users ids is hexadecimal represenation of the id in the domain. At db users/db groups presentation this information is presented as "domain_entry_id" Topic: AAA Change-Id: Iaecb5d43945769db82475edde1c7075c1a343c07 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutomaticLoginFilter.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDomainGroupResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDomainUserResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDomainGroupResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDomainUserResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GroupMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/DirectoryEntryIdUtils.java 15 files changed, 63 insertions(+), 32 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26191 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaecb5d43945769db82475edde1c7075c1a343c07 Gerrit-PatchSet: 29 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0