- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Print correct message for network used by templates
by masayag＠redhat.com 27 Feb '14

27 Feb '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Print correct message for network used by templates ...................................................................... engine: Print correct message for network used by templates Change-Id: Ic398609b1133665217cb5e59dacbfb30ea78eeb3 Bug-Url: https://bugzilla.redhat.com/1058030 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java 2 files changed, 3 insertions(+), 4 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/24997 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic398609b1133665217cb5e59dacbfb30ea78eeb3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Preserve bonding options when updating vlan over bond
by masayag＠redhat.com 27 Feb '14

27 Feb '14

Moti Asayag has submitted this change and it was merged. Change subject: core: Preserve bonding options when updating vlan over bond ...................................................................... core: Preserve bonding options when updating vlan over bond The ovirt-engine used to erase any pre-configured bonding options, if it wasn't provided explicitly by the api users. In order to preserve the bonding options properly, there is a need either to examine it from the supplied properties or to use the already configured bonding device from the engine db. Change-Id: I09b150b11913a9d8cddc5115e28c027e7c944910 Bug-Url: https://bugzilla.redhat.com/1068970 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UpdateNetworkToVdsInterfaceCommand.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java 2 files changed, 28 insertions(+), 13 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/24912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09b150b11913a9d8cddc5115e28c027e7c944910 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: VdsDynamicDAO.testUpdateIfNeededPerformance
by amureini＠redhat.com 27 Feb '14

27 Feb '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: VdsDynamicDAO.testUpdateIfNeededPerformance ...................................................................... core: VdsDynamicDAO.testUpdateIfNeededPerformance As this test is based on timing, it fails sporadically, thus generating inappropriate noise during build time. Moreover, this is a performance test, not a correctness test, and as such should not be part of the regular test suite. Change-Id: I4ce745eb4416ffac0ae7162f69e85b55bd003569 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDAOTest.java 1 file changed, 0 insertions(+), 23 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25117 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ce745eb4416ffac0ae7162f69e85b55bd003569 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: AuditLogDAOTest date format
by amureini＠redhat.com 27 Feb '14

27 Feb '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: AuditLogDAOTest date format ...................................................................... core: AuditLogDAOTest date format Since SimpleDateFormat is inherently not thread-safe and some runners may run different tests in different thread, it's a potential bug to use a static instance of it. Additionally, this issue is picked up by recent version of FindBugs and Coverity, generating noise. Change-Id: I41384f1f061bcffbc08c2f0fda8633d2f42bd5a9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AuditLogDAOTest.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25116 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41384f1f061bcffbc08c2f0fda8633d2f42bd5a9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Allow to configure domains_realm section via external...
by yzaslavs＠redhat.com 27 Feb '14

27 Feb '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Allow to configure domains_realm section via external file ...................................................................... tools: Allow to configure domains_realm section via external file This can come handy in case the kerberos realm for the added domain is not an upper case version of it. Bare in mind the external file should contain all the domains in case there is more than one domain in the setup Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1070465 Change-Id: I970b8f4950abb5eeb0a72a46ed00af26028919dd Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KrbConfCreator.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsConfiguration.java 3 files changed, 49 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I970b8f4950abb5eeb0a72a46ed00af26028919dd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: customization: added patch to fix jrs pro start
by ydary＠redhat.com 27 Feb '14

27 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: customization: added patch to fix jrs pro start ...................................................................... packaging: customization: added patch to fix jrs pro start This also required a changed in deployment order, since a bean we add needed to be removed. Change-Id: Icccd1e62680e756f8de26c8c8f76dd0947750ccf Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- A packaging/jasper-war-patches/pro/200_006_web-inf_remove_query_manipulator_override.patch M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py 2 files changed, 52 insertions(+), 18 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icccd1e62680e756f8de26c8c8f76dd0947750ccf Gerrit-PatchSet: 7 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: setup: added jrs pro edition deploy steps
by ydary＠redhat.com 27 Feb '14

27 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: added jrs pro edition deploy steps ...................................................................... packaging: setup: added jrs pro edition deploy steps Setup can now install either JRS CE edition or PRO edition. Change-Id: I3a3f36e11d0450c031de6da6c6470024534c60e1 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py 1 file changed, 166 insertions(+), 6 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a3f36e11d0450c031de6da6c6470024534c60e1 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: db: cleanup: removing obsolete scripts
by emesika＠redhat.com 27 Feb '14

27 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: db: cleanup: removing obsolete scripts ...................................................................... db: cleanup: removing obsolete scripts backup.sh and restore.sh are obsolete. engine-backup should be used for backup and restore. create_db.sh is not used since 3.3. encryptionvalidator.sh is not used since 3.3. exportDbSchema.sh is not used. *_schema_checksum.sh are not used. Change-Id: I4133c2f442bef91bebb427b7acac34cad278f396 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile R build/dbscripts-duplicate_upgrade_scripts.sh D build/dbscripts/calc_db_schema_checksum.sh D build/dbscripts/check_db_schema_checksum.sh D build/dbscripts/store_db_schema_checksum.sh D packaging/dbscripts/backup.sh D packaging/dbscripts/create_db.sh D packaging/dbscripts/encryptionvalidator.sh D packaging/dbscripts/exportDbSchema.sh D packaging/dbscripts/restore.sh 10 files changed, 2 insertions(+), 611 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24904 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4133c2f442bef91bebb427b7acac34cad278f396 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: db: remove unused engine certificate env
by emesika＠redhat.com 27 Feb '14

27 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: packaging: setup: db: remove unused engine certificate env ...................................................................... packaging: setup: db: remove unused engine certificate env since 3.3 it is not used. Change-Id: I08387adefb347ee362026e3b9d99e2cefde563bc Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/schema.py 1 file changed, 0 insertions(+), 8 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24884 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08387adefb347ee362026e3b9d99e2cefde563bc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: db: remove drop_old_uuid_functions
by emesika＠redhat.com 27 Feb '14

27 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: db: remove drop_old_uuid_functions ...................................................................... db: remove drop_old_uuid_functions no need for this since 3.3, only function that uses postgres user. Change-Id: I8c6f128785fb63f275587aec74e51c266c20931e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/dbscripts/create_schema.sh M packaging/dbscripts/dbfunctions.sh D packaging/dbscripts/drop_old_uuid_functions.sql 3 files changed, 0 insertions(+), 41 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, but someone else must approve Eli Mesika: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c6f128785fb63f275587aec74e51c266c20931e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0