- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: db: functions: remove unused pg_version
by emesika＠redhat.com 27 Feb '14

27 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: db: functions: remove unused pg_version ...................................................................... db: functions: remove unused pg_version more than it is unused it checks only for client side libraries version, which is incorrect. Change-Id: I5ee352658a00ab7efd935060b002bce96875eda1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/dbscripts/dbfunctions.sh 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, but someone else must approve Eli Mesika: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ee352658a00ab7efd935060b002bce96875eda1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: doc: README.developer: add notes per comments
by emesika＠redhat.com 26 Feb '14

26 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: doc: README.developer: add notes per comments ...................................................................... doc: README.developer: add notes per comments Change-Id: Iff82d0fe1a813c0d4abee92ba6f1c216a3231652 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M README.developer 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff82d0fe1a813c0d4abee92ba6f1c216a3231652 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in otopi[master]: core: miniyum: fix http range error when yum cache exists
by Alon Bar-Lev 26 Feb '14

26 Feb '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: miniyum: fix http range error when yum cache exists ...................................................................... core: miniyum: fix http range error when yum cache exists Change-Id: I8492376ce52908223f2c8e491c4b560059afb2cf Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/otopi/miniyum.py 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25118 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8492376ce52908223f2c8e491c4b560059afb2cf Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[otopi-1.1]: core: miniyum: fix http range error when yum cache exists
by Alon Bar-Lev 26 Feb '14

26 Feb '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: miniyum: fix http range error when yum cache exists ...................................................................... core: miniyum: fix http range error when yum cache exists Change-Id: I8492376ce52908223f2c8e491c4b560059afb2cf Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/otopi/miniyum.py 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8492376ce52908223f2c8e491c4b560059afb2cf Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: otopi-1.1 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core, restapi: Fix add permissions
by iheim＠redhat.com 26 Feb '14

26 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core, restapi: Fix add permissions ...................................................................... core, restapi: Fix add permissions The refactoring of the authentication mechanism introduced two different identifiers for users and groups: one used internally by the engine and one used by the external directory. The RESTAPI wasn't correctly handling requests to add permissions when the provided identifier was the internal one. The patch fixes the RESTAPI and the backend so that they will accept both identifiers when adding users or groups. Change-Id: I0d05c4bf4ebd242fd3a01a2f9a8d679f687c4982 Bug-Url: https://bugzilla.redhat.com/1064829 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 072cc1f4c3495b75f344688c9b28691875a12f88) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbGroupDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GroupMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermissionMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/PermissionMapperTest.java 10 files changed, 335 insertions(+), 80 deletions(-) Approvals: Juan Hernandez: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d05c4bf4ebd242fd3a01a2f9a8d679f687c4982 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Bad vertical alignment in add user screen
by iheim＠redhat.com 26 Feb '14

26 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Bad vertical alignment in add user screen ...................................................................... webadmin: Bad vertical alignment in add user screen When adding a new user, the dropdown box for selecting the domain and the search box are misaligned Change-Id: I967023959027f2b977592cf8a6b61952960e24c3 Bug-Url: https://bugzilla.redhat.com/1057109 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml 1 file changed, 14 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Ravi Nori: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I967023959027f2b977592cf8a6b61952960e24c3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Disabling an SD with unplugged disk of a VM
by iheim＠redhat.com 26 Feb '14

26 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Disabling an SD with unplugged disk of a VM ...................................................................... core: Disabling an SD with unplugged disk of a VM Prior to this patch, when disabling a Storage Domain the canDoAction() would check that it does not contain any disks in that belong to running VM, and if it does, the command is failed. This behavior is overly strict, and we should be able to disable a domain which contains unplugged disks, even if they are attached to a running VM. This patch contains: 1. Changing the GetVmsByStorageDomainId stored procedure to take only plugged disks in to account. 2. In fixtures.xml, plugging disk 1b26a52b-b60f-44cb-9f46-3ef333b04a35 into VM 77296e00-0cad-4e5a-9299-008a7b6f4355, as opposed to just attaching it in order for this fix to be tested. 3. Updating the DAO tests accordingly. Change-Id: I89d119295cf16eb1ea2df365fb22cadde6595e6a Bug-Url: https://bugzilla.redhat.com/1065747 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/vms_sp.sql 6 files changed, 31 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Looks good to me, approved Allon Mureinik: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89d119295cf16eb1ea2df365fb22cadde6595e6a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: word wrap login error message
by awels＠redhat.com 26 Feb '14

26 Feb '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal,webadmin: word wrap login error message ...................................................................... userportal,webadmin: word wrap login error message - Fixed issue where if the error message would contain long words it would not word wrap. Change-Id: I62c9aae3c37771693548e62615880aa818f2d82a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063818 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginPopupView.ui.xml 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Verified Greg Sheremeta: Looks good to me, but someone else must approve Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24466 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62c9aae3c37771693548e62615880aa818f2d82a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Use correct storage validation for MoveVM
by amureini＠redhat.com 26 Feb '14

26 Feb '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Use correct storage validation for MoveVM ...................................................................... core: Use correct storage validation for MoveVM Fix MoveVMCommand to use the new (correct) StorageDomainValidator.hasSpaceForClonedDisks(Iterable<DiskImage>) to validate the destination domain has enough space. Change-Id: I7f455ff16d11622be4e28ea84180551237a80db1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Tal Nisan: Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Sergey Gotliv: Looks good to me, but someone else must approve Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/24027 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f455ff16d11622be4e28ea84180551237a80db1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi: add use_latest_template_version to vm restapi
by iheim＠redhat.com 26 Feb '14

26 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: restapi: add use_latest_template_version to vm restapi ...................................................................... restapi: add use_latest_template_version to vm restapi Add the new optional parameter that is relevant for stateless vm creation. It can be also passed when updating a vm. By using it, users can select to always create stateless vm based on its latest version of the used template. Feature page http://www.ovirt.org/Features/Template_Versions#REST_API Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1037478 Change-Id: I38b569f7ef6df4d485dac15b804427c8248ab540 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 4 files changed, 79 insertions(+), 15 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38b569f7ef6df4d485dac15b804427c8248ab540 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0