- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: core, webadmin: Warn about incompatible upgrade
by iheim＠redhat.com 12 Feb '14

12 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core, webadmin: Warn about incompatible upgrade ...................................................................... core, webadmin: Warn about incompatible upgrade When upgrading a DC, a warning is issued if this upgrade would cause upgrading the domains' storage format. This patch improves that message by adding information that this upgrade will cause the domains to be unusable with products of version XYZ. The patch includes: 1. A method in VersionStorageFormatUtil to retrieve the earliest supported version of a given format. 2. A unit test for said method 3. Migrating the message from UIConstants to UIMessages, and adding a version parameter. 4. The call in DataCenterListModel for said message. Change-Id: I3fa7345caad8603c03fb042dec2cebf6fdc03f44 Bug-Url: https://bugzilla.redhat.com/957939 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VersionStorageFormatUtil.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/VersionStorageFormatUtilTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 5 files changed, 44 insertions(+), 7 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/24374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fa7345caad8603c03fb042dec2cebf6fdc03f44 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: sed 's/foomatic/buildomatic'
by ydary＠redhat.com 12 Feb '14

12 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: sed 's/foomatic/buildomatic' ...................................................................... packaging: setup: sed 's/foomatic/buildomatic' /me/ do not know to read. Change-Id: I7b8025b6b5718e1a50c40f6261938a89e5a47bc5 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/reportsconstants.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/db/connection.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-reports/jasper/clear.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py 4 files changed, 21 insertions(+), 18 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b8025b6b5718e1a50c40f6261938a89e5a47bc5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: setup: using patches to customize war instead of ...
by ydary＠redhat.com 12 Feb '14

12 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: using patches to customize war instead of overwrites ...................................................................... packaging: setup: using patches to customize war instead of overwrites Change-Id: If0becc8ef9206fa077547682fd4c299fa5491b15 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M Makefile M ovirt-engine-reports.spec.in D packaging/jasper-customizations/META-INF/MANIFEST.MF D packaging/jasper-customizations/WEB-INF/classes/jasperreports.properties D packaging/jasper-customizations/WEB-INF/decorators/decorator.jsp D packaging/jasper-customizations/WEB-INF/decorators/minimalDecorator.jsp D packaging/jasper-customizations/WEB-INF/js.config.properties D packaging/jasper-customizations/WEB-INF/jsp/modules/login/loginHelp.jsp D packaging/jasper-customizations/WEB-INF/jsp/modules/viewReport/ViewReportState.jsp D packaging/jasper-customizations/WEB-INF/web.xml A packaging/jasper-war-patches/100_001_meta-inf_add-postgresql-jdbc-module-dependency.patch A packaging/jasper-war-patches/200_001_web-inf_use-war-jboss-faces.patch A packaging/jasper-war-patches/200_002_web-inf_add-reports-status-servlet.patch A packaging/jasper-war-patches/200_003_web-inf_enforce-ssl.patch A packaging/jasper-war-patches/300_001_jsp_change-login-help-info.patch A packaging/jasper-war-patches/300_002_jsp_fix-sso-resend-issue.patch A packaging/jasper-war-patches/300_003_jsp_rebrand-tab-headers.patch A packaging/jasper-war-patches/900_001_props_disable-heartbeat-reporting.patch A packaging/jasper-war-patches/900_002_props_fix-column-headers-disappearing-in-reports.patch A packaging/jasper-war-patches/900_003_props_enable-full-text-in-supported-formats.patch M packaging/setup/ovirt_engine_setup/reportsconstants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py 22 files changed, 189 insertions(+), 1,150 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0becc8ef9206fa077547682fd4c299fa5491b15 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: spec: remove jrs-deployment.version reference
by ydary＠redhat.com 12 Feb '14

12 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: spec: remove jrs-deployment.version reference ...................................................................... packaging: spec: remove jrs-deployment.version reference legacy, not used. Change-Id: I1e483b88c9184f064e11ab2807ee0366e4c90b50 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine-reports.spec.in 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e483b88c9184f064e11ab2807ee0366e4c90b50 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: spec: cleanup pre/post of services
by ydary＠redhat.com 12 Feb '14

12 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: spec: cleanup pre/post of services ...................................................................... packaging: spec: cleanup pre/post of services 1. cleanup ordering. 2. register sysv service. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063873 Change-Id: I9acc51cbd9024343bb3c8ac19eab4739fe11e6fa Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine-dwh.spec.in 1 file changed, 13 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24340 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9acc51cbd9024343bb3c8ac19eab4739fe11e6fa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: task list in Webadmin - jobs disappear while still run...
by oourfali＠redhat.com 12 Feb '14

12 Feb '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: task list in Webadmin - jobs disappear while still running ...................................................................... core: task list in Webadmin - jobs disappear while still running Previous commit deleted jobs that had at least one step that doesn't have an async task. Proper logic is to delete jobs that doesn't have steps with async tasks. Change-Id: I772ec5a6255351cd3145295c783385bf0a0c4de0 Bug-Url: https://bugzilla.redhat.com/1064227 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M packaging/dbscripts/job_sp.sql 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I772ec5a6255351cd3145295c783385bf0a0c4de0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core, webadmin: Warn about incompatible upgrade
by amureini＠redhat.com 12 Feb '14

12 Feb '14

Allon Mureinik has submitted this change and it was merged. Change subject: core, webadmin: Warn about incompatible upgrade ...................................................................... core, webadmin: Warn about incompatible upgrade When upgrading a DC, a warning is issued if this upgrade would cause upgrading the domains' storage format. This patch improves that message by adding information that this upgrade will cause the domains to be unusable with products of version XYZ. The patch includes: 1. A method in VersionStorageFormatUtil to retrieve the earliest supported version of a given format. 2. A unit test for said method 3. Migrating the message from UIConstants to UIMessages, and adding a version parameter. 4. The call in DataCenterListModel for said message. Change-Id: I3fa7345caad8603c03fb042dec2cebf6fdc03f44 Bug-Url: https://bugzilla.redhat.com/957939 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VersionStorageFormatUtil.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/VersionStorageFormatUtilTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 5 files changed, 44 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fa7345caad8603c03fb042dec2cebf6fdc03f44 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: fix useDnsLookup behavior
by iheim＠redhat.com 12 Feb '14

12 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: fix useDnsLookup behavior ...................................................................... core: fix useDnsLookup behavior This patch fixes the usage of "useDnsLookup" flag at engine-manage-domains configuration. only When --ldap-servers is used, this flag should be ignored if set to true. Change-Id: Ic96e2f9fafcac1e6ba952a198bfb9cecc160ba8b Bug-Url: https://bugzilla.redhat.com/1063286 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24306 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic96e2f9fafcac1e6ba952a198bfb9cecc160ba8b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: services: sysv: fix metadata
by sbonazzo＠redhat.com 12 Feb '14

12 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: services: sysv: fix metadata ...................................................................... packaging: services: sysv: fix metadata Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063860 Change-Id: Ia77243a4ac3240f53ab0328126cb130ac2817b47 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.sysv.in M packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.sysv.in 2 files changed, 10 insertions(+), 10 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24363 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia77243a4ac3240f53ab0328126cb130ac2817b47 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: spec: register/unregister sysv daemons
by sbonazzo＠redhat.com 12 Feb '14

12 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: register/unregister sysv daemons ...................................................................... packaging: spec: register/unregister sysv daemons Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063873 Change-Id: I53298969ea5c6ed4b6719a4f7b62426ef1efbd22 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24338 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53298969ea5c6ed4b6719a4f7b62426ef1efbd22 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0