- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: core: Make VM disks editable
by iheim＠redhat.com 11 Feb '14

11 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Make VM disks editable ...................................................................... core: Make VM disks editable When a VM is updated the data from the database is compared to the updated VM object provided by the caller. But the VM object loaded from the database doesn't contain the list of disks, so if the caller provides an VM object that contains the list of disks the UpdateVM command will wrongly assume that the caller is trying to modify this list. To avoid this issue this patch marks the list of disks as editable, so that the UpdateVM command will ignore it. Change-Id: I0fa0a0397a44adc93680eae593a92346f9e67600 Bug-Url: https://bugzilla.redhat.com/1059713 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fa0a0397a44adc93680eae593a92346f9e67600 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Fix group search and add
by juan.hernandez＠redhat.com 11 Feb '14

11 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix group search and add ...................................................................... restapi: Fix group search and add The RESTAPI doesn't currently accept group names with the format domain/organization/group. This patch fixes that. Change-Id: Iffb4ba829d5e07b46c0bb6d71e46bdbdbcb2442c Bug-Url: https://bugzilla.redhat.com/1057214 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/DirectoryGroupSearchQueryTest.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResourceTest.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ADSyntaxChecker.java 4 files changed, 16 insertions(+), 8 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffb4ba829d5e07b46c0bb6d71e46bdbdbcb2442c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: improve audit log when creating diskless template
by iheim＠redhat.com 11 Feb '14

11 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: improve audit log when creating diskless template ...................................................................... core: improve audit log when creating diskless template Change-Id: I99c88bbc84e19fef06d54bd25567500b056d6e20 Bug-Url: https://bugzilla.redhat.com/1053544 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 17 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/24307 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99c88bbc84e19fef06d54bd25567500b056d6e20 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi: Assure network existence when adding a vnic profile
by iheim＠redhat.com 11 Feb '14

11 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: restapi: Assure network existence when adding a vnic profile ...................................................................... restapi: Assure network existence when adding a vnic profile In order to create a vnic profile, the user must provide the network id to which he wishes to add the profile. If a network cannot be obtained by the id, the parameters should consider invalid and a proper message should be returned. The backend has logic for this scenario, however when performing this action with a user that its permissions should be verified, there is a generic "User is not authorized to perform this action" even though the message refers to a non-existing network entity. Change-Id: Ib517cc0fd04c4f0e12fd6bdbdca8c6277600e325 Bug-Url: https://bugzilla.redhat.com/1031369 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVnicProfilesResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfilesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVnicProfilesResourceTest.java 3 files changed, 23 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/24327 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib517cc0fd04c4f0e12fd6bdbdca8c6277600e325 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: When ActivateVDS fails, move VDS out of Unassigned status
by iheim＠redhat.com 11 Feb '14

11 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: When ActivateVDS fails, move VDS out of Unassigned status ...................................................................... core: When ActivateVDS fails, move VDS out of Unassigned status If ActivateVDS command fails, in some rare scenarios the VDS will be stuck on Unassigned status, locking any ability to remove/activate the VDS. This patch will move failed VDS to Error status. Change-Id: I776fb9fd0fe3292ad257c7bcfaf4ac8c89536869 Bug-Url: https://bugzilla.redhat.com/962180 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/24326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I776fb9fd0fe3292ad257c7bcfaf4ac8c89536869 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Don't duplicate directory name in the DB
by juan.hernandez＠redhat.com 11 Feb '14

11 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: core: Don't duplicate directory name in the DB ...................................................................... core: Don't duplicate directory name in the DB Currently in the "users" table we store the directory name in the "domain" column and also, as a suffix added to the user name, in the in the "username" column. This duplication causes confusion, and makes the SQL schema a bit more non normalized. This patch removes that duplication and changes the places that need to display the directory name (GUI and RESTAPI) so that it is done explicitly. Bug-Url: https://bugzilla.redhat.com/1055881 Bug-Url: https://bugzilla.redhat.com/1059258 Change-Id: I53ebaf3254f829d73b2574230ae333f13cfcd546 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDomainUserResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUsersResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdcUserConditionFieldAutoCompleter.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/utils/FormatUtils.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/auth/CurrentUser.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java M packaging/dbscripts/common_sp.sql M packaging/dbscripts/create_functions.sql A packaging/dbscripts/upgrade/03_04_0620_remove_directory_suffix_from_login_name.sql 11 files changed, 98 insertions(+), 38 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53ebaf3254f829d73b2574230ae333f13cfcd546 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: SDValidator - fix message for locked SD
by iheim＠redhat.com 11 Feb '14

11 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: SDValidator - fix message for locked SD ...................................................................... core: SDValidator - fix message for locked SD StorageDomainValidator -> isDomainExistAndActive: if the storage domain is not in status Active, the following canDo message should be returned: "The relevant Storage Domain's status is ${status}" Change-Id: I329d974710faa0437fe657c7e650aebb39960960 Bug-Url: https://bugzilla.redhat.com/1060516 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ExportRepoImageCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorTest.java 5 files changed, 7 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24231 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I329d974710faa0437fe657c7e650aebb39960960 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: clone vm from snapshot - validate disk sd
by iheim＠redhat.com 11 Feb '14

11 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: clone vm from snapshot - validate disk sd ...................................................................... webadmin: clone vm from snapshot - validate disk sd Clone VM from Snapshot: verify that a target storage domain is selected for each disk. Change-Id: I1f5148295b46ce4394c407881217d34d3f7443a8 Related-To-Bug-Url: https://bugzilla.redhat.com/975114 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/24230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f5148295b46ce4394c407881217d34d3f7443a8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: storage active validation on AddVmFromSnapshot
by iheim＠redhat.com 11 Feb '14

11 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: storage active validation on AddVmFromSnapshot ...................................................................... core: storage active validation on AddVmFromSnapshot Added validation for source storage domains on AddVmFromSnapshotCommand (i.e. source storage domains should be active). Change-Id: I44ab14a527d2af7dce1b11b8d96f7e384c7b2027 Bug-Url: https://bugzilla.redhat.com/975114 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24229 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44ab14a527d2af7dce1b11b8d96f7e384c7b2027 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Change backward compatibility logic for add/update vnic
by masayag＠redhat.com 11 Feb '14

11 Feb '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Change backward compatibility logic for add/update vnic ...................................................................... engine: Change backward compatibility logic for add/update vnic The current backward compatibility logic designed for resolving a vnic profile id for a given network should be modified, since REST clients which provides both network name and vnic profile id might face issues, such ignoring the vnic profile id. For that purpose the engine will attempt to find a change in the network name provided by the user to what is already configured on the vnic: 1. If network name is provided, and unchanged - the vnic profile id from the parameters is used. 2. If the network name is provided and changed, use it instead of the vnic profile id. Change-Id: If1611087bad26b0bfa5a42780c5362e3413fbb75 Bug-Url: https://bugzilla.redhat.com/1047887 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/UpdateVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/VmTemplateInterfaceCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileHelper.java 5 files changed, 55 insertions(+), 11 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/24263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1611087bad26b0bfa5a42780c5362e3413fbb75 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0