- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: When ActivateVDS fails, move VDS out of Unassigned status
by emesika＠redhat.com 11 Feb '14

11 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: core: When ActivateVDS fails, move VDS out of Unassigned status ...................................................................... core: When ActivateVDS fails, move VDS out of Unassigned status If ActivateVDS command fails, in some rare scenarios the VDS will be stuck on Unassigned status, locking any ability to remove/activate the VDS. This patch will move failed VDS to Error status. Change-Id: I776fb9fd0fe3292ad257c7bcfaf4ac8c89536869 Bug-Url: https://bugzilla.redhat.com/962180 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/24045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I776fb9fd0fe3292ad257c7bcfaf4ac8c89536869 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: SearchQuery generates slow query on vds_with_tags an...
by emesika＠redhat.com 11 Feb '14

11 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: engine: SearchQuery generates slow query on vds_with_tags and storage_domains ...................................................................... engine: SearchQuery generates slow query on vds_with_tags and storage_domains Fix SearchQuery so that queries without tags are run against the base table, saving an uneeded (and costly) inner query. VDS query decreased by almost 80% (from 100ms to 15ms). Change-Id: Ia0b7a4912d031c4cdafd636126730ea81d8d2bdd Bug-Url: https://bugzilla.redhat.com/984973 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SearchQueryTest.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 3 files changed, 93 insertions(+), 29 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20914 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0b7a4912d031c4cdafd636126730ea81d8d2bdd Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk-java[sdk_3.4]: codegen: Use SDK specific JAXB bindings
by juan.hernandez＠redhat.com 11 Feb '14

11 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Use SDK specific JAXB bindings ...................................................................... codegen: Use SDK specific JAXB bindings Currently the SDK uses the same JAXB global bindings used by the engine, because used to be identical. But recently (in commit a57a6a) the engine started to use global bindings tha aren't suitable for the SDK. These bindings used by tne engine already been moved to a separate file in commit 8acd13. This means that they won't be present in the XML schema generated by the engine. But some of these global bindings are needed by the SDK as well, in particular the setting that enables generation of "isSet" methods. This patch adds a bindings file specific to the SDK, that contains only the global bindings needed by the SDK. Change-Id: I946db48bee9d5b9fc6d33ade2fa26b0891f99aaa Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 5218df693721e56916fca6deb6ae77900eb0bf2d) --- M ovirt-engine-sdk-java-codegen/pom.xml M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/Main.java M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/xsd/XsdCodegen.java A ovirt-engine-sdk-java-codegen/src/main/resources/api.xjb M ovirt-engine-sdk-java-codegen/src/main/resources/api.xsd 5 files changed, 39 insertions(+), 21 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I946db48bee9d5b9fc6d33ade2fa26b0891f99aaa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: codegen: Use SDK specific JAXB bindings
by juan.hernandez＠redhat.com 11 Feb '14

11 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Use SDK specific JAXB bindings ...................................................................... codegen: Use SDK specific JAXB bindings Currently the SDK uses the same JAXB global bindings used by the engine, because used to be identical. But recently (in commit a57a6a) the engine started to use global bindings tha aren't suitable for the SDK. These bindings used by tne engine already been moved to a separate file in commit 8acd13. This means that they won't be present in the XML schema generated by the engine. But some of these global bindings are needed by the SDK as well, in particular the setting that enables generation of "isSet" methods. This patch adds a bindings file specific to the SDK, that contains only the global bindings needed by the SDK. Change-Id: I946db48bee9d5b9fc6d33ade2fa26b0891f99aaa Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/pom.xml M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/Main.java M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/xsd/XsdCodegen.java A ovirt-engine-sdk-java-codegen/src/main/resources/api.xjb M ovirt-engine-sdk-java-codegen/src/main/resources/api.xsd 5 files changed, 39 insertions(+), 21 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I946db48bee9d5b9fc6d33ade2fa26b0891f99aaa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_3.3]: sdk: Remove trailing slashes from URL prefix
by juan.hernandez＠redhat.com 11 Feb '14

11 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Remove trailing slashes from URL prefix ...................................................................... sdk: Remove trailing slashes from URL prefix Currently we get the URL prefix of the RESTAPI from the URL provided by the user, without modification. If this prefix contains trailing slashes we end up building complete URLs that contain two slashes. For example, if the user writes this code: api = ovirtsdk.api.API(url='https://whatever/api/', ...) api.clusters.list() We send the following request to the server: GET /api//clusters HTTP/1.1 The server doesn't accept these two slashes and generates an error response. To fix this issue this patch removes trailing slashes from the URL prefix. Change-Id: I7a75aeccd7ba42fa3d49c4cebb9fc0ab3eff5cb9 Bug-Url: https://bugzilla.redhat.com/1063746 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 61ac75bc23f8aa9346ab774ee272894fb8259595) --- M src/codegen/templates/entrypointtemplate M src/ovirtsdk/api.py 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a75aeccd7ba42fa3d49c4cebb9fc0ab3eff5cb9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.3 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_3.4]: sdk: Remove trailing slashes from URL prefix
by juan.hernandez＠redhat.com 11 Feb '14

11 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Remove trailing slashes from URL prefix ...................................................................... sdk: Remove trailing slashes from URL prefix Currently we get the URL prefix of the RESTAPI from the URL provided by the user, without modification. If this prefix contains trailing slashes we end up building complete URLs that contain two slashes. For example, if the user writes this code: api = ovirtsdk.api.API(url='https://whatever/api/', ...) api.clusters.list() We send the following request to the server: GET /api//clusters HTTP/1.1 The server doesn't accept these two slashes and generates an error response. To fix this issue this patch removes trailing slashes from the URL prefix. Change-Id: I7a75aeccd7ba42fa3d49c4cebb9fc0ab3eff5cb9 Bug-Url: https://bugzilla.redhat.com/1063746 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 61ac75bc23f8aa9346ab774ee272894fb8259595) --- M src/codegen/templates/entrypointtemplate M src/ovirtsdk/api.py 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a75aeccd7ba42fa3d49c4cebb9fc0ab3eff5cb9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: Remove trailing slashes from URL prefix
by juan.hernandez＠redhat.com 11 Feb '14

11 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Remove trailing slashes from URL prefix ...................................................................... sdk: Remove trailing slashes from URL prefix Currently we get the URL prefix of the RESTAPI from the URL provided by the user, without modification. If this prefix contains trailing slashes we end up building complete URLs that contain two slashes. For example, if the user writes this code: api = ovirtsdk.api.API(url='https://whatever/api/', ...) api.clusters.list() We send the following request to the server: GET /api//clusters HTTP/1.1 The server doesn't accept these two slashes and generates an error response. To fix this issue this patch removes trailing slashes from the URL prefix. Change-Id: I7a75aeccd7ba42fa3d49c4cebb9fc0ab3eff5cb9 Bug-Url: https://bugzilla.redhat.com/1063746 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/codegen/templates/entrypointtemplate M src/ovirtsdk/api.py 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a75aeccd7ba42fa3d49c4cebb9fc0ab3eff5cb9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in gerrit-admin[master]: Added first python hooks and libs
by dcaroest＠redhat.com 11 Feb '14

11 Feb '14

David Caro has submitted this change and it was merged. Change subject: Added first python hooks and libs ...................................................................... Added first python hooks and libs * Added basic config.py lib * Added basic gerrit.py lib * Added hook to check if the patch is merged on all newer branches when in stable branch Change-Id: I985113f5a228ccc128eaad3dbf45c918b7fc093a Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A hooks/bz/patchset-created.warn_if_not_merged_to_previous_branch M hooks/hook-dispatcher A hooks/lib/config.py A hooks/lib/gerrit.py 4 files changed, 252 insertions(+), 1 deletion(-) Approvals: David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24208 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I985113f5a228ccc128eaad3dbf45c918b7fc093a Gerrit-PatchSet: 4 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Fix NPE in DbUserCacheManager
by iheim＠redhat.com 11 Feb '14

11 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Fix NPE in DbUserCacheManager ...................................................................... core: Fix NPE in DbUserCacheManager Fix NPE in DbUserCacheManager causing inability to login as admin@internal if LDAP domain has been add prior to first execution of engine. Change-Id: I7703d446841bea47222a066fe0a2b51827f12430 Bug-Url: https://bugzilla.redhat.com/1063276 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Itamar Heim: Verified; Looks good to me, approved Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7703d446841bea47222a066fe0a2b51827f12430 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: spec: upgrade only from >= 3.3.2
by iheim＠redhat.com 11 Feb '14

11 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: spec: upgrade only from >= 3.3.2 ...................................................................... packaging: spec: upgrade only from >= 3.3.2 Upgrade to 3.4.0 is allowed only from >= 3.3.2. Avoid to pull in a version of ovirt-engine-setup that will need to be downgraded in order to allow the upgrade from a legacy version. Change-Id: I151c5b1156f4c9a91da0e5bd3e6d52149ae65cd5 Bug-Url: https://bugzilla.redhat.com/1054080 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23665 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I151c5b1156f4c9a91da0e5bd3e6d52149ae65cd5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0