- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: frontend: Remove redundant classes
by tnisan＠redhat.com 10 Feb '14

10 Feb '14

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Remove redundant classes ...................................................................... frontend: Remove redundant classes Those classes are no longer in use and are therefore redundant Change-Id: I486d021418fb076fac2e66c5e868fccc5c7526b7 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- D frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/CharEncoding.java D frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/DecoderException.java D frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/EncoderException.java 3 files changed, 0 insertions(+), 310 deletions(-) Approvals: Tal Nisan: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24278 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I486d021418fb076fac2e66c5e868fccc5c7526b7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Remove unused methods in StringUtils
by tnisan＠redhat.com 10 Feb '14

10 Feb '14

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Remove unused methods in StringUtils ...................................................................... frontend: Remove unused methods in StringUtils Change-Id: I1876fb6cfdb6fe8f057da2a45bd3c46cb32bf4ac Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/StringUtils.java 1 file changed, 0 insertions(+), 260 deletions(-) Approvals: Tal Nisan: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1876fb6cfdb6fe8f057da2a45bd3c46cb32bf4ac Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix NPE in DbUserCacheManager
by yzaslavs＠redhat.com 10 Feb '14

10 Feb '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fix NPE in DbUserCacheManager ...................................................................... core: Fix NPE in DbUserCacheManager Fix NPE in DbUserCacheManager causing inability to login as admin@internal if LDAP domain has been add prior to first execution of engine. Change-Id: I7703d446841bea47222a066fe0a2b51827f12430 Bug-Url: https://bugzilla.redhat.com/1063276 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24277 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7703d446841bea47222a066fe0a2b51827f12430 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal: fix motd
by awels＠redhat.com 10 Feb '14

10 Feb '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal: fix motd ...................................................................... userportal: fix motd - Fixed MOTD panel being modal and disabling the rest of the dialog. - Fixed flicker of MOTD panel when you have no MOTD. - Fixed MOTD showing during login process if you have a MOTD set. Change-Id: I048cdf6029617dda39357d876abd250bf9ae9a46 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063041 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.java 1 file changed, 11 insertions(+), 16 deletions(-) Approvals: Alexander Wels: Verified Greg Sheremeta: Looks good to me, but someone else must approve Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I048cdf6029617dda39357d876abd250bf9ae9a46 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: added missing edit_pool helpTag
by awels＠redhat.com 10 Feb '14

10 Feb '14

Alexander Wels has submitted this change and it was merged. Change subject: engine: added missing edit_pool helpTag ...................................................................... engine: added missing edit_pool helpTag Added back the missing edit_pool hashName and helpTag. Somehow it was removed in http://gerrit.ovirt.org/#/c/15048/ Change-Id: I623136a3630fca1cd7b829972d537d02ff3d1c52 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Alexander Wels: Looks good to me, but someone else must approve Einav Cohen: Looks good to me, but someone else must approve Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/24206 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I623136a3630fca1cd7b829972d537d02ff3d1c52 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: spec: upgrade only from >= 3.3.2
by sbonazzo＠redhat.com 10 Feb '14

10 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: upgrade only from >= 3.3.2 ...................................................................... packaging: spec: upgrade only from >= 3.3.2 Upgrade to 3.5.0 is allowed only from >= 3.3.2. Avoid to pull in a version of ovirt-engine-setup that will need to be downgraded in order to allow the upgrade from a legacy version. Change-Id: I151c5b1156f4c9a91da0e5bd3e6d52149ae65cd5 Bug-Url: https://bugzilla.redhat.com/1054080 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I151c5b1156f4c9a91da0e5bd3e6d52149ae65cd5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: fix 404 regression for help files
by awels＠redhat.com 10 Feb '14

10 Feb '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: fix 404 regression for help files ...................................................................... userportal, webadmin: fix 404 regression for help files Patch http://gerrit.ovirt.org/#/c/21052/ introduced a regression where if no help mapping json files are found, a 404 is served to the UI and logged. This fixes that by sending back an empty JSON string. There was also a path mapping bug in patch http://gerrit.ovirt.org/#/c/21052/ and this fixes that as well. Change-Id: I219e986ac45e7a05801bd9b519a006a429e5f82f Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M backend/manager/modules/docs/src/main/java/org/ovirt/engine/docs/utils/servlet/HelpTagJsonServlet.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java 4 files changed, 18 insertions(+), 9 deletions(-) Approvals: Alexander Wels: Looks good to me, but someone else must approve Greg Sheremeta: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I219e986ac45e7a05801bd9b519a006a429e5f82f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: refactor failure to run vm flow - part 3
by ofrenkel＠redhat.com 10 Feb '14

10 Feb '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: refactor failure to run vm flow - part 3 ...................................................................... core: refactor failure to run vm flow - part 3 Rename RunVmCommandBase#failToRunVm with runningFailed, and put other things that should always be executed when the async command fails so this method will be equivalent of RunVmCommandBase#runningSucceeded in case of a failure. Change-Id: I1e24011ea31e504439614bf2876cf81a47d3d3c1 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java 3 files changed, 10 insertions(+), 12 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/24118 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e24011ea31e504439614bf2876cf81a47d3d3c1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi : ovirt shell show vm' not returning all guest attri...
by iheim＠redhat.com 10 Feb '14

10 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: restapi : ovirt shell show vm' not returning all guest attributes ...................................................................... restapi : ovirt shell show vm' not returning all guest attributes In oVirt-shell 'show vm <guest name>' does not return all attributes / settings for the given guest. Document the "All-Content" header in all the resources that support it. Change-Id: I65bd2a88deadde3444778e50ec6655850c1d2cc4 Bug-Url: https://bugzilla.redhat.com/1062434 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65bd2a88deadde3444778e50ec6655850c1d2cc4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: userportal, webadmin: synchronize grid refresh
by iheim＠redhat.com 10 Feb '14

10 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: userportal,webadmin: synchronize grid refresh ...................................................................... userportal,webadmin: synchronize grid refresh - Updated code to have refresh rates across tabs and sub tabs be identical. So if you switch the refresh rate on lets say the VM tab, the same refresh rate is used for all other tabs. As well as affecting the refresh rate of the events/alerts and tasks list. - Fixed duplicate timers being created for EventListModels and its sub classes. - Fixed each GridTimer having its own EventBus, which then didn't actually communicate with the rest of the system. Now all the GridTimers have the correct EventBus. Change-Id: I8742785cb9b3d890c39859586b03cd53c64b31e5 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=879662 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/BaseRefreshPanel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/GridController.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/GridTimer.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmMonitorModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostInterfacePresenter.java 8 files changed, 147 insertions(+), 72 deletions(-) Approvals: Alexander Wels: Verified Itamar Heim: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24213 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8742785cb9b3d890c39859586b03cd53c64b31e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0