- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Duplicate name 'nics' in schema
by oliel＠redhat.com 10 Feb '14

10 Feb '14

Ori Liel has submitted this change and it was merged. Change subject: restapi: Duplicate name 'nics' in schema ...................................................................... restapi: Duplicate name 'nics' in schema QA tools assumes unique element names in the schema (api.xsd), so naming inner element 'nics', which outer element by this name already exists in the schema causes failure. Again, the failure is in the QA tool, and is not a real code or business faliure. Nevertheless, it's enough of a reason to change the element's name. Bug-Url: http://bugzilla.redhat.com/1063187 Change-Id: I97a9b1b727053349e3f24c65ffabd69316af1c51 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 3 files changed, 10 insertions(+), 10 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24261 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97a9b1b727053349e3f24c65ffabd69316af1c51 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Initialize MAC pool partially
by mkolesni＠redhat.com 10 Feb '14

10 Feb '14

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Initialize MAC pool partially ...................................................................... engine: Initialize MAC pool partially If MAC pool exceeds the maximum then we will initialize it until its full. An error is being written to the log in this case. The partial initialization will prevent an OOM in case of a really big range (not entirely though, this will be fixed in the future). Change-Id: I0547509eb81a51599e2342503c9f108df1fa47c7 Bug-Url: https://bugzilla.redhat.com/1056803 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java 2 files changed, 14 insertions(+), 10 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24247 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0547509eb81a51599e2342503c9f108df1fa47c7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fixing findbugs in AddGroupCommand
by yzaslavs＠redhat.com 10 Feb '14

10 Feb '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: fixing findbugs in AddGroupCommand ...................................................................... core: fixing findbugs in AddGroupCommand Change-Id: I801596dc43aa6f684246670d1dd40aeb7aafc47f signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGroupCommand.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24251 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I801596dc43aa6f684246670d1dd40aeb7aafc47f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-3.3]: packaging: bumped release number
by ydary＠redhat.com 10 Feb '14

10 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: bumped release number ...................................................................... packaging: bumped release number Change-Id: If5391acabbc5e6786d1b5a621e8fd627de3fc620 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M version.mak 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24253 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5391acabbc5e6786d1b5a621e8fd627de3fc620 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Validate that IDE disk is not read-only
by mlipchuk＠redhat.com 10 Feb '14

10 Feb '14

Maor Lipchuk has submitted this change and it was merged. Change subject: engine: Validate that IDE disk is not read-only ...................................................................... engine: Validate that IDE disk is not read-only Real IDE disks can't be read-only therefore Engine has to validate it. Change-Id: I441362adf2f4833b034ede4093fc8195debd2ed5 Bug-Url: https://bugzilla.redhat.com/1057546 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 103 insertions(+), 15 deletions(-) Approvals: Sergey Gotliv: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I441362adf2f4833b034ede4093fc8195debd2ed5 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Use getFileStats to retrieve iso and floppy files
by mlipchuk＠redhat.com 10 Feb '14

10 Feb '14

Maor Lipchuk has submitted this change and it was merged. Change subject: engine: Use getFileStats to retrieve iso and floppy files ...................................................................... engine: Use getFileStats to retrieve iso and floppy files VDSM introduced new API getFileStats in 3.4 which returns statistics of all files in the domain filtered according to pattern. Now Engine starts using this new API, because file statistics are significantly better in comparison with the existing getIsoList and getFileList and allow Engine to provide additional information in UI, for example a file size. Change-Id: I735d2c9343fe791e0890b4a6cc9f12c74462b3f0 Bug-Url: https://bugzilla.redhat.com/1005889 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetFileStatsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/FileStatsReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetFloppyListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetFileStatsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HsmGetIsoListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 15 files changed, 177 insertions(+), 29 deletions(-) Approvals: Sergey Gotliv: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21524 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I735d2c9343fe791e0890b4a6cc9f12c74462b3f0 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: RSDL generation at build time
by oliel＠redhat.com 10 Feb '14

10 Feb '14

Ori Liel has submitted this change and it was merged. Change subject: restapi: RSDL generation at build time ...................................................................... restapi: RSDL generation at build time As of this patch, compiling rest-api with maven will generate rsdl.xml, rsdl_gluster.xml files, store them in: .../target/classes, and package them into restapi-definition.jar. This will make rsdl available without a running application server, which makes for much more convenient sdk/cli project generation. At runtime, instead of generating the RSDL, the application will load the saved rsdl file and use it. Change-Id: Idc13fb2feab8d065f38cecbda7da568463c30453 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/resource/AbstractActionableResource.java M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/resource/AbstractUpdatableResource.java M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/resource/BaseActionResource.java M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/CompletenessAssertor.java M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/MutabilityAssertor.java M backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/util/LinkHelperTest.java M backend/manager/modules/restapi/interface/definition/pom.xml R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/Action.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/Argument.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/Body.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/GeneralMetadataBuilder.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/MetaData.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/ParamData.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/Request.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlBuilder.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlManager.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/SchemaBuilder.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/Signature.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ApiRootLinksCreator.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/FileUtils.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ReflectionHelper.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml R backend/manager/modules/restapi/interface/definition/src/test/java/org/ovirt/engine/api/utils/ReflectionHelperTest.java M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendActionableResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendAssignedTagsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendAsyncStatusResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDomainResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUsersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/JaxbExceptionMapper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/JsonExceptionMapper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/UsageFinder.java D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/LinkBuilder.java D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/ApiRootLinksCreator.java M ear/pom.xml M pom.xml 50 files changed, 348 insertions(+), 291 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc13fb2feab8d065f38cecbda7da568463c30453 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[master]: packaging: spec: fix distro macros
by sbonazzo＠redhat.com 10 Feb '14

10 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: fix distro macros ...................................................................... packaging: spec: fix distro macros Fix distro macros causing CentOS build failures. Change-Id: I61283cbf6fc5697f0dd80f92648b69287921bb30 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-log-collector.spec.in 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24248 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61283cbf6fc5697f0dd80f92648b69287921bb30 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix coverity issues
by yzaslavs＠redhat.com 10 Feb '14

10 Feb '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fix coverity issues ...................................................................... core: Fix coverity issues These issues were introduced due authentication refactoring Change-Id: I57ff7df3075d4ca36a50016c6786ca8a69cee3e0 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/internal/InternalDirectory.java M backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/nop/NopDirectory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/authentication/provisional/ProvisionalDirectory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AdGroupsHandlingCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDirectoryGroupByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDirectoryUserByIdQuery.java M backend/manager/modules/common/exclude-filters.xml M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/authentication/AuthenticationFilter.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/authentication/Configuration.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/authentication/Directory.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/authentication/Manager.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/authentication/ConfigurationTest.java 13 files changed, 80 insertions(+), 53 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57ff7df3075d4ca36a50016c6786ca8a69cee3e0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: Default DC & Cluster has fixed UUIDs
by iheim＠redhat.com 10 Feb '14

10 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: Default DC & Cluster has fixed UUIDs ...................................................................... Default DC & Cluster has fixed UUIDs This patch modifies the uuid_generate_v1 function to have some randomization in its least significant part so different engines will have different UUID values from the generated default DC UUID and default Cluster. In addition This patch fixes a static data inserted as Cluster UUID for the blank template. I had tested generation of million UUIDs to verify its uniqueness just for the case although the generation of the 29 most significant numbers are still done by the sequence and supposed to be unique. Change-Id: Ic5650fe1586fae320484f8cd36698491554efa57 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1026885 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/create_functions.sql M packaging/dbscripts/insert_data.sql 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24087 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5650fe1586fae320484f8cd36698491554efa57 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0