- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: fixing integer out of range exception in search
by iheim＠redhat.com 10 Feb '14

10 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: fixing integer out of range exception in search ...................................................................... fixing integer out of range exception in search The change [1] introduced to return all rows when max=-1 generates an integer overflow in the calculation of the indexes used for paging. For example, in an environment with one data center running a query with "page 2" generates the following error: <fault><reason>Operation Failed</reason><detail>statementcallback; sql [select * from (select * from storage pool where ( id in (select storage pool with storage domain.id from storage pool with storage domain )) order by name asc ) as t1 offset (-2147483648 -1) limit 2147483647]; error: integer out of range; nested exception is org.postgresql.util.psqlexception: error: integer out of range</detail></fault> The problem is in SyntaxChecker.java, in line 954, where we do the following: result = StringFormat.format(pagingSyntax, (page - 1) * syntax.getMaxCount() + 1, syntax.getMaxCount()); This multiplication results in Integer.MAX_VALUE + 1, which overflows the integer and results in the value -2147483648. This affect all uses of queries with paging. [1] http://gerrit.ovirt.org/21375 Change-Id: I518dfdfff93dde28d9741d5e333c695239b7e7d2 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 2 files changed, 10 insertions(+), 5 deletions(-) Approvals: Eli Mesika: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24240 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I518dfdfff93dde28d9741d5e333c695239b7e7d2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: Maintenance mode shall persist after reboot
by iheim＠redhat.com 10 Feb '14

10 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: Maintenance mode shall persist after reboot ...................................................................... Maintenance mode shall persist after reboot Fencing operations can occur as a result of manual operation or automatically after Host was in non-responsive state and has been restarted after waiting the grace-time for it to reconnect. In the case that Host was in Maintenance 1) If it was manually started , it should stay in maintenance 2) If it was manually restarted it should change first to reboot and move back to Maintenance when the Host is ON again. In the case that Host is restarted from the non-responsive treatment, it should go to reboot -> non responding -> up as before This patch address 1) and 2) above by 1) Setting the parent command in VdsNotRespondingTreatmentComman parameters so the Restart command can distinguish between manual Restart and automatic restart 2) Add a flag to FenceVdsActionParameters to mark if Host should be moved again to Maintenance after it was restarted 3) Use The Host last status to skip changing the status in case of 1) 4) Use the flag described in 2) to set Host again to Maintenance in case that Host was manually rebooted while in the Maintenance status. Change-Id: I3dcb06b18c4af13876d1fb3043fb5b6cc5c6a74a https://bugzilla.redhat.com/show_bug.cgi?id=917039 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StartVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/FenceVdsActionParameters.java 5 files changed, 24 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3dcb06b18c4af13876d1fb3043fb5b6cc5c6a74a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Set proper severity to a failed command
by iheim＠redhat.com 09 Feb '14

09 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Set proper severity to a failed command ...................................................................... engine: Set proper severity to a failed command The audit log of commit networks changes failure should be changed to error to reflect its true nature. Change-Id: Ib7254bc1506d57edc158d034c7d06fe6e1e9c5c7 Bug-Url: https://bugzilla.redhat.com/1061727 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/24237 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7254bc1506d57edc158d034c7d06fe6e1e9c5c7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Do not invoke CommitNetworkChanges if not needed
by iheim＠redhat.com 09 Feb '14

09 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Do not invoke CommitNetworkChanges if not needed ...................................................................... engine: Do not invoke CommitNetworkChanges if not needed There is no reason to sent persist network changes if no changes were detected via setupNetworks. Change-Id: Ie06d43ffaf899af4749bb1221764d40fab10a572 Bug-Url: https://bugzilla.redhat.com/1061724 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentSetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java 2 files changed, 15 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/24236 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie06d43ffaf899af4749bb1221764d40fab10a572 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Return setup networks resolution internally
by masayag＠redhat.com 09 Feb '14

09 Feb '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Return setup networks resolution internally ...................................................................... engine: Return setup networks resolution internally The resolution of setup networks is examined internally and seems to cause issues for the UI when an unexpected return value is retrieved. Therefore modifying the resolution to be reported when the setup networks command is being invoked internally. Change-Id: Iaab337194c3458a20318da6ed07e27f7ee701c72 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/24238 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaab337194c3458a20318da6ed07e27f7ee701c72 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core : No email notification sent when host recovers from pr...
by iheim＠redhat.com 09 Feb '14

09 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core : No email notification sent when host recovers from previously reported condition ...................................................................... core : No email notification sent when host recovers from previously reported condition There is no option in event manager to subscribe for 'Host is responsive' event. Users can choose to receive email notifications for several host conditions listed under "Host Event" section of event notifications. When a user has chosen a specific condition and such condition occurs the user receives an email notification. When such condition is resolved or disappears the user does not receive any email notification alerting him/her that the previously reported condition has been solved is no longer present. Change-Id: I93038f1ef81aa82643eb1b0e4bf9bc523a28b22c Bug-Url: https://bugzilla.redhat.com/1013631 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- A packaging/dbscripts/upgrade/03_04_0560_map_vds_detected_to_event_map.sql 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/24170 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93038f1ef81aa82643eb1b0e4bf9bc523a28b22c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: disk live migrate - snapshot only on migrated disks
by iheim＠redhat.com 09 Feb '14

09 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: disk live migrate - snapshot only on migrated disks ...................................................................... core: disk live migrate - snapshot only on migrated disks LiveSnapshotTaskHandler: Take a snapshot only on the migrated disks (by utilizing single disk snapshot feature). Change-Id: I21387ef38b5f86806b985b8dffb49d5b7952a628 Bug-Url: https://bugzilla.redhat.com/969789 Bug-Url: https://bugzilla.redhat.com/1056922 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java 2 files changed, 21 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21387ef38b5f86806b985b8dffb49d5b7952a628 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: allow attaching iso and export SDs to local DC
by iheim＠redhat.com 09 Feb '14

09 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: allow attaching iso and export SDs to local DC ...................................................................... core: allow attaching iso and export SDs to local DC Attaching an ISO or export domain to local DC should not be blocked. Change-Id: I1ba6619b3b2858ab60ffb4df4824ae51467a2ecd Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/24232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ba6619b3b2858ab60ffb4df4824ae51467a2ecd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: guide me local cluster - added note on sd
by iheim＠redhat.com 09 Feb '14

09 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: guide me local cluster - added note on sd ...................................................................... webadmin: guide me local cluster - added note on sd Local Cluster/DC GuideMe dialog: * Replaced 'Fully configured and ready for use' message with 'Configuration completed' - as in shared storage. * Added a note that a local storage domain must be attached to the DC and activated. Change-Id: Ic2f3f59cdcf30721bbefc9bb84d97973faa36f99 Bug-Url: https://bugzilla.redhat.com/1023484 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/GuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.ui.xml 6 files changed, 40 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/24227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2f3f59cdcf30721bbefc9bb84d97973faa36f99 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Exclude read-only disks when creating a snapshot
by iheim＠redhat.com 09 Feb '14

09 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Exclude read-only disks when creating a snapshot ...................................................................... engine: Exclude read-only disks when creating a snapshot Change-Id: Ib05f61e5a61616908bd31aa0fc3ee3e477655e67 Bug-Url: https://bugzilla.redhat.com/1056169 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sergey Gotliv: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib05f61e5a61616908bd31aa0fc3ee3e477655e67 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0