- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Add confirmation window when deactivating a VM disk
by derez＠redhat.com 09 Feb '14

09 Feb '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Add confirmation window when deactivating a VM disk ...................................................................... webadmin: Add confirmation window when deactivating a VM disk Change-Id: I13d9aa5386efd676d7b9d043c72c921ac3f07bf6 Bug-Url: https://bugzilla.redhat.com/1038980 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 71 insertions(+), 20 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13d9aa5386efd676d7b9d043c72c921ac3f07bf6 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: from new cluster GuideMe form adding host by pk fails
by derez＠redhat.com 09 Feb '14

09 Feb '14

Daniel Erez has submitted this change and it was merged. Change subject: ui: from new cluster GuideMe form adding host by pk fails ...................................................................... ui: from new cluster GuideMe form adding host by pk fails Adding host by public key failed on "cannot add host with empty password" because the authentication method was not set properly to the Add host request. Change-Id: I7001e0766d52ac92fe17d6e84fbc42767007e5eb Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057575 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yaniv Bronhaim: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7001e0766d52ac92fe17d6e84fbc42767007e5eb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: new vm - fix host selection on cluster change
by derez＠redhat.com 09 Feb '14

09 Feb '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: new vm - fix host selection on cluster change ...................................................................... webadmin: new vm - fix host selection on cluster change When changing dc/cluster in VM dialog, the selected host was empty as it dependeds on the ' oldDefaultHost' Fixed by ensuring that an item from the hosts list is selected. Change-Id: Icd80711a9c1557743946445196c3c0015d94fc26 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/24077 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd80711a9c1557743946445196c3c0015d94fc26 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: confirmation popup - ensure key event bubbling
by derez＠redhat.com 09 Feb '14

09 Feb '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: confirmation popup - ensure key event bubbling ...................................................................... webadmin: confirmation popup - ensure key event bubbling Catch ONKEYDOWN event on DialogBoxWithKeyHandlers for invoking relevant command when pressing enter\esc key. The change is needed for confirmation dialogs that don't contain widgets that extend FocusWidget (which adds a DomHandler for KeyPressEvent). Change-Id: I0f31dea9a5ea502879d450c3ed45aa0d53c4adc2 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/DialogBoxWithKeyHandlers.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f31dea9a5ea502879d450c3ed45aa0d53c4adc2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: improve audit log when creating diskless template
by ofrenkel＠redhat.com 09 Feb '14

09 Feb '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: improve audit log when creating diskless template ...................................................................... core: improve audit log when creating diskless template Change-Id: I99c88bbc84e19fef06d54bd25567500b056d6e20 Bug-Url: https://bugzilla.redhat.com/1053544 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 17 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/24155 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99c88bbc84e19fef06d54bd25567500b056d6e20 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Reduce redundant vm fetch from db
by masayag＠redhat.com 09 Feb '14

09 Feb '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Reduce redundant vm fetch from db ...................................................................... engine: Reduce redundant vm fetch from db There is no justification for fetching vm static when the entire VM entity is already retrieved. Change-Id: Ia0da7c8eee009c49c000e47b88d1f08611877e2c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/24084 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0da7c8eee009c49c000e47b88d1f08611877e2c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix typo
by masayag＠redhat.com 09 Feb '14

09 Feb '14

Moti Asayag has submitted this change and it was merged. Change subject: core: Fix typo ...................................................................... core: Fix typo Change-Id: I8e4ec0c3a0e8cb2e8b18a8b5b34f9c4f91af0e83 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/24049 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e4ec0c3a0e8cb2e8b18a8b5b34f9c4f91af0e83 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin, userportal: Small ScrollableTabBar improvements
by vszocs＠redhat.com 07 Feb '14

07 Feb '14

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Small ScrollableTabBar improvements ...................................................................... webadmin,userportal: Small ScrollableTabBar improvements 1. ScrollableTabBarView: - removed "implements HasLoadHandlers" - removed fireEvent + addLoadHandler methods - the "+1 width adjustment" comment moved to appropriate location 2. ModelBoundTab: - added setAccessible override that fires TabAccessibleChangeEvent whenever tab's accessibility changes Change-Id: Ib7ffdb2827067b35320fd43d37db80479df6605d Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/ScrollableTabBarView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/ModelBoundTab.java 2 files changed, 15 insertions(+), 19 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Looks good to me, but someone else must approve Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23104 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7ffdb2827067b35320fd43d37db80479df6605d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin, userportal: Use X-UA-Compatible with IE=10
by vszocs＠redhat.com 07 Feb '14

07 Feb '14

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Use X-UA-Compatible with IE=10 ...................................................................... webadmin,userportal: Use X-UA-Compatible with IE=10 This patch is meant to address problems when loading GWT applications in Internet Explorer 11. IE11 user agent string is missing the "MSIE" part but instead includes the "like Gecko" part. For example: Mozilla/5.0 (Windows NT 6.3; Trident/7.0; rv:11.0) like Gecko This causes GWT selector script (*.nocache.js) to pick and load Firefox (Gecko) permutation of GWT application. Since IE11 has issues with Gecko permutation [1], the workaround is to tell IE11 to render page as IE10: <meta http-equiv="X-UA-Compatible" content="IE=10"> [1] http://code.google.com/p/google-web-toolkit/issues/detail?id=8228 This shouldn't affect behavior of GWT applications when loaded in earlier Internet Explorer versions: - IE8: selector script uses 'ie8' permutation - IE9: selector script uses 'ie9' permutation - IE10: selector script uses highest available permutation ('ie9') Note: there might be issues with IE10 + 'ie9' GWT permutation combination. These issues should be addressed as part of GWT upgrade which should add proper support (permutation) for IE10. Change-Id: Ifad89cbd057fc63944a09478ed92e29c13a49e04 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifad89cbd057fc63944a09478ed92e29c13a49e04 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: fixed findbugs error in HelpTagJsonSer...
by awels＠redhat.com 07 Feb '14

07 Feb '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: fixed findbugs error in HelpTagJsonServlet ...................................................................... userportal, webadmin: fixed findbugs error in HelpTagJsonServlet Fixed findbugs error in HelpTagJsonServlet by wrapping the FileInputStream open in the try (new Java 7 syntax) Change-Id: Iafa02467e3b54af6254481e16fdcd26c7feab89d Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M backend/manager/modules/docs/src/main/java/org/ovirt/engine/docs/utils/servlet/HelpTagJsonServlet.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/24207 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafa02467e3b54af6254481e16fdcd26c7feab89d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0