- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: engine: Check VDSM supported clusters to deserialize QoS
by iheim＠redhat.com 04 Feb '14

04 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Check VDSM supported clusters to deserialize QoS ...................................................................... engine: Check VDSM supported clusters to deserialize QoS It is not in fact correct check the cluster's compatibility version to see if Host Network QoS is supported, since GetVdsCapabilities should work even if the VDSM is too old for the cluster's compatibility version, and in case there's QoS configured on a host we'd want it to be reported even if it resides in an older cluster. Change-Id: I8a5303222d51459019c1aaaf6754867cd234fe9d Bug-Url: https://bugzilla.redhat.com/1056155 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23752 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a5303222d51459019c1aaaf6754867cd234fe9d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: Change used configured range for display port to 5900-6923
by iheim＠redhat.com 04 Feb '14

04 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: Change used configured range for display port to 5900-6923 ...................................................................... Change used configured range for display port to 5900-6923 this changes the AIO configuration and the database vdc_options for iptables rules. This patch goes together with http://gerrit.ovirt.org/#/c/23940 Change-Id: I1b93517965437b74b88e092d666fe2e91c43a6d3 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1052162 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/firewalld/aio/ovirt-aio.xml.in 2 files changed, 14 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Eli Mesika: Looks good to me, approved Vinzenz Feenstra: Verified -- To view, visit http://gerrit.ovirt.org/23941 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b93517965437b74b88e092d666fe2e91c43a6d3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix templates search query
by emesika＠redhat.com 04 Feb '14

04 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Fix templates search query ...................................................................... core: Fix templates search query This patch improves the performance of the SearchQuery mechanism for the vm_templates view Change-Id: I0ef77348bc6126f5b038e40d949de6d5804def5f Bug-Url: https://bugzilla.redhat.com/1057561 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 2 files changed, 16 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/23811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ef77348bc6126f5b038e40d949de6d5804def5f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Check VDSM supported clusters to deserialize QoS
by masayag＠redhat.com 04 Feb '14

04 Feb '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Check VDSM supported clusters to deserialize QoS ...................................................................... engine: Check VDSM supported clusters to deserialize QoS It is not in fact correct check the cluster's compatibility version to see if Host Network QoS is supported, since GetVdsCapabilities should work even if the VDSM is too old for the cluster's compatibility version, and in case there's QoS configured on a host we'd want it to be reported even if it resides in an older cluster. Change-Id: I8a5303222d51459019c1aaaf6754867cd234fe9d Bug-Url: https://bugzilla.redhat.com/1056155 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a5303222d51459019c1aaaf6754867cd234fe9d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Improve audit_log seach query
by emesika＠redhat.com 04 Feb '14

04 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Improve audit_log seach query ...................................................................... core: Improve audit_log seach query This patch improves the performance of the SearchQuery mechanism for the audit_log table. Change-Id: I396a90d63a10fc049a37e4792d3e558ff2a7fea3 Bug-Url: https://bugzilla.redhat.com/1056064 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 2 files changed, 46 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/23567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I396a90d63a10fc049a37e4792d3e558ff2a7fea3 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: support classless IN-ADDR.ARPA delegation
by sbonazzo＠redhat.com 04 Feb '14

04 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: support classless IN-ADDR.ARPA delegation ...................................................................... packaging: setup: support classless IN-ADDR.ARPA delegation support reverse query checking for RFC2317("Classless IN-ADDR.ARPA delegation") type domain host. recent version requires to set local host domain in /etc/hosts or private DNS server. this update treats sub-delegated reverse zone, which uses CNAME to forward NS. Change-Id: I9f65fbc27992ddae0b3d01e19d317a2abe39db7b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> Signed-off-by: Mark Kachi <love.cairn(a)gmail.com> --- M packaging/setup/plugins/ovirt-engine-setup/base/network/hostname.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Mark Kachi: Verified -- To view, visit http://gerrit.ovirt.org/23818 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f65fbc27992ddae0b3d01e19d317a2abe39db7b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mark Kachi <love.cairn(a)gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Mark Kachi <love.cairn(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add warning when modifying management network
by derez＠redhat.com 04 Feb '14

04 Feb '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Add warning when modifying management network ...................................................................... webadmin: Add warning when modifying management network Added warning that certain changes in the management network's properties could lead to loss of connectivity to hosts in the DC. Change-Id: Icf768a00fc78335227e77f23ed6b9ffe1aac39ec Bug-Url: https://bugzilla.redhat.com/906359 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 33 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf768a00fc78335227e77f23ed6b9ffe1aac39ec Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: fix cleaning up orphan tasks
by kmayilsa＠redhat.com 04 Feb '14

04 Feb '14

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: fix cleaning up orphan tasks ...................................................................... gluster: fix cleaning up orphan tasks When there is rebalance task in progress and 'task list' is failed in vdsm for some reason, engine should not cleanup this task and move to UNKNOWN. Change-Id: I4f9bb53e5c2be194efeba966355d0245bcc18384 Bug-Url: https://bugzilla.redhat.com/1060138 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJobTest.java 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Verified Sahina Bose: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f9bb53e5c2be194efeba966355d0245bcc18384 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: _commands -> _setup
by ydary＠redhat.com 04 Feb '14

04 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: _commands -> _setup ...................................................................... packaging: setup: _commands -> _setup Probably copied from common. Change-Id: I1f456e0924cc5f3f3e85a185690de4fe10cad1ec Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/db/connection.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24005 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f456e0924cc5f3f3e85a185690de4fe10cad1ec Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi: Validate unsigned short integers correctly
by iheim＠redhat.com 03 Feb '14

03 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: restapi: Validate unsigned short integers correctly ...................................................................... restapi: Validate unsigned short integers correctly Recently, in commit 14e9da, we introduced a validation of integer values provided to the RESTAPI in order to avoid overflows of Java integer types. This validation doesn't work correctly for unsigned short integers, as it compares them to the maximum signed short integer. This has the side effect of rejecting requests that include port numbers greater than 32767. A notable example is the VDSM port number 54321. This patch changes the validation so that it will validate unsigned short integers correctly, comparing them to 65535. Change-Id: I49e64d5f55c32463950e648aa1cd8c3084017da6 Bug-Url: https://bugzilla.redhat.com/1000796 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/IntegerParser.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 2 files changed, 54 insertions(+), 18 deletions(-) Approvals: Ravi Nori: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23950 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49e64d5f55c32463950e648aa1cd8c3084017da6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0