- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: engine: Add config value for Gluster task support
by iheim＠redhat.com 03 Feb '14

03 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Add config value for Gluster task support ...................................................................... engine: Add config value for Gluster task support Added database config value for gluster task support. Change-Id: I9a62b558a91c9b52b6a8d7a892e0420f2d1ec51e Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a62b558a91c9b52b6a8d7a892e0420f2d1ec51e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: AddRemoveRowWidget to only add ghost entry if no i...
by iheim＠redhat.com 03 Feb '14

03 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: AddRemoveRowWidget to only add ghost entry if no items ...................................................................... webadmin: AddRemoveRowWidget to only add ghost entry if no items If there are items in the passed collection, then there's no need to add a ghost entry by default, but only have a plus button next to the last entry. Change-Id: I120e9183d739213b3a26227cc8c3b738ee3b54dc Bug-Url: https://bugzilla.redhat.com/1020861 Bug-Url: https://bugzilla.redhat.com/1058205 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java 2 files changed, 25 insertions(+), 15 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/23826 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I120e9183d739213b3a26227cc8c3b738ee3b54dc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Add tests to StorageHandlingCommandBaseTest
by iheim＠redhat.com 03 Feb '14

03 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Add tests to StorageHandlingCommandBaseTest ...................................................................... core: Add tests to StorageHandlingCommandBaseTest Since the removal of DC type it's important to have test to test the logic of whether attachment of domains to a pool is allowed, this patch adds tests for the StorageHandlingCommandBase which holds most of the logic that determines attachment is allowed Change-Id: I97e45957f7ff0fe4c9e7d88e0d8dbab7e874c79b Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Relates-To: https://bugzilla.redhat.com/1038053 --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CanDoActionTestUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java 2 files changed, 212 insertions(+), 18 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23960 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97e45957f7ff0fe4c9e7d88e0d8dbab7e874c79b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: distro-rpm: fix typo in new package detection
by iheim＠redhat.com 03 Feb '14

03 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: distro-rpm: fix typo in new package detection ...................................................................... packaging: setup: distro-rpm: fix typo in new package detection Change-Id: Ibb2aa3ce1f1d9f0d4c5b250e0f70cbe22e931b71 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb2aa3ce1f1d9f0d4c5b250e0f70cbe22e931b71 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Filter storage domains of different type in live s...
by iheim＠redhat.com 03 Feb '14

03 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Filter storage domains of different type in live storage migration ...................................................................... webadmin: Filter storage domains of different type in live storage migration This change filters the destination domain by the type of the source domain when performing live storage migration, if the source domain is a file domain, the destination domains that will appear will be only file domains and vice versa Change-Id: I94f9feb9eb2b678e76653bed0b022ed05af40fc1 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MoveDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/DisksAllocationPopupView.ui.xml 5 files changed, 49 insertions(+), 17 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94f9feb9eb2b678e76653bed0b022ed05af40fc1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Block live storage migration to domain of a different ...
by iheim＠redhat.com 03 Feb '14

03 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Block live storage migration to domain of a different type ...................................................................... core: Block live storage migration to domain of a different type This change fails live storage migration CDA part in case that the source storage domain and the destination domain are not both either a file type domain or a block domain Change-Id: Iec4c34132a1a619527627cfa47fa99df3a023b62 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 60 insertions(+), 14 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23962 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec4c34132a1a619527627cfa47fa99df3a023b62 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.3]: sos: engine: collect full service configuration
by sbonazzo＠redhat.com 03 Feb '14

03 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: engine: collect full service configuration ...................................................................... sos: engine: collect full service configuration Collect also /var/tmp/ovirt-engine/config content. Change-Id: Id41c3859731a77cb2c771d327730c277b81a8c54 Bug-Url: https://bugzilla.redhat.com/1060673 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 4f09866ebf9afd3462d02a0e1d349093bae592b9) (cherry picked from commit 512f17198bb5625c931a9dd98b612f7b437fe63a) --- M src/sos/plugins/engine.py 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id41c3859731a77cb2c771d327730c277b81a8c54 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Edit data center dialog chooses shared type as def...
by iheim＠redhat.com 03 Feb '14

03 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Edit data center dialog chooses shared type as default ...................................................................... webadmin: Edit data center dialog chooses shared type as default When editing a data center, the type combo box was always set to shared regardless of the actual data center type Change-Id: Iaaaf55768a72bc6f3f1349077ee9d54f41aa4995 Bug-Url: https://bugzilla.redhat.com/1057155 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaaaf55768a72bc6f3f1349077ee9d54f41aa4995 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: VmInit not setting authorized-keys
by shavivi＠redhat.com 03 Feb '14

03 Feb '14

Shahar Havivi has submitted this change and it was merged. Change subject: ui: VmInit not setting authorized-keys ...................................................................... ui: VmInit not setting authorized-keys Change-Id: I5afab0ef140361c23d08a0c5c6eb434eb8597c4c Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23918 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5afab0ef140361c23d08a0c5c6eb434eb8597c4c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: vminit set correct style for network checkboxes
by shavivi＠redhat.com 03 Feb '14

03 Feb '14

Shahar Havivi has submitted this change and it was merged. Change subject: ui: vminit set correct style for network checkboxes ...................................................................... ui: vminit set correct style for network checkboxes Change-Id: I9ca0e63de515827318b3d76c1539b7b2b754939f Bug-Url: https://bugzilla.redhat.com/1051041 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ca0e63de515827318b3d76c1539b7b2b754939f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0