- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: restapi : ints and shorts overflow
by iheim＠redhat.com 03 Feb '14

03 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: restapi : ints and shorts overflow ...................................................................... restapi : ints and shorts overflow int and short values are overflown before they even reach the business code, allowing for wrong values to be set. When posting to rest api, if the value of an int is greater than Integer.MAX_VALUE or value of a short is larger than Short.MAX_VALUE. The values are overflown when values are unmarshalled using JAXB. An excpetion should be raised during JAXB unmarshalling to indicate that the value is greater than the MAX_VALUE for the type. Change-Id: I9d0be6f3f220d7a5f58bb47906a8565d80e0ebf0 Bug-Url: https://bugzilla.redhat.com/1000796 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/IntegerParser.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/InvalidValueException.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/InvalidValueExceptionMapper.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/XmlMessageBodyReader.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 8 files changed, 151 insertions(+), 8 deletions(-) Approvals: Ravi Nori: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23949 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d0be6f3f220d7a5f58bb47906a8565d80e0ebf0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: setup: align user instruction for database creation
by ydary＠redhat.com 03 Feb '14

03 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: align user instruction for database creation ...................................................................... packaging: setup: align user instruction for database creation 'create user' -> 'create role' Change-Id: I3e66a39ba7a42402a0a25fce573eecf908a5a3dd Related-To: https://bugzilla.redhat.com/1040572 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/connection.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24001 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e66a39ba7a42402a0a25fce573eecf908a5a3dd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: setup: Configurating -> Configuring
by ydary＠redhat.com 03 Feb '14

03 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Configurating -> Configuring ...................................................................... packaging: setup: Configurating -> Configuring Change-Id: I69465d0153339a6907433dc67ac21fb567330133 Related-To: https://bugzilla.redhat.com/1031543 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69465d0153339a6907433dc67ac21fb567330133 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[ovirt-3.3]: packaging: added release notes
by ydary＠redhat.com 03 Feb '14

03 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: added release notes ...................................................................... packaging: added release notes Change-Id: I38b3fafb6edf6ca75ae9ecf48e7ba29ff6943b3e Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-engine-dwh.spec.in 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24013 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38b3fafb6edf6ca75ae9ecf48e7ba29ff6943b3e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: frontend: Console client page url retrieval
by iheim＠redhat.com 03 Feb '14

03 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: frontend: Console client page url retrieval ...................................................................... frontend: Console client page url retrieval Retrieving console client resources page should differentiate between absolute and relative links. Change-Id: Ib8da4313e8fa6bf4a3f170750ab6fab0d21869ea Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/DynamicMessages.java 1 file changed, 12 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Frank Kobzik: Verified Objections: oVirt Jenkins CI Server: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/24010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8da4313e8fa6bf4a3f170750ab6fab0d21869ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix action button regression fix
by awels＠redhat.com 03 Feb '14

03 Feb '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Fix action button regression fix ...................................................................... webadmin: Fix action button regression fix - Fixed certain situations where the previous fix failed to fix the visibility. The original fix didn't take into account the event handler that could change the visibility of an action button. So the original button would be visible then an event would make it invisible, but the flag would not get updated. Causing the fix to not work in certain cases. Change-Id: Ib3c5ccb0a8732b206c94591b930fc6a01456a47d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1058214 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java 1 file changed, 15 insertions(+), 15 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23920 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3c5ccb0a8732b206c94591b930fc6a01456a47d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-release[master]: Bumping to 3.3.3 repository
by sbonazzo＠redhat.com 03 Feb '14

03 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: Bumping to 3.3.3 repository ...................................................................... Bumping to 3.3.3 repository Change-Id: Ib440135ae373bf84c5fe17e7d5bd79e08525f974 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M el6-ovirt.repo M fedora-ovirt.repo M ovirt-release.spec.in 4 files changed, 11 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib440135ae373bf84c5fe17e7d5bd79e08525f974 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Console client page url retrieval
by awels＠redhat.com 03 Feb '14

03 Feb '14

Alexander Wels has submitted this change and it was merged. Change subject: frontend: Console client page url retrieval ...................................................................... frontend: Console client page url retrieval Retrieving console client resources page should differentiate between absolute and relative links. Change-Id: Ib8da4313e8fa6bf4a3f170750ab6fab0d21869ea Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/DynamicMessages.java 1 file changed, 12 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/24003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8da4313e8fa6bf4a3f170750ab6fab0d21869ea Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Collect metadata for packaging jobs.
by eedri＠redhat.com 03 Feb '14

03 Feb '14

Eyal Edri has submitted this change and it was merged. Change subject: Collect metadata for packaging jobs. ...................................................................... Collect metadata for packaging jobs. Change-Id: Ica3339549f0afe284ccdfad3cd083f4efccc880b Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- A jobs/packaging/gather_jobs_info.sh 1 file changed, 63 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Eyal Edri: Looks good to me, approved Kiril Nesenko: Verified -- To view, visit http://gerrit.ovirt.org/23985 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica3339549f0afe284ccdfad3cd083f4efccc880b Gerrit-PatchSet: 14 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: history: Added is_local_storage to dwh_datacenter_configurat...
by iheim＠redhat.com 03 Feb '14

03 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: history: Added is_local_storage to dwh_datacenter_configuration_history_view ...................................................................... history: Added is_local_storage to dwh_datacenter_configuration_history_view This patch adds is_local_storage to dwh_datacenter_configuration_history_view A storage pool can be marked as local - contains local on host storage or shared - contains shared storages of various types. Change-Id: I5100ec6dd030b096f8fa1f644f4e2b8be8916817 Related-To: https://bugzilla.redhat.com/1038053 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/dbscripts/create_dwh_views.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Yaniv Dary: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24000 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5100ec6dd030b096f8fa1f644f4e2b8be8916817 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0