- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: setup: do not attempt to get websocket proxy stat...
by sbonazzo＠redhat.com 01 Jan '14

01 Jan '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: do not attempt to get websocket proxy status in devenv ...................................................................... packaging: setup: do not attempt to get websocket proxy status in devenv Change-Id: I0454e3f136ad1181bc01c55411b33b1e2fc20e4c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0454e3f136ad1181bc01c55411b33b1e2fc20e4c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-cli[master]: cli: Accept intermixed arguments and options
by juan.hernandez＠redhat.com 01 Jan '14

01 Jan '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Accept intermixed arguments and options ...................................................................... cli: Accept intermixed arguments and options Currently the syntax of a command requires all the arguments to appear before all the options. This complicates things when the value of an option is required by the autocompletion mechanism in order to decide which are the acceptable arguments. This patch changes the parsing rules so that arguments and options can be freely intermixed. Change-Id: I8c1f6982e7beddb17a4668f5719294a8aaae3c2e Bug-Url: https://bugzilla.redhat.com/1047513 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/cli/context.py M src/cli/parser.py 2 files changed, 35 insertions(+), 31 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22866 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c1f6982e7beddb17a4668f5719294a8aaae3c2e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: Revert "cli: mismatch between restore snapshot syntax and au...
by juan.hernandez＠redhat.com 01 Jan '14

01 Jan '14

Juan Hernandez has submitted this change and it was merged. Change subject: Revert "cli: mismatch between restore snapshot syntax and auto completion #1027298" ...................................................................... Revert "cli: mismatch between restore snapshot syntax and auto completion #1027298" This reverts commit 870b0c as it introduces a regression: moving the options to the end of the command moves them past the redirections and pipes, and this causes a syntax error. This is the bug that the change intended to fix: https://bugzilla.redhat.com/1047513 A later patch introduces changes in the syntax of commands allowing mixing arguments and options. That fixes the above bug as well as the regression. Change-Id: I7b85120e6479c4be3dd2357ef8731cd1388b8885 Bug-Url: https://bugzilla.redhat.com/1047513 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtcli/infrastructure/historymanager.py M src/ovirtcli/shell/actioncmdshell.py M src/ovirtcli/shell/engineshell.py 3 files changed, 4 insertions(+), 86 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b85120e6479c4be3dd2357ef8731cd1388b8885 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix coverity warnings
by masayag＠redhat.com 01 Jan '14

01 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: core: Fix coverity warnings ...................................................................... core: Fix coverity warnings Fixed the following: 1. Inner class should be static 2. The labels field was never accessed Change-Id: I656ff0e494ed90403a1abe0fb8de8b241e5ffb04 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/NetworkLabelFormatValidatorTest.java 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I656ff0e494ed90403a1abe0fb8de8b241e5ffb04 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: SKIPPED_CLASS_TOO_BIG in ApplicatioConstants
by oourfali＠redhat.com 01 Jan '14

01 Jan '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: SKIPPED_CLASS_TOO_BIG in ApplicatioConstants ...................................................................... core: SKIPPED_CLASS_TOO_BIG in ApplicatioConstants Re-added the exclusion of SKIPPED_CLASS_TOO_BIG on org.ovirt.engine.ui.webadmin.ApplicationConstants which was mistakenly removed by efd0d3ba39b6061d67626966eda983637c205f9e. Change-Id: I47904dbd3add87f90e23d06b91161014fc322421 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/webadmin/exclude-filters.xml 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified Alissa Bonas: Looks good to me, but someone else must approve Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22881 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47904dbd3add87f90e23d06b91161014fc322421 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Ignore FindBugs unconfirmed cast warning
by oourfali＠redhat.com 01 Jan '14

01 Jan '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Ignore FindBugs unconfirmed cast warning ...................................................................... webadmin: Ignore FindBugs unconfirmed cast warning Ignore all the unconfirmed casts in the gwt-common, uicommonweb and webadmin modules. Unfortunately, these warnings are currently inherit to the design, and handling them on an individual basis just adds noise to the process. Change-Id: I142db2592a9fe7b38a6751bcc362546ef46cc857 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/exclude-filters.xml M frontend/webadmin/modules/uicommonweb/exclude-filters.xml M frontend/webadmin/modules/webadmin/exclude-filters.xml 3 files changed, 23 insertions(+), 371 deletions(-) Approvals: Allon Mureinik: Verified Alissa Bonas: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I142db2592a9fe7b38a6751bcc362546ef46cc857 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: avoid db deadlock and unneeded db updates for images
by iheim＠redhat.com 31 Dec '13

31 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: core: avoid db deadlock and unneeded db updates for images ...................................................................... core: avoid db deadlock and unneeded db updates for images When adding a VM from template (as part of pool or not), CreateSnapshotFromTemplateCommand is being executed and when the operation ends its end method is being called for each of the disks. In the end method there's an attempt to unlock the template image which causes to numerous issues: 1. There are attempts to update the template disks statuses to ok, as the updates aren't ordered and are executed for each added vm based on that template - db deadlocks occur. 2.Currently the template disks aren't being locked at all (which should be inspected regardless), so there's currently no point in unlocking them. The fix which is introduced is to not update the image status if it's already in the desired status, which will reduce the updates count in general and will prevent possible db deadlocks in the provided scenarios. Change-Id: I26a09ce674cfefd59819f3edf95accab31f0e80e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1047163 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified Liron Ar: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/22844 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26a09ce674cfefd59819f3edf95accab31f0e80e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add helper for buildStoragePoolDomainsMap
by amureini＠redhat.com 31 Dec '13

31 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: add helper for buildStoragePoolDomainsMap ...................................................................... core: add helper for buildStoragePoolDomainsMap Change-Id: Iefa82eaf8ac6e2ad46a411183668901fd6215368 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/StoragePoolDomainHelper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ReconstructMasterVDSCommand.java 2 files changed, 31 insertions(+), 12 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefa82eaf8ac6e2ad46a411183668901fd6215368 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: remove unused AbstractSubTabActionTree and its xml
by derez＠redhat.com 31 Dec '13

31 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: ui: remove unused AbstractSubTabActionTree and its xml ...................................................................... ui: remove unused AbstractSubTabActionTree and its xml Solves 2 findbugs warnings. Change-Id: I7dfe0048c53675bf0e25fc52091601c3d667060e Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/AbstractSubTabActionTree.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/AbstractSubTabActionTree.ui.xml 2 files changed, 0 insertions(+), 164 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22807 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7dfe0048c53675bf0e25fc52091601c3d667060e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[ovirt-3.3]: packging: fixed remote install setup
by ydary＠redhat.com 31 Dec '13

31 Dec '13

Yaniv Dary has submitted this change and it was merged. Change subject: packging: fixed remote install setup ...................................................................... packging: fixed remote install setup Change-Id: Ic315856f91c60f240c6830fb90e5b259774e9745 Bug-Url: https://bugzilla.redhat.com/1045846 Bug-Url: https://bugzilla.redhat.com/1047392 Bug-Url: https://bugzilla.redhat.com/1045855 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/common_utils.py M packaging/ovirt-engine-dwh-setup.py 2 files changed, 161 insertions(+), 94 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic315856f91c60f240c6830fb90e5b259774e9745 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0