- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: fix findbugs warning on ProviderModel
by oourfali＠redhat.com 30 Dec '13

30 Dec '13

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: fix findbugs warning on ProviderModel ...................................................................... webadmin: fix findbugs warning on ProviderModel This patch fixes a findbugs warning in ProviderModel, as we case a variable that's known to be null. The fix just passes null, and in order to be able to address the ambiguity, the method name was renamed according to the use-case. Change-Id: I94c5ff1cde5c76a89ea0c56022e306a264905066 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java 1 file changed, 1 insertion(+), 15 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22805 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94c5ff1cde5c76a89ea0c56022e306a264905066 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: exclude a findbugs warning in AsyncQuery
by oourfali＠redhat.com 30 Dec '13

30 Dec '13

Oved Ourfali has submitted this change and it was merged. Change subject: ui: exclude a findbugs warning in AsyncQuery ...................................................................... ui: exclude a findbugs warning in AsyncQuery Warning of type UWF_NULL_FIELD was produced on converterCallback field, though it is initialized by other classes, hence it's a false warning. Change-Id: I562f96123aea747c76e37fabde0a51fdd36dbbbb Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/frontend/exclude-filters.xml 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Alissa Bonas: Verified Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I562f96123aea747c76e37fabde0a51fdd36dbbbb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: fix findbugs exclude filter.
by oourfali＠redhat.com 29 Dec '13

29 Dec '13

Oved Ourfali has submitted this change and it was merged. Change subject: ui: fix findbugs exclude filter. ...................................................................... ui: fix findbugs exclude filter. The numbering of anonymous classes changed due to a refactoring, and hence the exclude filter didn't mask the warnings properly. Change-Id: If96b5a6214dcefe47fae37fd7c1ccdd364166e33 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/exclude-filters.xml 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If96b5a6214dcefe47fae37fd7c1ccdd364166e33 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: rename member to start with lowercase in ProvideProperty...
by derez＠redhat.com 29 Dec '13

29 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: ui: rename member to start with lowercase in ProvidePropertyChangedEvent ...................................................................... ui: rename member to start with lowercase in ProvidePropertyChangedEvent Change-Id: If06684743e7563bd39fdfa86ba853b9cd903894a Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/EntityModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/ProvidePropertyChangedEvent.java 5 files changed, 6 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If06684743e7563bd39fdfa86ba853b9cd903894a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: rename members to start with lowercase
by derez＠redhat.com 29 Dec '13

29 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: ui: rename members to start with lowercase ...................................................................... ui: rename members to start with lowercase Change-Id: I361a44bf1f418a78ee7679bae6083dcfae70830e Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AsyncIteratorCallback.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/ReversibleFlow.java 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I361a44bf1f418a78ee7679bae6083dcfae70830e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: rename members to start with lowercase in *Model classes
by derez＠redhat.com 29 Dec '13

29 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: ui: rename members to start with lowercase in *Model classes ...................................................................... ui: rename members to start with lowercase in *Model classes Solves findbugs warnings. Change-Id: I6f2f8d44e3d210f3ae7d39cac3515314a2632ac6 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22758 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f2f8d44e3d210f3ae7d39cac3515314a2632ac6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Cannot add hypervisor host when use chinese support
by iheim＠redhat.com 29 Dec '13

29 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Cannot add hypervisor host when use chinese support ...................................................................... webadmin: Cannot add hypervisor host when use chinese support When adding a new host using chinese locale the root user name gets localized leading to error in user name when trying to establish an ssh session Change-Id: Ifdc4a332a297bca1b7c99bc6ede5a5aeacbc6431 Bug-Url: https://bugzilla.redhat.com/1045471 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/InstallModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 3 files changed, 3 insertions(+), 5 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdc4a332a297bca1b7c99bc6ede5a5aeacbc6431 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: exclude findbugs warning in Backend class
by oourfali＠redhat.com 29 Dec '13

29 Dec '13

Oved Ourfali has submitted this change and it was merged. Change subject: engine: exclude findbugs warning in Backend class ...................................................................... engine: exclude findbugs warning in Backend class Exclude a BC_UNCONFIRMED_CAST warning. Change-Id: Ic4346f8a85ef027d5e4285a3ecc341b661a2ed4f Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4346f8a85ef027d5e4285a3ecc341b661a2ed4f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[master]: core: log: survive invalid log file
by Alon Bar-Lev 29 Dec '13

29 Dec '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: log: survive invalid log file ...................................................................... core: log: survive invalid log file Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1044993 Change-Id: If1da48cc50985a3d353964466f38babbbd42f4f3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/otopi/core/log.py 2 files changed, 34 insertions(+), 9 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/22625 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1da48cc50985a3d353964466f38babbbd42f4f3 Gerrit-PatchSet: 5 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: requiring permissions to manage tags, bookmarks and no...
by oourfali＠redhat.com 29 Dec '13

29 Dec '13

Oved Ourfali has submitted this change and it was merged. Change subject: core: requiring permissions to manage tags, bookmarks and notifications ...................................................................... core: requiring permissions to manage tags, bookmarks and notifications This patch adds three new action groups, and three new roles, used to manage tags, bookmarks and notifications. Relevant commands were once allowed for every administrator, so the upgrade process adds these action groups to every admin role that includes more than the login permissions action group (to solve the ReadOnlyAdmin use-case). So, after upgrade all the user roles will be left unchanged. All the admin roles will now contain the new action groups, except for admin roles that only contain the login action group. Change-Id: I477bca5703f59c67914e6395118e29d53fa7d007 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AdminOperationCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BookmarkCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PredefinedRoles.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties A packaging/dbscripts/upgrade/03_04_0330_add_admin_operations_action_groups_and_roles.sql 13 files changed, 159 insertions(+), 76 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22731 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I477bca5703f59c67914e6395118e29d53fa7d007 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0