- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: ui: rename members to start with lowercase
by derez＠redhat.com 26 Dec '13

26 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: ui: rename members to start with lowercase ...................................................................... ui: rename members to start with lowercase Rename members in several classes to start with lowercase. Resolves findbugs warnings Change-Id: I9675f2ca2f9ad5a0b2c57d70870b2a8fe8c86a17 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModelErrorEventListener.java 4 files changed, 8 insertions(+), 8 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9675f2ca2f9ad5a0b2c57d70870b2a8fe8c86a17 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: rename member to lowercase in VmGeneralModel
by derez＠redhat.com 26 Dec '13

26 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: ui: rename member to lowercase in VmGeneralModel ...................................................................... ui: rename member to lowercase in VmGeneralModel Change-Id: I67c3486f7dc1f44fbaa827262ae0665b6b26ab4e Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67c3486f7dc1f44fbaa827262ae0665b6b26ab4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Reload host after cluster update
by juan.hernandez＠redhat.com 25 Dec '13

25 Dec '13

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Reload host after cluster update ...................................................................... restapi: Reload host after cluster update When a host is updated the backend requires an special handling of the cluster: due to permissions issues it has to be changed with the special ChangeVDSCluster command. The rest of properties of the host can be changed with the UpdateVds command. Due to this limitation the REST API performs the update in two steps: first it checks if the cluster needs to be udpated and then runs the ChangeVDSCluster command, then it updates the rest of the attributes with the UpdateVds command. But the host entity is loaded before the first command, and then passed to the second as a parameter, thus it contains the old cluster id. The UpdateVds command checks this and refuses the execute the operation because it thinks that the cluster is changing. To solve this problem we are reloading the entity after changing the cluster and before sending it to the UpdateVds command. Change-Id: If6470ad9ce07a3a5f68146d0b73b2f50ba508b0f Bug-Url: https://bugzilla.redhat.com/1046336 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java 2 files changed, 8 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6470ad9ce07a3a5f68146d0b73b2f50ba508b0f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Initialize Mom Policies Severities
by gchaplik＠redhat.com 25 Dec '13

25 Dec '13

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: Initialize Mom Policies Severities ...................................................................... engine: Initialize Mom Policies Severities When added audit log types for mom policies, their severities should have been initialized. Change-Id: I654845ec76bd876399b4206657a660eef4172612 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/22735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I654845ec76bd876399b4206657a660eef4172612 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove redundant fetch of vm disks on run vm
by ofrenkel＠redhat.com 25 Dec '13

25 Dec '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: remove redundant fetch of vm disks on run vm ...................................................................... core: remove redundant fetch of vm disks on run vm There is no need to fetch the VM disks from the DB after we start to create stateless images on run VM as stateless flow. We fetch them in order to update the VM which is local to the RunVmCommand instance with the stateless images. But it is not used later on in the execute phase of the command, and the end-action phase is invoked on a new instance of RunVmCommand anyway. Change-Id: I39f761ce6ed9563dfc1473afd1e7d330bc95bb20 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/22662 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39f761ce6ed9563dfc1473afd1e7d330bc95bb20 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix regression that cleared run once flag
by ofrenkel＠redhat.com 25 Dec '13

25 Dec '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix regression that cleared run once flag ...................................................................... core: fix regression that cleared run once flag We store a flag that indicates whether the VM is run in run once mode or not. The batch updates in VdsUpdateRuntimeInfo didn't update this flag correctly, which caused it to be cleared always by the monitoring. This patch fix this regression by adding the run-once attribute to the mapper that is used by the batch updates of VmDynamic. Change-Id: Ifc2bfe9c500f649dff39f4bbfae6d4b7e57cf883 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc2bfe9c500f649dff39f4bbfae6d4b7e57cf883 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix NPE for removing non existing template
by ofrenkel＠redhat.com 25 Dec '13

25 Dec '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix NPE for removing non existing template ...................................................................... core: fix NPE for removing non existing template The locking message assume the template being removed exist in the DB, therefore NPE can be thrown there. Added a null check and in case the template is null, we won't try to lock the template (that is ok since the can-do-action phase is going to fail anyway). Change-Id: Id3eeb1d34d4e6320961ee8b360715b29003f1a68 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/14712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3eeb1d34d4e6320961ee8b360715b29003f1a68 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: rename members to start with lowercase in SpiceConsoleModel
by derez＠redhat.com 25 Dec '13

25 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: ui: rename members to start with lowercase in SpiceConsoleModel ...................................................................... ui: rename members to start with lowercase in SpiceConsoleModel Solves 4 findbugs warnings Change-Id: I1f14801edfea446476aef8ef6ec2a897c7d89efa Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractSpice.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java 2 files changed, 12 insertions(+), 12 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f14801edfea446476aef8ef6ec2a897c7d89efa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: rename members to start with lowercase in BookmarkListModel
by derez＠redhat.com 25 Dec '13

25 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: ui: rename members to start with lowercase in BookmarkListModel ...................................................................... ui: rename members to start with lowercase in BookmarkListModel Solves findbugs warnings Change-Id: I99677d2d9d6a8666d34326768bffc52622b1b9e2 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java 2 files changed, 7 insertions(+), 7 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99677d2d9d6a8666d34326768bffc52622b1b9e2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: rename members to start with lowercase in several classes
by derez＠redhat.com 25 Dec '13

25 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: ui: rename members to start with lowercase in several classes ...................................................................... ui: rename members to start with lowercase in several classes Solves findbugs warnings. Change-Id: I3208a2f2c64685b2f7efa3e4766905f953ee509d Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/ChangeCDModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmItemBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 5 files changed, 14 insertions(+), 13 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3208a2f2c64685b2f7efa3e4766905f953ee509d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0