- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: gluster: fix event message to display no. of bricks removed
by ofrenkel＠redhat.com 09 Dec '13

09 Dec '13

Omer Frenkel has submitted this change and it was merged. Change subject: gluster: fix event message to display no. of bricks removed ...................................................................... gluster: fix event message to display no. of bricks removed Add no. of bricks and volume details to the commit remove brick event message. Change-Id: I8ab4cf126812d3cd9a42348e35b0a60fd29d59ca Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1035124 Signed-off-by: Timothy Asir <tjeyasin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CommitRemoveGlusterVolumeBricksCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ab4cf126812d3cd9a42348e35b0a60fd29d59ca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Fix add host gluster uuid already exists in the db.
by kmayilsa＠redhat.com 09 Dec '13

09 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Fix add host gluster uuid already exists in the db. ...................................................................... gluster: Fix add host gluster uuid already exists in the db. Check whether add host uuid already exists in the database and throw an appropriate error message. Change-Id: I1cca4c64cdbcb6a681089e1fbb2f0d707f768083 Signed-off-by: Timothy Asir <tjeyasin(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=992899 Signed-off-by: Timothy Asir <tjeyasin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 8 files changed, 36 insertions(+), 15 deletions(-) Approvals: Timothy Asir: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21391 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cca4c64cdbcb6a681089e1fbb2f0d707f768083 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fixing user types cleanup support
by emesika＠redhat.com 09 Dec '13

09 Dec '13

Eli Mesika has submitted this change and it was merged. Change subject: core: fixing user types cleanup support ...................................................................... core: fixing user types cleanup support Changing implementation code to support PG version < 9.2 Since we support CentOS 6.5 that comes with PG 8.4, the query that gets the user defined types cannot rely on the user_defined_types view that was added only in PG 9.2. This patch changed the underlying PG query to use basic pg tables that exists in PG 8.4 and up. Change-Id: I9a13cbf218bc39f9b5d3f988e10cfadb7121af67 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/common_sp.sql M packaging/setup/ovirt_engine_setup/database.py 2 files changed, 9 insertions(+), 5 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22170 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a13cbf218bc39f9b5d3f988e10cfadb7121af67 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: unlock_entity should unlock unattached disks
by emesika＠redhat.com 09 Dec '13

09 Dec '13

Eli Mesika has submitted this change and it was merged. Change subject: core: unlock_entity should unlock unattached disks ...................................................................... core: unlock_entity should unlock unattached disks unlock_entity.sh script does not unlock locked images that are not attached to any VM. The script should unlock any disks, even such that were created and are not attached to a VM. Change-Id: I8346f0ae34a7b2ea9d4ce4281dbebdb67a554ac0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1032910 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/common_sp.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22156 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8346f0ae34a7b2ea9d4ce4281dbebdb67a554ac0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Explicit MAC independent of pool size
by mkolesni＠redhat.com 09 Dec '13

09 Dec '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Explicit MAC independent of pool size ...................................................................... engine: Explicit MAC independent of pool size Explicit MAC was changed by mistake to be dependent on the MAC pool size, changing back so that if an explicit MAC address is specified the pool is not checked if more MACs are available or not. Change-Id: I073a6fafee23211f6a66a03767a6913b5b564650 Bug-Url: https://bugzilla.redhat.com/1039103 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I073a6fafee23211f6a66a03767a6913b5b564650 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: update firewall for all services
by iheim＠redhat.com 09 Dec '13

09 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: update firewall for all services ...................................................................... packaging: setup: update firewall for all services Update the firewall for websocket_proxy and postgresql not only during setup. Always ask whether to update the firewall and do not keep the answer in the postinstall answer file, to allow users to keep their manual changes on upgrades. Output manual configuration instructions only for supported firewall managers. Bug-Url: https://bugzilla.redhat.com/1024707 Bug-Url: https://bugzilla.redhat.com/1029020 Bug-Url: https://bugzilla.redhat.com/1023316 Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py A packaging/setup/ovirt_engine_setup/firewall_manager_base.py A packaging/setup/plugins/ovirt-engine-common/network/__init__.py A packaging/setup/plugins/ovirt-engine-common/network/firewall_manager.py A packaging/setup/plugins/ovirt-engine-common/network/firewall_manager_firewalld.py A packaging/setup/plugins/ovirt-engine-common/network/firewall_manager_human.py A packaging/setup/plugins/ovirt-engine-common/network/firewall_manager_iptables.py A packaging/setup/plugins/ovirt-engine-common/network/process_firewalld_services.py M packaging/setup/plugins/ovirt-engine-remove/network/__init__.py A packaging/setup/plugins/ovirt-engine-remove/network/firewall_manager.py D packaging/setup/plugins/ovirt-engine-remove/network/firewalld.py M packaging/setup/plugins/ovirt-engine-setup/config/websocket_proxy.py M packaging/setup/plugins/ovirt-engine-setup/legacy/__init__.py D packaging/setup/plugins/ovirt-engine-setup/legacy/firewall_manager.py M packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py M packaging/setup/plugins/ovirt-engine-setup/provisioning/postgres.py 16 files changed, 954 insertions(+), 393 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22181 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: do not attempt to start websocket proxy at...
by iheim＠redhat.com 09 Dec '13

09 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: do not attempt to start websocket proxy at development mode ...................................................................... packaging: setup: do not attempt to start websocket proxy at development mode Change-Id: I40f061ec6cf658e1d8ec5c3663698ceca7569b38 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/config/websocket_proxy.py 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22183 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40f061ec6cf658e1d8ec5c3663698ceca7569b38 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Change gluster brick status to Unknown
by kmayilsa＠redhat.com 09 Dec '13

09 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Change gluster brick status to Unknown ...................................................................... engine: Change gluster brick status to Unknown When a host goes to non responsive state, change the gluster brick's status on the host to Unknown Change-Id: I80f0e581b86a34b649343a931eaccf8e41b8e275 Bug-Url: https://bugzilla.redhat.com/1021441 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterStatus.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/GlusterState.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GlusterBrickMapper.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/BrickStatusCell.java 5 files changed, 28 insertions(+), 4 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/21951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80f0e581b86a34b649343a931eaccf8e41b8e275 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: fix to remove multiple host when hosts are in maint...
by ofrenkel＠redhat.com 09 Dec '13

09 Dec '13

Omer Frenkel has submitted this change and it was merged. Change subject: gluster: fix to remove multiple host when hosts are in maintenance ...................................................................... gluster: fix to remove multiple host when hosts are in maintenance Add a lock to wait for complete gluster command execution and release Change-Id: I0f74af59dc0723eda46ac1b7c53b2a980c49fda4 Signed-off-by: Timothy Asir <tjeyasin(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1024997 Signed-off-by: Timothy Asir <tjeyasin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterJob.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJobTest.java 4 files changed, 30 insertions(+), 29 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f74af59dc0723eda46ac1b7c53b2a980c49fda4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: fixed findbugs issue
by tjelinek＠redhat.com 09 Dec '13

09 Dec '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: fixed findbugs issue ...................................................................... frontend: fixed findbugs issue renamed method to lowercase Change-Id: I042faba1ae2ff6640fd221e920f2bc8251867668 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I042faba1ae2ff6640fd221e920f2bc8251867668 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0