- Engine-commits - oVirt List Archives

Change in ovirt-guest-agent[master]: pam: Fix the pam conversation approach
by vfeenstr＠redhat.com 10 Dec '13

10 Dec '13

Vinzenz Feenstra has submitted this change and it was merged. Change subject: pam: Fix the pam conversation approach ...................................................................... pam: Fix the pam conversation approach Until now our PAM conversation was errorneous using pam_get_user which is not correct for requests other than accquiring the username. To correctly request the Token from the frontend we have to use a PAM conversation. This is done via the pam_prompt function. We also do check now, if the requesting user (if set) is identical with the preset user. If this is not the case we will not unlock the screen. Preset users should only be available if the screen was locked. If the usernames aren't equal, the module will return PAM_CRED_UNAVAIL. Additionally the logging was rewritten to use the syslog and more comments have been added to describe the steps we're doing. Change-Id: I4455ea61ffb27e854fe93bdc51068e12617955a2 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M pam-ovirt-cred/pam_ovirt_cred.c 1 file changed, 59 insertions(+), 26 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4455ea61ffb27e854fe93bdc51068e12617955a2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: correct status code for add brick when volume is down.
by kmayilsa＠redhat.com 10 Dec '13

10 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: restapi: correct status code for add brick when volume is down. ...................................................................... restapi: correct status code for add brick when volume is down. In Method resolveCreatedList for populating entity, populate method is used instead of doPopulate. As doPopulate doesnot return proper status code when the volume is down. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1018904 Change-Id: Ic6c680383ea75d898a6496c86daabe38630f9d18 Signed-off-by: ndarshan <dnarayan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResourceTest.java 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Darshan N: Verified -- To view, visit http://gerrit.ovirt.org/21941 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6c680383ea75d898a6496c86daabe38630f9d18 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: hide migration for removing replicated bricks
by kmayilsa＠redhat.com 10 Dec '13

10 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: hide migration for removing replicated bricks ...................................................................... webadmin: hide migration for removing replicated bricks 'Migrate Data' option in 'Remove Bricks' dilog will not be shown if the bricks are not from same sub-volume (Reducing replica count). Change-Id: Ia7fd98c0b262deff26bf9e77839ee347d5869189 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7fd98c0b262deff26bf9e77839ee347d5869189 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: fill task parameters in async task status query
by kmayilsa＠redhat.com 10 Dec '13

10 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: fill task parameters in async task status query ...................................................................... gluster: fill task parameters in async task status query Updating the async task with task parameters in async task status query so that task summary gets updated with proper volume name Change-Id: I3cf2f7cc9f633d99a673879a0876919ead5fb843 Bug-Url: https://bugzilla.redhat.com/1037607 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncTaskStatusQueryBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTaskUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJobTest.java 3 files changed, 8 insertions(+), 3 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit http://gerrit.ovirt.org/22083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3cf2f7cc9f633d99a673879a0876919ead5fb843 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: event message for stop remove brick
by kmayilsa＠redhat.com 10 Dec '13

10 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: event message for stop remove brick ...................................................................... gluster: event message for stop remove brick Adding event message for stop remove brick action. Change-Id: I2fdf50f6395e61578edab8319b0740d2c8fb0082 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties A packaging/dbscripts/upgrade/03_04_0190_gluster_async_tasks_stop_remove-brick_event_map.sql 5 files changed, 10 insertions(+), 3 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit http://gerrit.ovirt.org/21909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fdf50f6395e61578edab8319b0740d2c8fb0082 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: fix error logging
by yzaslavs＠redhat.com 09 Dec '13

09 Dec '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: fix error logging ...................................................................... tools: fix error logging Bug-Url: https://bugzilla.redhat.com/1037894 This patch fixes error logging for manage-domains tool to log the full stack trace if debug level is turn on. Change-Id: Ibd9a15e5bf1620c8827476da055c88a27d093cf5 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KerberosConfigCheck.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22062 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd9a15e5bf1620c8827476da055c88a27d093cf5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Fixing edit action of manage-domains
by yzaslavs＠redhat.com 09 Dec '13

09 Dec '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Fixing edit action of manage-domains ...................................................................... tools: Fixing edit action of manage-domains Bug-Url: https://bugzilla.redhat.com/1037894 The following patches fixes the edit action of manage-domains tool to support edit of values provided by the "ldapServers" argument. Prior to this fix, the change was not stored at the proper location at the vdc_options table. Bare in mind that if -ldapServers is not provided during the edit action no change will be made to the entry. Change-Id: I9f86b8ce2c697931b9c8388ea87fe07d557530c6 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java 1 file changed, 27 insertions(+), 16 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f86b8ce2c697931b9c8388ea87fe07d557530c6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: rename method to lowercase in SyncronizeNumberOfAsyn...
by derez＠redhat.com 09 Dec '13

09 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: engine: rename method to lowercase in SyncronizeNumberOfAsyncOperations ...................................................................... engine: rename method to lowercase in SyncronizeNumberOfAsyncOperations Change-Id: I9fc019ba6ad4cbf27ed3aa3f3a3939eeeeef9b2a Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SyncronizeNumberOfAsyncOperations.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22169 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fc019ba6ad4cbf27ed3aa3f3a3939eeeeef9b2a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rm unused method in AddDiskToVmCommandTest
by amureini＠redhat.com 09 Dec '13

09 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm unused method in AddDiskToVmCommandTest ...................................................................... core: rm unused method in AddDiskToVmCommandTest Patch 73499ce148500edc73642fb6c548ad597a932f6e changed the mocking scheme of this test. As a result, the method mockStorageDomain(Guid, int, int) remained unused. This patch remove the unneeded method. Change-Id: I5163e6d9615ad3e0c44edcf00d43f3cb04aa3d7c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/22210 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5163e6d9615ad3e0c44edcf00d43f3cb04aa3d7c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: increase memory threshold check to 10%
by sbonazzo＠redhat.com 09 Dec '13

09 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: increase memory threshold check to 10% ...................................................................... packaging: setup: increase memory threshold check to 10% Change-Id: I5fa5ca2fd74940df47e4f137efb8346abcdc4814 Bug-Url: https://bugzilla.redhat.com/1034797 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/system/memcheck.py 2 files changed, 12 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fa5ca2fd74940df47e4f137efb8346abcdc4814 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0